[meta-oe,walnascar[PATCH,1/4] php: sort PACKAGECONFIG options

From: Jeroen Hofstee <jhofstee@victronenergy.com>

This backports commit bb896f6b6f92 ("php: sort PACKAGECONFIG options"),
which was missing in 8.4.5 and helps in reducing unnecessary diffs in
future upgrades.

Reference:
https://git.openembedded.org/meta-openembedded/commit/meta-oe?id=bb896f6b6f92863e8f5c49e5a1f7d9bcb2578db0

Signed-off-by: Praveen Kumar <praveen.kumar@windriver.com>
---
 meta-oe/recipes-devtools/php/php_8.4.6.bb | 22 ++++++++++------------
 1 file changed, 10 insertions(+), 12 deletions(-)

Hi Praveen,

On 7/30/25 14:31, Praveen Kumar wrote:
> [You don't often get email from praveen.kumar@windriver.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> From: Jeroen Hofstee <jhofstee@victronenergy.com>
>
> This backports commit bb896f6b6f92 ("php: sort PACKAGECONFIG options"),
> which was missing in 8.4.5 and helps in reducing unnecessary diffs in
> future upgrades.

This isn't missing anything. Cleanups like this are not
supposed to be backported.

With kind regards,

Jeroen

Hi Jeroen,

Thanks for the feedback.

I understand this is a cleanup, but we are actively maintaining this branch, having the PACKAGECONFIG options sorted makes it easier to manage. It helps reduce unnecessary diff when we compare the same with the master branch or apply future updates.

Keeping this patch would help us avoid conflicts later and make upgrades easier. Will it be fine to keep this patch for easier upgradation and maintenance?

Please suggest your views on this, can we keep this patch for better alignment of future upgradation or do I need to resend the v2 of this upgrade without this patch.

Thanks,
Praveen

Hi Praveen,

I have no strong feelings about this. I just purposely didn't
sent it to older branches, since it doesn't fix a php issue or
CVE, just readability and for future maintenance , so in that
sense there isn't anything missing, nothing is broken without
this patch.

If you are cherry-picking patches back, which I understand
you are doing, I understand you want to include that patch,
else you get in a lot of silly, unnecessary conflicts.

But for other meta changes, like lets say more PACKAGES,
but without according recommends you can break things
with meta-data alone.

I guess it is just up to the maintainers,

With kind regards,
Jeroen

On 8/1/25 11:41, Kumar, Praveen wrote:

> Thanks for the feedback.
>
> I understand this is a cleanup, but we are actively maintaining this 
> branch, having the PACKAGECONFIG options sorted makes it easier to 
> manage. It helps reduce unnecessary diff when we compare the same with 
> the master branch or apply future updates.
>
> Keeping this patch would help us avoid conflicts later and make 
> upgrades easier. Will it be fine to keep this patch for easier 
> upgradation and maintenance?
>
> Please suggest your views on this, can we keep this patch for better 
> alignment of future upgradation or do I need to resend the v2 of this 
> upgrade without this patch.
>
> Thanks,
> Praveen
> ------------------------------------------------------------------------
> *From:* Jeroen Hofstee <jhofstee@victronenergy.com>
> *Sent:* Thursday, July 31, 2025 12:38 AM
> *To:* Kumar, Praveen <Praveen.Kumar@windriver.com>; 
> openembedded-devel@lists.openembedded.org 
> <openembedded-devel@lists.openembedded.org>
> *Subject:* Re: [oe][meta-oe][walnascar[PATCH 1/4] php: sort 
> PACKAGECONFIG options
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender 
> and know the content is safe.
>
> Hi Praveen,
>
> On 7/30/25 14:31, Praveen Kumar wrote:
> > [You don't often get email from praveen.kumar@windriver.com. Learn 
> why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> >
> > From: Jeroen Hofstee <jhofstee@victronenergy.com>
> >
> > This backports commit bb896f6b6f92 ("php: sort PACKAGECONFIG options"),
> > which was missing in 8.4.5 and helps in reducing unnecessary diffs in
> > future upgrades.
>
> This isn't missing anything. Cleanups like this are not
> supposed to be backported.
>
> With kind regards,
>
> Jeroen
>