diff mbox series

systemd: remove 'serial-getty-generator' PACKAGECONFIG

Message ID 20250716025258.738590-1-Qi.Chen@windriver.com
State New
Headers show
Series systemd: remove 'serial-getty-generator' PACKAGECONFIG | expand

Commit Message

ChenQi July 16, 2025, 2:52 a.m. UTC 
From: Chen Qi <Qi.Chen@windriver.com>

This PACKAGECONFIG's net effect is to delete systemd-getty-generator
when not enabled. But deleting systemd-getty-generator really does not
have any benefit. Here are the reasons:
1) The units installed by systemd-serialgetty.bb have higher priority than
   the generated one. Because .../generator/ directory has lower priority
   than the system admin directory /etc. See [2] for more details.
2) The generator could be disabled via kernel command line "systemd.getty_auto=".
   See [1] for more details.

[1] https://www.freedesktop.org/software/systemd/man/latest/systemd-getty-generator.html
[2] https://www.freedesktop.org/software/systemd/man/latest/systemd.generator.html#

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 meta/recipes-core/systemd/systemd_257.6.bb | 12 ------------
 1 file changed, 12 deletions(-)

Comments

Ross Burton July 21, 2025, 1:32 p.m. UTC | #1 
Hi Chen,

On 16 Jul 2025, at 03:52, Chen Qi via lists.openembedded.org <Qi.Chen=windriver.com@lists.openembedded.org> wrote:
> This PACKAGECONFIG's net effect is to delete systemd-getty-generator
> when not enabled. But deleting systemd-getty-generator really does not
> have any benefit. Here are the reasons:
> 1) The units installed by systemd-serialgetty.bb have higher priority than
>   the generated one. Because .../generator/ directory has lower priority
>   than the system admin directory /etc. See [2] for more details.
> 2) The generator could be disabled via kernel command line "systemd.getty_auto=".
>   See [1] for more details.

You left out the “why”, and after all of the drama around getty units last release I’m very cautious about changes here.

I think I prefer having an explicit “the getty generator is not installed” over the user having to configure kernel command line arguments to not disable the generator.

Ross
ChenQi July 22, 2025, 1:45 a.m. UTC | #2 
I just don't think anyone will ever disable this PACKAGECONFIG. Because disabling it does not have any benefit. So I sent out patch to clean things up.

But if you think disabling it has some benefit, let's keep it. I'm OK with it.

Regards,
Qi

-----Original Message-----
From: Ross Burton <Ross.Burton@arm.com> 
Sent: Monday, July 21, 2025 9:32 PM
To: Chen, Qi <Qi.Chen@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core][PATCH] systemd: remove 'serial-getty-generator' PACKAGECONFIG

Hi Chen,

On 16 Jul 2025, at 03:52, Chen Qi via lists.openembedded.org <Qi.Chen=windriver.com@lists.openembedded.org> wrote:
> This PACKAGECONFIG's net effect is to delete systemd-getty-generator 
> when not enabled. But deleting systemd-getty-generator really does not 
> have any benefit. Here are the reasons:
> 1) The units installed by systemd-serialgetty.bb have higher priority than
>   the generated one. Because .../generator/ directory has lower priority
>   than the system admin directory /etc. See [2] for more details.
> 2) The generator could be disabled via kernel command line "systemd.getty_auto=".
>   See [1] for more details.

You left out the “why”, and after all of the drama around getty units last release I’m very cautious about changes here.

I think I prefer having an explicit “the getty generator is not installed” over the user having to configure kernel command line arguments to not disable the generator.

Ross
diff mbox series

Patch

diff --git a/meta/recipes-core/systemd/systemd_257.6.bb b/meta/recipes-core/systemd/systemd_257.6.bb
index 9092d02c51..f1064f07c5 100644
--- a/meta/recipes-core/systemd/systemd_257.6.bb
+++ b/meta/recipes-core/systemd/systemd_257.6.bb
@@ -92,7 +92,6 @@  PACKAGECONFIG ??= " \
     quotacheck \
     randomseed \
     resolved \
-    serial-getty-generator \
     set-time-epoch \
     sysusers \
     timedated \
@@ -125,11 +124,6 @@  TARGET_CC_ARCH:append:libc-musl = " -D__UAPI_DEF_ETHHDR=0 -D_LARGEFILE64_SOURCE"
 # Some of the dependencies are weak-style recommends - if not available at runtime,
 # systemd won't fail but the library-related feature will be skipped with a warning.
 
-# Use the upstream systemd serial-getty@.service and rely on
-# systemd-getty-generator instead of using the OE-core specific
-# systemd-serialgetty.bb - not enabled by default.
-PACKAGECONFIG[serial-getty-generator] = ""
-
 PACKAGECONFIG[acl] = "-Dacl=enabled,-Dacl=disabled,acl"
 PACKAGECONFIG[audit] = "-Daudit=enabled,-Daudit=disabled,audit"
 PACKAGECONFIG[apparmor] = "-Dapparmor=enabled,-Dapparmor=disabled,apparmor"
@@ -290,12 +284,6 @@  do_install() {
 	fi
 	install -d ${D}/${base_sbindir}
 
-	if ! ${@bb.utils.contains('PACKAGECONFIG', 'serial-getty-generator', 'true', 'false', d)}; then
-		# Remove the serial-getty generator and instead use explicit services
-		# created by the systemd-serialgetty recipe
-		find ${D} -name \*getty-generator\* -delete
-	fi
-
 	# Provide support for initramfs
 	[ ! -e ${D}/init ] && ln -s ${nonarch_libdir}/systemd/systemd ${D}/init
 	[ ! -e ${D}/${base_sbindir}/udevd ] && ln -s ${nonarch_libdir}/systemd/systemd-udevd ${D}/${base_sbindir}/udevd