Message ID | 20250717085837.227414-1-Deepesh.Varatharajan@windriver.com |
---|---|
State | Under Review |
Delegated to: | Steve Sakoman |
Headers | show |
Series | [walnascar] glibc: stable 2.41 branch updates | expand |
LGTM On Thu, Jul 17, 2025 at 1:59 AM Varatharajan, Deepesh via lists.openembedded.org <deepesh.varatharajan=windriver.com@lists.openembedded.org> wrote: > > From: Deepesh Varatharajan <Deepesh.Varatharajan@windriver.com> > > $ git log --oneline 0c76c951620f9e12df2a89b2c684878b55bb6795..6e489c17f827317bcf8544efefa65f13b5a079dc > 6e489c17f8 Fix error reporting (false negatives) in SGID tests > 11e634ccf3 support: Pick group in support_capture_subprogram_self_sgid if UID == 0 > 61e461ed0c sparc: Fix sparc32 Fix argument passing to __libc_start_main (BZ 32981) > > Testing Results: > Before After Diff > pass 5807 5813 +6 > xpass 4 4 0 > UNSUPPORTED 164 161 -3 > FAIL 280 257 -23 > XFAIL 16 16 0 > > Signed-off-by: Deepesh Varatharajan <Deepesh.Varatharajan@windriver.com> > --- > meta/recipes-core/glibc/glibc-version.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-core/glibc/glibc-version.inc b/meta/recipes-core/glibc/glibc-version.inc > index 2d31131e03..a2cfd0f308 100644 > --- a/meta/recipes-core/glibc/glibc-version.inc > +++ b/meta/recipes-core/glibc/glibc-version.inc > @@ -1,6 +1,6 @@ > SRCBRANCH ?= "release/2.41/master" > PV = "2.41+git" > -SRCREV_glibc ?= "0c76c951620f9e12df2a89b2c684878b55bb6795" > +SRCREV_glibc ?= "6e489c17f827317bcf8544efefa65f13b5a079dc" > SRCREV_localedef ?= "fab74f31b3811df543e24b6de47efdf45b538abc" > > GLIBC_GIT_URI ?= "git://sourceware.org/git/glibc.git;protocol=https" > -- > 2.49.0 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#220522): https://lists.openembedded.org/g/openembedded-core/message/220522 > Mute This Topic: https://lists.openembedded.org/mt/114200019/1997914 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On 2025-07-17 12:40 p.m., Khem Raj via lists.openembedded.org wrote: > LGTM It does look good, almost too good... Deepesh, Please explain the why the UNSUPPORTED and FAIL results have changed so much for the better in this case. Looking briefly at the changes, I almost expect this sort of change but I'd like you to review, check the linked bug entries and provide a v2 that summarizes why the improvement happened. Also, did the number of tests change? The sum of the Diffs is not zero ... In the future, when the Diff is not zero you should try to summarize what happened so people can benefit from your knowledge and your easy access to the log files. CCing Ross so he knows that we expect a v2 with a revised commit log. ../Randy > > On Thu, Jul 17, 2025 at 1:59 AM Varatharajan, Deepesh via > lists.openembedded.org > <deepesh.varatharajan=windriver.com@lists.openembedded.org> wrote: >> From: Deepesh Varatharajan<Deepesh.Varatharajan@windriver.com> >> >> $ git log --oneline 0c76c951620f9e12df2a89b2c684878b55bb6795..6e489c17f827317bcf8544efefa65f13b5a079dc >> 6e489c17f8 Fix error reporting (false negatives) in SGID tests >> 11e634ccf3 support: Pick group in support_capture_subprogram_self_sgid if UID == 0 >> 61e461ed0c sparc: Fix sparc32 Fix argument passing to __libc_start_main (BZ 32981) >> >> Testing Results: >> Before After Diff >> pass 5807 5813 +6 >> xpass 4 4 0 >> UNSUPPORTED 164 161 -3 >> FAIL 280 257 -23 >> XFAIL 16 16 0 >> >> Signed-off-by: Deepesh Varatharajan<Deepesh.Varatharajan@windriver.com> >> --- >> meta/recipes-core/glibc/glibc-version.inc | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/meta/recipes-core/glibc/glibc-version.inc b/meta/recipes-core/glibc/glibc-version.inc >> index 2d31131e03..a2cfd0f308 100644 >> --- a/meta/recipes-core/glibc/glibc-version.inc >> +++ b/meta/recipes-core/glibc/glibc-version.inc >> @@ -1,6 +1,6 @@ >> SRCBRANCH ?= "release/2.41/master" >> PV = "2.41+git" >> -SRCREV_glibc ?= "0c76c951620f9e12df2a89b2c684878b55bb6795" >> +SRCREV_glibc ?= "6e489c17f827317bcf8544efefa65f13b5a079dc" >> SRCREV_localedef ?= "fab74f31b3811df543e24b6de47efdf45b538abc" >> >> GLIBC_GIT_URI ?= "git://sourceware.org/git/glibc.git;protocol=https" >> -- >> 2.49.0 >> >> >> >> >> >> -=-=-=-=-=-=-=-=-=-=-=- >> Links: You receive all messages sent to this group. >> View/Reply Online (#220549):https://lists.openembedded.org/g/openembedded-core/message/220549 >> Mute This Topic:https://lists.openembedded.org/mt/114200019/3616765 >> Group Owner:openembedded-core+owner@lists.openembedded.org >> Unsubscribe:https://lists.openembedded.org/g/openembedded-core/unsub [randy.macleod@windriver.com] >> -=-=-=-=-=-=-=-=-=-=-=- >>
On 18-07-2025 01:17, Randy MacLeod wrote: > On 2025-07-17 12:40 p.m., Khem Raj via lists.openembedded.org wrote: >> LGTM > > > It does look good, almost too good... > > Deepesh, > > Please explain the why the UNSUPPORTED and FAIL results have changed > so much for the better in this case. Looking briefly at the changes, I > almost expect this sort of change but I'd like you to review, check > the linked bug entries and provide a v2 that summarizes why the > improvement happened. Also, did the number of tests change? The sum of > the Diffs is not zero ... In the future, when the Diff is not zero you > should try to summarize what happened so people can benefit from your > knowledge and your easy access to the log files. > > CCing Ross so he knows that we expect a v2 with a revised commit log. > ../Randy > Sure Randy, will send a V2 with additional information. Regards, Deepesh >> On Thu, Jul 17, 2025 at 1:59 AM Varatharajan, Deepesh via >> lists.openembedded.org >> <deepesh.varatharajan=windriver.com@lists.openembedded.org> wrote: >>> From: Deepesh Varatharajan<Deepesh.Varatharajan@windriver.com> >>> >>> $ git log --oneline 0c76c951620f9e12df2a89b2c684878b55bb6795..6e489c17f827317bcf8544efefa65f13b5a079dc >>> 6e489c17f8 Fix error reporting (false negatives) in SGID tests >>> 11e634ccf3 support: Pick group in support_capture_subprogram_self_sgid if UID == 0 >>> 61e461ed0c sparc: Fix sparc32 Fix argument passing to __libc_start_main (BZ 32981) >>> >>> Testing Results: >>> Before After Diff >>> pass 5807 5813 +6 >>> xpass 4 4 0 >>> UNSUPPORTED 164 161 -3 >>> FAIL 280 257 -23 >>> XFAIL 16 16 0 >>> >>> Signed-off-by: Deepesh Varatharajan<Deepesh.Varatharajan@windriver.com> >>> --- >>> meta/recipes-core/glibc/glibc-version.inc | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/meta/recipes-core/glibc/glibc-version.inc b/meta/recipes-core/glibc/glibc-version.inc >>> index 2d31131e03..a2cfd0f308 100644 >>> --- a/meta/recipes-core/glibc/glibc-version.inc >>> +++ b/meta/recipes-core/glibc/glibc-version.inc >>> @@ -1,6 +1,6 @@ >>> SRCBRANCH ?= "release/2.41/master" >>> PV = "2.41+git" >>> -SRCREV_glibc ?= "0c76c951620f9e12df2a89b2c684878b55bb6795" >>> +SRCREV_glibc ?= "6e489c17f827317bcf8544efefa65f13b5a079dc" >>> SRCREV_localedef ?= "fab74f31b3811df543e24b6de47efdf45b538abc" >>> >>> GLIBC_GIT_URI ?= "git://sourceware.org/git/glibc.git;protocol=https" >>> -- >>> 2.49.0 >>> >>> >>> >>> >>> >>> -=-=-=-=-=-=-=-=-=-=-=- >>> Links: You receive all messages sent to this group. >>> View/Reply Online (#220549):https://lists.openembedded.org/g/openembedded-core/message/220549 >>> Mute This Topic:https://lists.openembedded.org/mt/114200019/3616765 >>> Group Owner:openembedded-core+owner@lists.openembedded.org >>> Unsubscribe:https://lists.openembedded.org/g/openembedded-core/unsub [randy.macleod@windriver.com] >>> -=-=-=-=-=-=-=-=-=-=-=- >>> > > -- > # Randy MacLeod > # Wind River Linux
diff --git a/meta/recipes-core/glibc/glibc-version.inc b/meta/recipes-core/glibc/glibc-version.inc index 2d31131e03..a2cfd0f308 100644 --- a/meta/recipes-core/glibc/glibc-version.inc +++ b/meta/recipes-core/glibc/glibc-version.inc @@ -1,6 +1,6 @@ SRCBRANCH ?= "release/2.41/master" PV = "2.41+git" -SRCREV_glibc ?= "0c76c951620f9e12df2a89b2c684878b55bb6795" +SRCREV_glibc ?= "6e489c17f827317bcf8544efefa65f13b5a079dc" SRCREV_localedef ?= "fab74f31b3811df543e24b6de47efdf45b538abc" GLIBC_GIT_URI ?= "git://sourceware.org/git/glibc.git;protocol=https"