Message ID | 20250716123047.1322878-1-ross.burton@arm.com |
---|---|
State | Accepted, archived |
Commit | 134880baa4a971660e0800f70404d15c758fb7db |
Headers | show |
Series | clang: remove obsolete 'terminfo' PACKAGECONFIG | expand |
On Wed, Jul 16, 2025 at 5:30 AM Ross Burton via lists.openembedded.org <ross.burton=arm.com@lists.openembedded.org> wrote: > > Neither LLVM_ENABLE_TERMINFO or COMPILER_RT_TERMINFO_LIB are used in the > current CMakeLists. It has transformed overtime, so removal is perhaps fine. although this has transformed into lldb cmake detecting it for the build so it might be doing the job due to ncurses being in deps which now it gone. TUI with lldb might be disabled > > Signed-off-by: Ross Burton <ross.burton@arm.com> > --- > meta/recipes-devtools/clang/clang_git.bb | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/meta/recipes-devtools/clang/clang_git.bb b/meta/recipes-devtools/clang/clang_git.bb > index 194e690a8c4..d70f2c0133b 100644 > --- a/meta/recipes-devtools/clang/clang_git.bb > +++ b/meta/recipes-devtools/clang/clang_git.bb > @@ -57,8 +57,7 @@ PACKAGECONFIG_CLANG_COMMON = "build-id eh libedit rtti shared-libs libclang-pyth > ${@bb.utils.contains('TC_CXX_RUNTIME', 'llvm', 'compiler-rt libcplusplus libomp unwindlib', '', d)} \ > " > > -PACKAGECONFIG ??= "terminfo \ > - ${PACKAGECONFIG_CLANG_COMMON} \ > +PACKAGECONFIG ??= "${PACKAGECONFIG_CLANG_COMMON} \ > ${@bb.utils.filter('DISTRO_FEATURES', 'lto thin-lto', d)} \ > " > PACKAGECONFIG:class-native = "clangd \ > @@ -89,7 +88,6 @@ PACKAGECONFIG[pfm] = "-DLLVM_ENABLE_LIBPFM=ON,-DLLVM_ENABLE_LIBPFM=OFF,libpfm," > PACKAGECONFIG[rtti] = "-DLLVM_ENABLE_RTTI=ON,-DLLVM_ENABLE_RTTI=OFF,," > PACKAGECONFIG[shared-libs] = "-DLLVM_BUILD_LLVM_DYLIB=ON -DLLVM_LINK_LLVM_DYLIB=ON,,," > PACKAGECONFIG[split-dwarf] = "-DLLVM_USE_SPLIT_DWARF=ON,-DLLVM_USE_SPLIT_DWARF=OFF,," > -PACKAGECONFIG[terminfo] = "-DLLVM_ENABLE_TERMINFO=ON -DCOMPILER_RT_TERMINFO_LIB=ON,-DLLVM_ENABLE_TERMINFO=OFF -DCOMPILER_RT_TERMINFO_LIB=OFF,ncurses," > PACKAGECONFIG[thin-lto] = "-DLLVM_ENABLE_LTO=Thin -DLLVM_BINUTILS_INCDIR=${STAGING_INCDIR},,binutils," > PACKAGECONFIG[unwindlib] = "-DCLANG_DEFAULT_UNWINDLIB=libunwind,-DCLANG_DEFAULT_UNWINDLIB=libgcc,," > PACKAGECONFIG[libclang-python] = "-DCLANG_PYTHON_BINDINGS_VERSIONS=${PYTHON_BASEVERSION},," > -- > 2.43.0 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#220449): https://lists.openembedded.org/g/openembedded-core/message/220449 > Mute This Topic: https://lists.openembedded.org/mt/114183620/1997914 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On 17 Jul 2025, at 02:32, Khem Raj <raj.khem@gmail.com> wrote: > > On Wed, Jul 16, 2025 at 5:30 AM Ross Burton via lists.openembedded.org > <ross.burton=arm.com@lists.openembedded.org> wrote: >> >> Neither LLVM_ENABLE_TERMINFO or COMPILER_RT_TERMINFO_LIB are used in the >> current CMakeLists. > > It has transformed overtime, so removal is perhaps fine. although this > has transformed into lldb cmake detecting it for the build > so it might be doing the job due to ncurses being in deps which now it > gone. TUI with lldb might be disabled I don’t believe this is an issue, as you say lldb depends on libedit which depends on ncurses, so the dependency is still there. Ross
On Thu, Jul 17, 2025 at 5:13 AM Ross Burton <Ross.Burton@arm.com> wrote: > > On 17 Jul 2025, at 02:32, Khem Raj <raj.khem@gmail.com> wrote: > > > > On Wed, Jul 16, 2025 at 5:30 AM Ross Burton via lists.openembedded.org > > <ross.burton=arm.com@lists.openembedded.org> wrote: > >> > >> Neither LLVM_ENABLE_TERMINFO or COMPILER_RT_TERMINFO_LIB are used in the > >> current CMakeLists. > > > > It has transformed overtime, so removal is perhaps fine. although this > > has transformed into lldb cmake detecting it for the build > > so it might be doing the job due to ncurses being in deps which now it > > gone. TUI with lldb might be disabled > > I don’t believe this is an issue, as you say lldb depends on libedit which depends on ncurses, so the dependency is still there. > OK, that is good then > Ross
diff --git a/meta/recipes-devtools/clang/clang_git.bb b/meta/recipes-devtools/clang/clang_git.bb index 194e690a8c4..d70f2c0133b 100644 --- a/meta/recipes-devtools/clang/clang_git.bb +++ b/meta/recipes-devtools/clang/clang_git.bb @@ -57,8 +57,7 @@ PACKAGECONFIG_CLANG_COMMON = "build-id eh libedit rtti shared-libs libclang-pyth ${@bb.utils.contains('TC_CXX_RUNTIME', 'llvm', 'compiler-rt libcplusplus libomp unwindlib', '', d)} \ " -PACKAGECONFIG ??= "terminfo \ - ${PACKAGECONFIG_CLANG_COMMON} \ +PACKAGECONFIG ??= "${PACKAGECONFIG_CLANG_COMMON} \ ${@bb.utils.filter('DISTRO_FEATURES', 'lto thin-lto', d)} \ " PACKAGECONFIG:class-native = "clangd \ @@ -89,7 +88,6 @@ PACKAGECONFIG[pfm] = "-DLLVM_ENABLE_LIBPFM=ON,-DLLVM_ENABLE_LIBPFM=OFF,libpfm," PACKAGECONFIG[rtti] = "-DLLVM_ENABLE_RTTI=ON,-DLLVM_ENABLE_RTTI=OFF,," PACKAGECONFIG[shared-libs] = "-DLLVM_BUILD_LLVM_DYLIB=ON -DLLVM_LINK_LLVM_DYLIB=ON,,," PACKAGECONFIG[split-dwarf] = "-DLLVM_USE_SPLIT_DWARF=ON,-DLLVM_USE_SPLIT_DWARF=OFF,," -PACKAGECONFIG[terminfo] = "-DLLVM_ENABLE_TERMINFO=ON -DCOMPILER_RT_TERMINFO_LIB=ON,-DLLVM_ENABLE_TERMINFO=OFF -DCOMPILER_RT_TERMINFO_LIB=OFF,ncurses," PACKAGECONFIG[thin-lto] = "-DLLVM_ENABLE_LTO=Thin -DLLVM_BINUTILS_INCDIR=${STAGING_INCDIR},,binutils," PACKAGECONFIG[unwindlib] = "-DCLANG_DEFAULT_UNWINDLIB=libunwind,-DCLANG_DEFAULT_UNWINDLIB=libgcc,," PACKAGECONFIG[libclang-python] = "-DCLANG_PYTHON_BINDINGS_VERSIONS=${PYTHON_BASEVERSION},,"
Neither LLVM_ENABLE_TERMINFO or COMPILER_RT_TERMINFO_LIB are used in the current CMakeLists. Signed-off-by: Ross Burton <ross.burton@arm.com> --- meta/recipes-devtools/clang/clang_git.bb | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)