[meta-openembedded,2/3] libmusicbrainz: Add patch for CMake 4+ compatibility

Fix:

| CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
|   Compatibility with CMake < 3.5 has been removed from CMake.
|
|   Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
|   to tell CMake that the project requires at least <min> but has been updated
|   to work with policies introduced by <max> or earlier.
|
|   Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.
|
|
| -- Configuring incomplete, errors occurred!

Signed-off-by: Alper Ak <alperyasinak1@gmail.com>
---
 .../0002-allow-build-with-cmake-4.patch       | 40 +++++++++++++++++++
 .../musicbrainz/libmusicbrainz_git.bb         |  1 +
 2 files changed, 41 insertions(+)
 create mode 100644 meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz/0002-allow-build-with-cmake-4.patch

This does fix the compatibility issue but it causes another build regression

| DEBUG: Executing shell function do_compile
| NOTE: cmake --build
/mnt/b/yoe/master/build/tmp/work/cortexa72-yoe-linux/libmusicbrainz/5.1.0+git/build
--target all --
| ninja: error: 'make-c-interface', needed by
'/mnt/b/yoe/master/build/tmp/work/cortexa72-yoe-linux/libmusicbrainz/5.1.0+git/build/src/mb5_c.cc',
missing and no known rule to make it

On Fri, Jul 11, 2025 at 10:44 AM Alper Ak via lists.openembedded.org
<alperyasinak1=gmail.com@lists.openembedded.org> wrote:
>
> Fix:
>
> | CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
> |   Compatibility with CMake < 3.5 has been removed from CMake.
> |
> |   Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
> |   to tell CMake that the project requires at least <min> but has been updated
> |   to work with policies introduced by <max> or earlier.
> |
> |   Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.
> |
> |
> | -- Configuring incomplete, errors occurred!
>
> Signed-off-by: Alper Ak <alperyasinak1@gmail.com>
> ---
>  .../0002-allow-build-with-cmake-4.patch       | 40 +++++++++++++++++++
>  .../musicbrainz/libmusicbrainz_git.bb         |  1 +
>  2 files changed, 41 insertions(+)
>  create mode 100644 meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz/0002-allow-build-with-cmake-4.patch
>
> diff --git a/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz/0002-allow-build-with-cmake-4.patch b/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz/0002-allow-build-with-cmake-4.patch
> new file mode 100644
> index 0000000000..2aad2b617f
> --- /dev/null
> +++ b/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz/0002-allow-build-with-cmake-4.patch
> @@ -0,0 +1,40 @@
> +From f5504099fd6f93ebfa351a034d29beb86db3408c Mon Sep 17 00:00:00 2001
> +From: Alper Ak <alperyasinak1@gmail.com>
> +Date: Fri, 11 Jul 2025 16:43:29 +0300
> +Subject: [PATCH] cmake: Set minimum required version to 3.5 for CMake 4+
> + compatibility
> +
> +Fix:
> +
> +| CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
> +|   Compatibility with CMake < 3.5 has been removed from CMake.
> +|
> +|   Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
> +|   to tell CMake that the project requires at least <min> but has been updated
> +|   to work with policies introduced by <max> or earlier.
> +|
> +|   Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.
> +|
> +|
> +| -- Configuring incomplete, errors occurred!
> +
> +Upstream-Status: Submitted [https://github.com/metabrainz/libmusicbrainz/pull/21]
> +
> +Signed-off-by: Alper Ak <alperyasinak1@gmail.com>
> +---
> + CMakeLists.txt | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/CMakeLists.txt b/CMakeLists.txt
> +index 6181a06..f3672a3 100644
> +--- a/CMakeLists.txt
> ++++ b/CMakeLists.txt
> +@@ -1,4 +1,4 @@
> +-cmake_minimum_required(VERSION 2.6)
> ++cmake_minimum_required(VERSION 3.5)
> +
> + PROJECT(libmusicbrainz5)
> + SET(PROJECT_VERSION 5.1.0)
> +--
> +2.43.0
> +
> diff --git a/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb b/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb
> index 1ae43e8aef..9200d0ea72 100644
> --- a/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb
> +++ b/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb
> @@ -10,6 +10,7 @@ PV = "5.1.0+git"
>  SRCREV = "4655b571a70d73d41467091f59c518517c956198"
>  SRC_URI = "git://github.com/metabrainz/libmusicbrainz.git;branch=master;protocol=https \
>             file://0001-http-fetch-Pass-a-non-null-buffer-to-ne_set_request_.patch \
> +           file://0002-allow-build-with-cmake-4.patch \
>             "
>
>
> --
> 2.43.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#118457): https://lists.openembedded.org/g/openembedded-devel/message/118457
> Mute This Topic: https://lists.openembedded.org/mt/114104562/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>