| Message ID | 20250708105155.478279-1-martin.jansa@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [meta-oe,1/2] gpicview: enable gtk3 PACKAGECONFIG only when gtk+3 is available | expand |
Hi Martin, On Tue, Jul 08, 2025 at 12:51:53PM +0200, Martin Jansa via lists.openembedded.org wrote: > From: Martin Jansa <martin.jansa@gmail.com> > > Signed-off-by: Martin Jansa <martin.jansa@gmail.com> > --- > meta-oe/recipes-graphics/gpicview/gpicview_0.3.1.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta-oe/recipes-graphics/gpicview/gpicview_0.3.1.bb b/meta-oe/recipes-graphics/gpicview/gpicview_0.3.1.bb > index dab11a02bc..ace909fcf1 100644 > --- a/meta-oe/recipes-graphics/gpicview/gpicview_0.3.1.bb > +++ b/meta-oe/recipes-graphics/gpicview/gpicview_0.3.1.bb > @@ -15,7 +15,7 @@ SRCREV = "ca13623c6176585db4759ce4371fbf89c56fa630" > > inherit autotools mime-xdg pkgconfig > > -PACKAGECONFIG ?= "gtk3" > +PACKAGECONFIG ?= "${@bb.utils.contains_any('DISTRO_FEATURES', '${GTK3DISTROFEATURES}', 'gtk3', '', d)}" Thanks for the patch. In this case, shouldn't we add gtk+ if gtk3 is not set? If PACKAGECONFIG is empty, then the compilation will fail: | configure: WARNING: using cross tools not prefixed with host triplet | checking pkg-config is at least version 0.9.0... yes | checking for gtk+-2.0 >= 2.12.0... no | configure: error: Package requirements (gtk+-2.0 >= 2.12.0) were not met: | | No package 'gtk+-2.0' found Or maybe add gtk+ as dependency and keep the gtk+3 only on the PACKAGECONFIG? Best Regards, Hiago. > PACKAGECONFIG[gtk2] = ",,gtk+" > PACKAGECONFIG[gtk3] = "--enable-gtk3,,gtk+3" > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#118307): https://lists.openembedded.org/g/openembedded-devel/message/118307 > Mute This Topic: https://lists.openembedded.org/mt/114043964/9076898 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [hiagofranco@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On Tue, Jul 8, 2025 at 10:21 AM Hiago De Franco via lists.openembedded.org <hiagofranco=gmail.com@lists.openembedded.org> wrote: > > Hi Martin, > > On Tue, Jul 08, 2025 at 12:51:53PM +0200, Martin Jansa via lists.openembedded.org wrote: > > From: Martin Jansa <martin.jansa@gmail.com> > > > > Signed-off-by: Martin Jansa <martin.jansa@gmail.com> > > --- > > meta-oe/recipes-graphics/gpicview/gpicview_0.3.1.bb | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meta-oe/recipes-graphics/gpicview/gpicview_0.3.1.bb b/meta-oe/recipes-graphics/gpicview/gpicview_0.3.1.bb > > index dab11a02bc..ace909fcf1 100644 > > --- a/meta-oe/recipes-graphics/gpicview/gpicview_0.3.1.bb > > +++ b/meta-oe/recipes-graphics/gpicview/gpicview_0.3.1.bb > > @@ -15,7 +15,7 @@ SRCREV = "ca13623c6176585db4759ce4371fbf89c56fa630" > > > > inherit autotools mime-xdg pkgconfig > > > > -PACKAGECONFIG ?= "gtk3" > > +PACKAGECONFIG ?= "${@bb.utils.contains_any('DISTRO_FEATURES', '${GTK3DISTROFEATURES}', 'gtk3', '', d)}" > > Thanks for the patch. In this case, shouldn't we add gtk+ if gtk3 is not > set? If PACKAGECONFIG is empty, then the compilation will fail: > seems that way. > | configure: WARNING: using cross tools not prefixed with host triplet > | checking pkg-config is at least version 0.9.0... yes > | checking for gtk+-2.0 >= 2.12.0... no > | configure: error: Package requirements (gtk+-2.0 >= 2.12.0) were not met: > | > | No package 'gtk+-2.0' found > > Or maybe add gtk+ as dependency and keep the gtk+3 only on the > PACKAGECONFIG? > > Best Regards, > Hiago. > > > PACKAGECONFIG[gtk2] = ",,gtk+" > > PACKAGECONFIG[gtk3] = "--enable-gtk3,,gtk+3" > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#118321): https://lists.openembedded.org/g/openembedded-devel/message/118321 > Mute This Topic: https://lists.openembedded.org/mt/114043964/1997914 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
diff --git a/meta-oe/recipes-graphics/gpicview/gpicview_0.3.1.bb b/meta-oe/recipes-graphics/gpicview/gpicview_0.3.1.bb index dab11a02bc..ace909fcf1 100644 --- a/meta-oe/recipes-graphics/gpicview/gpicview_0.3.1.bb +++ b/meta-oe/recipes-graphics/gpicview/gpicview_0.3.1.bb @@ -15,7 +15,7 @@ SRCREV = "ca13623c6176585db4759ce4371fbf89c56fa630" inherit autotools mime-xdg pkgconfig -PACKAGECONFIG ?= "gtk3" +PACKAGECONFIG ?= "${@bb.utils.contains_any('DISTRO_FEATURES', '${GTK3DISTROFEATURES}', 'gtk3', '', d)}" PACKAGECONFIG[gtk2] = ",,gtk+" PACKAGECONFIG[gtk3] = "--enable-gtk3,,gtk+3"