| Message ID | 20250626131413.3666480-1-Moritz.Haase@bmw.de |
|---|---|
| State | New |
| Headers | show |
| Series | json-c: Re-enable '-Werror' now that icecc is not supported anymore | expand |
Hi Moritz, On 6/26/25 3:14 PM, Moritz Haase via lists.openembedded.org wrote: > 6481e8b209b ("json-c: fix icecc compilation") disabled '-Werror' unconditionally > for all compilers. As support for icecc has been removed via ba4fd5229893 > ("classes/recipes-devtools: Drop icecc from OE-Core") recently, we can re-enable > it. > Looks nice, thanks. Minor comment below. > Signed-off-by: Moritz Haase <Moritz.Haase@bmw.de> > CC: quentin.schulz@cherry.de > CC: m.felsch@pengutronix.de > --- > meta/recipes-devtools/json-c/json-c_0.18.bb | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/meta/recipes-devtools/json-c/json-c_0.18.bb b/meta/recipes-devtools/json-c/json-c_0.18.bb > index ece320d66ce1f03ce0c8655374c02c283a9364dd..5edeced4c55df088e1a9990d9e159fe970bb537b 100644 > --- a/meta/recipes-devtools/json-c/json-c_0.18.bb > +++ b/meta/recipes-devtools/json-c/json-c_0.18.bb > @@ -19,10 +19,8 @@ UPSTREAM_CHECK_REGEX = "json-c-(?P<pver>\d+(\.\d+)+)-\d+" > > RPROVIDES:${PN} = "libjson" > > -# - '-Werror' must be disabled for ICECC builds > -# - Apps aren't needed/packaged and their CMakeLists.txt is incompatible with CMake 4+. > -EXTRA_OECMAKE = "-DDISABLE_WERROR=ON \ > - -DBUILD_APPS=OFF \ > +# Apps aren't needed/packaged and their CMakeLists.txt is incompatible with CMake 4+. > +EXTRA_OECMAKE = "-DBUILD_APPS=OFF \ > " We could have the closing quote character on the same line. Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de> Thanks! Quentin
On 25-06-26, Moritz Haase wrote: > 6481e8b209b ("json-c: fix icecc compilation") disabled '-Werror' unconditionally > for all compilers. As support for icecc has been removed via ba4fd5229893 > ("classes/recipes-devtools: Drop icecc from OE-Core") recently, we can re-enable > it. Fine by me. > Signed-off-by: Moritz Haase <Moritz.Haase@bmw.de> Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
On 26 Jun 2025, at 14:14, Moritz Haase via lists.openembedded.org <Moritz.Haase=bmw.de@lists.openembedded.org> wrote: > -# - '-Werror' must be disabled for ICECC builds > -# - Apps aren't needed/packaged and their CMakeLists.txt is incompatible with CMake 4+. > -EXTRA_OECMAKE = "-DDISABLE_WERROR=ON \ > - -DBUILD_APPS=OFF \ -Werror is horrible and we should be turning it off if upstream defaults to enabling it, so I’d say remove the comment but keep the disabling. It makes switching C library or compilers very time-consuming when random libraries gain a new warning and the build fails. Ross
diff --git a/meta/recipes-devtools/json-c/json-c_0.18.bb b/meta/recipes-devtools/json-c/json-c_0.18.bb index ece320d66ce1f03ce0c8655374c02c283a9364dd..5edeced4c55df088e1a9990d9e159fe970bb537b 100644 --- a/meta/recipes-devtools/json-c/json-c_0.18.bb +++ b/meta/recipes-devtools/json-c/json-c_0.18.bb @@ -19,10 +19,8 @@ UPSTREAM_CHECK_REGEX = "json-c-(?P<pver>\d+(\.\d+)+)-\d+" RPROVIDES:${PN} = "libjson" -# - '-Werror' must be disabled for ICECC builds -# - Apps aren't needed/packaged and their CMakeLists.txt is incompatible with CMake 4+. -EXTRA_OECMAKE = "-DDISABLE_WERROR=ON \ - -DBUILD_APPS=OFF \ +# Apps aren't needed/packaged and their CMakeLists.txt is incompatible with CMake 4+. +EXTRA_OECMAKE = "-DBUILD_APPS=OFF \ " inherit cmake ptest
6481e8b209b ("json-c: fix icecc compilation") disabled '-Werror' unconditionally for all compilers. As support for icecc has been removed via ba4fd5229893 ("classes/recipes-devtools: Drop icecc from OE-Core") recently, we can re-enable it. Signed-off-by: Moritz Haase <Moritz.Haase@bmw.de> CC: quentin.schulz@cherry.de CC: m.felsch@pengutronix.de --- meta/recipes-devtools/json-c/json-c_0.18.bb | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)