| Message ID | 20250624135017.539280-1-alex@linutronix.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | meta-yocto: remove erroneous poky-bleeding selftest in meta/ | expand |
On Tue, 2025-06-24 at 15:50 +0200, Alexander Kanavin via lists.yoctoproject.org wrote: > This was added to meta-yocto repository by mistake, > and should be in oe-core (which is done in a separate patch). > > Signed-off-by: Alexander Kanavin <alex@linutronix.de> > --- > meta/lib/oeqa/selftest/cases/pokybleeding.py | 32 -------------------- > 1 file changed, 32 deletions(-) > delete mode 100644 meta/lib/oeqa/selftest/cases/pokybleeding.py > > diff --git a/meta/lib/oeqa/selftest/cases/pokybleeding.py b/meta/lib/oeqa/selftest/cases/pokybleeding.py > deleted file mode 100644 > index d0940d6..0000000 > --- a/meta/lib/oeqa/selftest/cases/pokybleeding.py > +++ /dev/null > @@ -1,32 +0,0 @@ > -# > -# Copyright OpenEmbedded Contributors > -# > -# SPDX-License-Identifier: MIT > -# > - > -from oeqa.utils.commands import bitbake, get_bb_var > -from oeqa.selftest.case import OESelftestTestCase > - > -class PokyBleeding(OESelftestTestCase): > - > - def test_poky_bleeding_autorev(self): > - """ > - Test that poky-bleeding.bbclass sets SRCREV to "AUTOINC" for recipe > - with a single scm in SRC_URI and for recipe with two scm's in SRC_URI. > - """ > - > - self.assertNotEqual( get_bb_var('SRCREV', 'pseudo'), "AUTOINC") > - > - self.assertNotEqual( get_bb_var('SRCREV', 'hello-rs'), "AUTOINC") > - self.assertNotEqual( get_bb_var('SRCREV_hello-lib', 'hello-rs'), "AUTOINC") > - > - features = ''' > -INHERIT += "poky-bleeding" > -POKY_AUTOREV_RECIPES = "hello-rs pseudo" > -''' > - self.write_config(features) > - > - self.assertEqual( get_bb_var('SRCREV', 'pseudo'), "AUTOINC") > - > - self.assertEqual( get_bb_var('SRCREV', 'hello-rs'), "AUTOINC") > - self.assertEqual( get_bb_var('SRCREV_hello-lib', 'hello-rs'), "AUTOINC") > Since this can't work without poky, I'd argue it is in the right place? Cheers, Richard
On Tue, 24 Jun 2025 at 15:55, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> Since this can't work without poky, I'd argue it is in the right place?
There are a few other selftests in oe-core that have a hard dependency
on poky (e.g. multiconfig, fitimage). I don't mind keeping this test
in meta-yocto repo, but it should really be moved out of meta/
directory as it's super confusing:
https://git.yoctoproject.org/meta-yocto/tree/
Alex
On Tue, 2025-06-24 at 16:01 +0200, Alexander Kanavin wrote: > On Tue, 24 Jun 2025 at 15:55, Richard Purdie > <richard.purdie@linuxfoundation.org> wrote: > > > Since this can't work without poky, I'd argue it is in the right > > place? > > There are a few other selftests in oe-core that have a hard > dependency on poky (e.g. multiconfig, fitimage). We should probably fix that as it wasn't intended. > I don't mind keeping this test in meta-yocto repo, but it should > really be moved out of meta/ directory as it's super confusing: > > https://git.yoctoproject.org/meta-yocto/tree/ Agreed, it should belong alongside the distro. Cheers, Richard
On Tue, 2025-06-24 at 15:25 +0100, Richard Purdie via lists.yoctoproject.org wrote: > On Tue, 2025-06-24 at 16:01 +0200, Alexander Kanavin wrote: > > On Tue, 24 Jun 2025 at 15:55, Richard Purdie > > <richard.purdie@linuxfoundation.org> wrote: > > > > > Since this can't work without poky, I'd argue it is in the right > > > place? > > > > There are a few other selftests in oe-core that have a hard > > dependency on poky (e.g. multiconfig, fitimage). > > We should probably fix that as it wasn't intended. The FIT image tests compile the linux-yocto, linux-yocto-fitimage, and u-boot recipes. I tried running oe-selftest -r fitimage without setting DISTRO = "poky" and with MACHINE = "qemuarm" instead of "beaglebone- yocto". The MACHINE setting is a bit more complicated because of the device trees, but that should also be possible. Ideally, most of the fitimage tests should be in OE-core with qemuarm, and perhaps some tests for beaglebone-yocto could be moved to meta- yocto as well. It's not my highest priority task, but I will try to find some time to clean this up. Adrian > > > I don't mind keeping this test in meta-yocto repo, but it should > > really be moved out of meta/ directory as it's super confusing: > > > > https://git.yoctoproject.org/meta-yocto/tree/ > > Agreed, it should belong alongside the distro. > > Cheers, > > Richard > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#13673): > https://lists.yoctoproject.org/g/poky/message/13673 > Mute This Topic: https://lists.yoctoproject.org/mt/113807263/3616858 > Group Owner: poky+owner@lists.yoctoproject.org > Unsubscribe: > https://lists.yoctoproject.org/g/poky/unsub [adrian.freihofer@siemens.com > ] > -=-=-=-=-=-=-=-=-=-=-=- >
diff --git a/meta/lib/oeqa/selftest/cases/pokybleeding.py b/meta/lib/oeqa/selftest/cases/pokybleeding.py deleted file mode 100644 index d0940d6..0000000 --- a/meta/lib/oeqa/selftest/cases/pokybleeding.py +++ /dev/null @@ -1,32 +0,0 @@ -# -# Copyright OpenEmbedded Contributors -# -# SPDX-License-Identifier: MIT -# - -from oeqa.utils.commands import bitbake, get_bb_var -from oeqa.selftest.case import OESelftestTestCase - -class PokyBleeding(OESelftestTestCase): - - def test_poky_bleeding_autorev(self): - """ - Test that poky-bleeding.bbclass sets SRCREV to "AUTOINC" for recipe - with a single scm in SRC_URI and for recipe with two scm's in SRC_URI. - """ - - self.assertNotEqual( get_bb_var('SRCREV', 'pseudo'), "AUTOINC") - - self.assertNotEqual( get_bb_var('SRCREV', 'hello-rs'), "AUTOINC") - self.assertNotEqual( get_bb_var('SRCREV_hello-lib', 'hello-rs'), "AUTOINC") - - features = ''' -INHERIT += "poky-bleeding" -POKY_AUTOREV_RECIPES = "hello-rs pseudo" -''' - self.write_config(features) - - self.assertEqual( get_bb_var('SRCREV', 'pseudo'), "AUTOINC") - - self.assertEqual( get_bb_var('SRCREV', 'hello-rs'), "AUTOINC") - self.assertEqual( get_bb_var('SRCREV_hello-lib', 'hello-rs'), "AUTOINC")
This was added to meta-yocto repository by mistake, and should be in oe-core (which is done in a separate patch). Signed-off-by: Alexander Kanavin <alex@linutronix.de> --- meta/lib/oeqa/selftest/cases/pokybleeding.py | 32 -------------------- 1 file changed, 32 deletions(-) delete mode 100644 meta/lib/oeqa/selftest/cases/pokybleeding.py