diff mbox series

[2/2] libubootenv: do not drop debug symbols

Message ID 20250623073553.844037-3-adrian.freihofer@siemens.com
State New
Headers show
Series libubootenv improvements | expand

Commit Message

AdrianF June 23, 2025, 7:35 a.m. UTC
From: Adrian Freihofer <adrian.freihofer@siemens.com>

Usually the debug symbols are split into a libubootenv-dbg package.
Dropping them already at compile time is not needed and causes problems
when debugging libubootenv.

Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com>
---
 meta/recipes-bsp/u-boot/libubootenv_0.3.6.bb | 2 --
 1 file changed, 2 deletions(-)

Comments

Stefano Babic June 23, 2025, 8:15 a.m. UTC | #1
Hi Adrian,

On 6/23/25 09:35, AdrianF wrote:
> From: Adrian Freihofer <adrian.freihofer@siemens.com>
> 
> Usually the debug symbols are split into a libubootenv-dbg package.
> Dropping them already at compile time is not needed and causes problems
> when debugging libubootenv.
> 
> Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com>
> ---
>   meta/recipes-bsp/u-boot/libubootenv_0.3.6.bb | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/meta/recipes-bsp/u-boot/libubootenv_0.3.6.bb b/meta/recipes-bsp/u-boot/libubootenv_0.3.6.bb
> index a193872b83b..4da9c44c921 100644
> --- a/meta/recipes-bsp/u-boot/libubootenv_0.3.6.bb
> +++ b/meta/recipes-bsp/u-boot/libubootenv_0.3.6.bb
> @@ -15,8 +15,6 @@ SRCREV = "5507339628b5caf244e1ff9d58cb3fa534b16beb"
>   
>   inherit cmake lib_package
>   
> -EXTRA_OECMAKE = "-DCMAKE_BUILD_TYPE=Release"
> -
>   DEPENDS = "zlib libyaml"
>   PROVIDES += "u-boot-fw-utils"
>   RPROVIDES:${PN}-bin += "u-boot-fw-utils"

I fear this is not enough because it has a side effect. MAKE_BUILD_TYPE 
is set here not to drop the debug files, but to avoid debug output. 
Cmake sets automatically NDEBUG if CMAKE_BUILD_TYPE=Release, and this is 
the goal of the EXTRA_OECMAKE because NDEBUG is used in code. The change 
here will break user's scripts.

Regards,
Stefano
diff mbox series

Patch

diff --git a/meta/recipes-bsp/u-boot/libubootenv_0.3.6.bb b/meta/recipes-bsp/u-boot/libubootenv_0.3.6.bb
index a193872b83b..4da9c44c921 100644
--- a/meta/recipes-bsp/u-boot/libubootenv_0.3.6.bb
+++ b/meta/recipes-bsp/u-boot/libubootenv_0.3.6.bb
@@ -15,8 +15,6 @@  SRCREV = "5507339628b5caf244e1ff9d58cb3fa534b16beb"
 
 inherit cmake lib_package
 
-EXTRA_OECMAKE = "-DCMAKE_BUILD_TYPE=Release"
-
 DEPENDS = "zlib libyaml"
 PROVIDES += "u-boot-fw-utils"
 RPROVIDES:${PN}-bin += "u-boot-fw-utils"