Message ID | 20250615191535.1261591-1-adrian.freihofer@siemens.com |
---|---|
State | Accepted, archived |
Commit | 2c83ae62584f73a09a6201541cac27910513e554 |
Headers | show |
Series | packagegroup-base: fix override syntax | expand |
Hi Adrian, On 6/15/25 9:15 PM, Adrian Freihofer via lists.openembedded.org wrote: > From: Adrian Freihofer <adrian.freihofer@siemens.com> > > Looks like one more left over from the override syntax change. > > Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com> > --- > meta/recipes-core/packagegroups/packagegroup-base.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-core/packagegroups/packagegroup-base.bb b/meta/recipes-core/packagegroups/packagegroup-base.bb > index cb9d1f07af5..2e051dba33d 100644 > --- a/meta/recipes-core/packagegroups/packagegroup-base.bb > +++ b/meta/recipes-core/packagegroups/packagegroup-base.bb > @@ -119,7 +119,7 @@ python __anonymous () { > # packages added by distribution > # > SUMMARY:packagegroup-distro-base = "${DISTRO} extras" > -DEPENDS_packagegroup-distro-base = "${DISTRO_EXTRA_DEPENDS}" > +DEPENDS:packagegroup-distro-base = "${DISTRO_EXTRA_DEPENDS}" I'm not sure this is actually doing anything? Nothing sets DISTRO_EXTRA_DEPENDS in poky, it's also not documented. This line was added 18 years ago during a git sync with svn (3e5ee5acdca51af57c7b6ccd2136f7b548a80293) so history is lost sadly. DEPENDS:recipe-name isnt' even a valid override as far as i know (it should be pn-recipe-name) and even if it was, what would be the point, we already are in the recipe so there's no need for an override. The RDEPENDS overrides make sense because it applies for the package and not recipe (and most recipes have the main package named after the recipe). So I think we should simply remove this line? Cheers, Quentin
On Wed, 2025-06-18 at 11:07 +0200, Quentin Schulz via lists.openembedded.org wrote: > Hi Adrian, > > On 6/15/25 9:15 PM, Adrian Freihofer via lists.openembedded.org wrote: > > From: Adrian Freihofer <adrian.freihofer@siemens.com> > > > > Looks like one more left over from the override syntax change. > > > > Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com> > > --- > > meta/recipes-core/packagegroups/packagegroup-base.bb | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meta/recipes-core/packagegroups/packagegroup-base.bb b/meta/recipes-core/packagegroups/packagegroup-base.bb > > index cb9d1f07af5..2e051dba33d 100644 > > --- a/meta/recipes-core/packagegroups/packagegroup-base.bb > > +++ b/meta/recipes-core/packagegroups/packagegroup-base.bb > > @@ -119,7 +119,7 @@ python __anonymous () { > > # packages added by distribution > > # > > SUMMARY:packagegroup-distro-base = "${DISTRO} extras" > > -DEPENDS_packagegroup-distro-base = "${DISTRO_EXTRA_DEPENDS}" > > +DEPENDS:packagegroup-distro-base = "${DISTRO_EXTRA_DEPENDS}" > > I'm not sure this is actually doing anything? > > Nothing sets DISTRO_EXTRA_DEPENDS in poky, it's also not documented. > > This line was added 18 years ago during a git sync with svn > (3e5ee5acdca51af57c7b6ccd2136f7b548a80293) so history is lost sadly. > > DEPENDS:recipe-name isnt' even a valid override as far as i know (it > should be pn-recipe-name) and even if it was, what would be the point, > we already are in the recipe so there's no need for an override. The > RDEPENDS overrides make sense because it applies for the package and not > recipe (and most recipes have the main package named after the recipe). > > So I think we should simply remove this line? Good point. I think it can be removed as you're right, the override makes no sense anyway. Cheers, Richard
diff --git a/meta/recipes-core/packagegroups/packagegroup-base.bb b/meta/recipes-core/packagegroups/packagegroup-base.bb index cb9d1f07af5..2e051dba33d 100644 --- a/meta/recipes-core/packagegroups/packagegroup-base.bb +++ b/meta/recipes-core/packagegroups/packagegroup-base.bb @@ -119,7 +119,7 @@ python __anonymous () { # packages added by distribution # SUMMARY:packagegroup-distro-base = "${DISTRO} extras" -DEPENDS_packagegroup-distro-base = "${DISTRO_EXTRA_DEPENDS}" +DEPENDS:packagegroup-distro-base = "${DISTRO_EXTRA_DEPENDS}" RDEPENDS:packagegroup-distro-base = "${DISTRO_EXTRA_RDEPENDS}" RRECOMMENDS:packagegroup-distro-base = "${DISTRO_EXTRA_RRECOMMENDS}"