diff mbox series

python3: drop old nis module dependencies

Message ID 20250608122244.3093502-1-gudni.m.g@gmail.com
State Accepted, archived
Commit 742eca9cb56ab4ad10534181d28de1fdf3880b9f
Headers show
Series python3: drop old nis module dependencies | expand

Commit Message

Guðni Már Gilbert June 8, 2025, 12:22 p.m. UTC
libnsl2 and libtirpc were build dependencies for the nis module.

The nis module was deprecated in Python 3.11 and removed in Python 3.13

Signed-off-by: Guðni Már Gilbert <gudni.m.g@gmail.com>
---
 meta/recipes-devtools/python/python3_3.13.3.bb | 2 --
 1 file changed, 2 deletions(-)

Comments

Guðni Már Gilbert June 8, 2025, 12:25 p.m. UTC | #1
I'm 90% sure these build dependencies are not needed anymore, See: https://github.com/python/cpython/pull/104897

Hopefully I didn't missing anything. The build succeeds locally for me. It would be nice to have another set of eyes to review this :) Fewer dependencies is always nice if possible.
Richard Purdie June 9, 2025, 9:54 a.m. UTC | #2
On Sun, 2025-06-08 at 12:22 +0000, Guðni Már Gilbert via lists.openembedded.org wrote:
> libnsl2 and libtirpc were build dependencies for the nis module.
> 
> The nis module was deprecated in Python 3.11 and removed in Python 3.13
> 
> Signed-off-by: Guðni Már Gilbert <gudni.m.g@gmail.com>
> ---
>  meta/recipes-devtools/python/python3_3.13.3.bb | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/meta/recipes-devtools/python/python3_3.13.3.bb b/meta/recipes-devtools/python/python3_3.13.3.bb
> index 6839d28e19..11dd6f4b8f 100644
> --- a/meta/recipes-devtools/python/python3_3.13.3.bb
> +++ b/meta/recipes-devtools/python/python3_3.13.3.bb
> @@ -72,8 +72,6 @@ DEPENDS = "\
>      bzip2-replacement-native \
>      expat \
>      libffi \
> -    libnsl2 \
> -    libtirpc \
>      ncurses \
>      openssl \
>      sqlite3 \
> 

Well spotted, removing things like this is definitely desirable!

I think this patch causes xwayland to break as it was seeing libtirpc
through python's dependency but that is a bug in the xwayland recipe we
should find separately, I've sent a patch. I'll retry testing and see
if anything else shows up.

Cheers,

Richard
diff mbox series

Patch

diff --git a/meta/recipes-devtools/python/python3_3.13.3.bb b/meta/recipes-devtools/python/python3_3.13.3.bb
index 6839d28e19..11dd6f4b8f 100644
--- a/meta/recipes-devtools/python/python3_3.13.3.bb
+++ b/meta/recipes-devtools/python/python3_3.13.3.bb
@@ -72,8 +72,6 @@  DEPENDS = "\
     bzip2-replacement-native \
     expat \
     libffi \
-    libnsl2 \
-    libtirpc \
     ncurses \
     openssl \
     sqlite3 \