| Message ID | 20250606135700.1689460-1-geoffrey.vanlandeghem@niko.eu |
|---|---|
| State | New |
| Headers | show |
| Series | [meta-oe,kirkstone] monit: upgrade 5.32.0 -> 5.35.2 | expand |
On 6/6/25 15:57, Geoffrey Van Landeghem via lists.openembedded.org wrote: > Monit 5.32 seems to contain a bug where it runs its poll cycles much faster. This can be troublesome when setting up dependencies. See https://bitbucket.org/tildeslash/monit/issues/1131/service-with-many-dependencies-hits > > Signed-off-by: Geoffrey Van Landeghem <geoffrey.vanlandeghem@niko.eu> > --- > .../monit/{monit_5.32.0.bb => monit_5.35.2.bb} | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > rename meta-oe/recipes-support/monit/{monit_5.32.0.bb => monit_5.35.2.bb} (84%) > > diff --git a/meta-oe/recipes-support/monit/monit_5.32.0.bb b/meta-oe/recipes-support/monit/monit_5.35.2.bb > similarity index 84% > rename from meta-oe/recipes-support/monit/monit_5.32.0.bb > rename to meta-oe/recipes-support/monit/monit_5.35.2.bb > index e4ec9d5262..6ff74cf0d8 100644 > --- a/meta-oe/recipes-support/monit/monit_5.32.0.bb > +++ b/meta-oe/recipes-support/monit/monit_5.35.2.bb > @@ -6,8 +6,8 @@ causal actions in error situations." > HOMEPAGE = "http://mmonit.com/monit/" > > LICENSE = "AGPL-3.0-only" > -LIC_FILES_CHKSUM = "file://COPYING;md5=ea116a7defaf0e93b3bb73b2a34a3f51 \ > - file://libmonit/COPYING;md5=2405f1c59ed1bf3714cebdb40162ce92" > +LIC_FILES_CHKSUM = "file://COPYING;md5=79ca9f26f1ecb1e377e90383109ede64 \ > + file://libmonit/COPYING;md5=44aaa0a664332e9568add09f1ddb01cb" I got 2 notes: 1. When the checksum of the license changes, it is useful to include in the commit message some notes why that is. Usually it is some minor formatting change, but sometimes the license changes outright between versions. 2. A bigger thing is, that generally this update is too big for a stable branch. Usually only bugfix release updates are allowed, not feature ones. Having the bugfix backported to 5.32, and including it as a patch would be a better approach. > > SRC_URI = " \ > https://mmonit.com/monit/dist/monit-${PV}.tar.gz \ > @@ -15,12 +15,14 @@ SRC_URI = " \ > file://monitrc \ > " > > -SRC_URI[sha256sum] = "1077052d4c4e848ac47d14f9b37754d46419aecbe8c9a07e1f869c914faf3216" > +SRC_URI[sha256sum] = "4dfef54329e63d9772a9e1c36ac99bc41173b79963dc0d8235f2c32f4b9e078f" > > DEPENDS = "zlib bison-native libnsl2 flex-native openssl virtual/crypt" > > inherit autotools-brokensep systemd update-rc.d > > +EXTRA_AUTORECONF += "-I config" > + > PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'pam', d)}" > PACKAGECONFIG[pam] = "--with-pam,--without-pam,libpam" > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#117762): https://lists.openembedded.org/g/openembedded-devel/message/117762 > Mute This Topic: https://lists.openembedded.org/mt/113503536/6084445 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [skandigraun@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
Thanks for reviewing. Changes are actually backported from the master branch, hence the checksum change. I already assumed that skipping a few versions would be rather hard to get accepted but I wanted to give it a shot anyway. Regarding backporting, well we're only targeting kirkstone for a few more months so that doesn't really pay off for us given the little effort it takes to get a good working version (this patch). Do you think we can still bump the monit version for scarthgap? Op vr 6 jun 2025 om 16:29 schreef Gyorgy Sarvari <skandigraun@gmail.com>: > On 6/6/25 15:57, Geoffrey Van Landeghem via lists.openembedded.org wrote: > > Monit 5.32 seems to contain a bug where it runs its poll cycles much > faster. This can be troublesome when setting up dependencies. See > https://bitbucket.org/tildeslash/monit/issues/1131/service-with-many-dependencies-hits > > > > Signed-off-by: Geoffrey Van Landeghem <geoffrey.vanlandeghem@niko.eu> > > --- > > .../monit/{monit_5.32.0.bb => monit_5.35.2.bb} | 8 +++++--- > > 1 file changed, 5 insertions(+), 3 deletions(-) > > rename meta-oe/recipes-support/monit/{monit_5.32.0.bb => > monit_5.35.2.bb} (84%) > > > > diff --git a/meta-oe/recipes-support/monit/monit_5.32.0.bb > b/meta-oe/recipes-support/monit/monit_5.35.2.bb > > similarity index 84% > > rename from meta-oe/recipes-support/monit/monit_5.32.0.bb > > rename to meta-oe/recipes-support/monit/monit_5.35.2.bb > > index e4ec9d5262..6ff74cf0d8 100644 > > --- a/meta-oe/recipes-support/monit/monit_5.32.0.bb > > +++ b/meta-oe/recipes-support/monit/monit_5.35.2.bb > > @@ -6,8 +6,8 @@ causal actions in error situations." > > HOMEPAGE = "http://mmonit.com/monit/" > > > > LICENSE = "AGPL-3.0-only" > > -LIC_FILES_CHKSUM = "file://COPYING;md5=ea116a7defaf0e93b3bb73b2a34a3f51 > \ > > - > file://libmonit/COPYING;md5=2405f1c59ed1bf3714cebdb40162ce92" > > +LIC_FILES_CHKSUM = "file://COPYING;md5=79ca9f26f1ecb1e377e90383109ede64 > \ > > + > file://libmonit/COPYING;md5=44aaa0a664332e9568add09f1ddb01cb" > > I got 2 notes: > 1. When the checksum of the license changes, it is useful to include in > the commit message some notes why that is. Usually it is some minor > formatting change, but sometimes the license changes outright between > versions. > 2. A bigger thing is, that generally this update is too big for a stable > branch. Usually only bugfix release updates are allowed, not feature > ones. Having the bugfix backported to 5.32, and including it as a patch > would be a better approach. > > > > > SRC_URI = " \ > > https://mmonit.com/monit/dist/monit-${PV}.tar.gz \ > > @@ -15,12 +15,14 @@ SRC_URI = " \ > > file://monitrc \ > > " > > > > -SRC_URI[sha256sum] = > "1077052d4c4e848ac47d14f9b37754d46419aecbe8c9a07e1f869c914faf3216" > > +SRC_URI[sha256sum] = > "4dfef54329e63d9772a9e1c36ac99bc41173b79963dc0d8235f2c32f4b9e078f" > > > > DEPENDS = "zlib bison-native libnsl2 flex-native openssl virtual/crypt" > > > > inherit autotools-brokensep systemd update-rc.d > > > > +EXTRA_AUTORECONF += "-I config" > > + > > PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'pam', d)}" > > PACKAGECONFIG[pam] = "--with-pam,--without-pam,libpam" > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > > Links: You receive all messages sent to this group. > > View/Reply Online (#117762): > https://lists.openembedded.org/g/openembedded-devel/message/117762 > > Mute This Topic: https://lists.openembedded.org/mt/113503536/6084445 > > Group Owner: openembedded-devel+owner@lists.openembedded.org > > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [ > skandigraun@gmail.com] > > -=-=-=-=-=-=-=-=-=-=-=- > > > >
diff --git a/meta-oe/recipes-support/monit/monit_5.32.0.bb b/meta-oe/recipes-support/monit/monit_5.35.2.bb similarity index 84% rename from meta-oe/recipes-support/monit/monit_5.32.0.bb rename to meta-oe/recipes-support/monit/monit_5.35.2.bb index e4ec9d5262..6ff74cf0d8 100644 --- a/meta-oe/recipes-support/monit/monit_5.32.0.bb +++ b/meta-oe/recipes-support/monit/monit_5.35.2.bb @@ -6,8 +6,8 @@ causal actions in error situations." HOMEPAGE = "http://mmonit.com/monit/" LICENSE = "AGPL-3.0-only" -LIC_FILES_CHKSUM = "file://COPYING;md5=ea116a7defaf0e93b3bb73b2a34a3f51 \ - file://libmonit/COPYING;md5=2405f1c59ed1bf3714cebdb40162ce92" +LIC_FILES_CHKSUM = "file://COPYING;md5=79ca9f26f1ecb1e377e90383109ede64 \ + file://libmonit/COPYING;md5=44aaa0a664332e9568add09f1ddb01cb" SRC_URI = " \ https://mmonit.com/monit/dist/monit-${PV}.tar.gz \ @@ -15,12 +15,14 @@ SRC_URI = " \ file://monitrc \ " -SRC_URI[sha256sum] = "1077052d4c4e848ac47d14f9b37754d46419aecbe8c9a07e1f869c914faf3216" +SRC_URI[sha256sum] = "4dfef54329e63d9772a9e1c36ac99bc41173b79963dc0d8235f2c32f4b9e078f" DEPENDS = "zlib bison-native libnsl2 flex-native openssl virtual/crypt" inherit autotools-brokensep systemd update-rc.d +EXTRA_AUTORECONF += "-I config" + PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'pam', d)}" PACKAGECONFIG[pam] = "--with-pam,--without-pam,libpam"
Monit 5.32 seems to contain a bug where it runs its poll cycles much faster. This can be troublesome when setting up dependencies. See https://bitbucket.org/tildeslash/monit/issues/1131/service-with-many-dependencies-hits Signed-off-by: Geoffrey Van Landeghem <geoffrey.vanlandeghem@niko.eu> --- .../monit/{monit_5.32.0.bb => monit_5.35.2.bb} | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) rename meta-oe/recipes-support/monit/{monit_5.32.0.bb => monit_5.35.2.bb} (84%)