| Message ID | 20250530032047.1369164-1-sandeep.gundlupet-raju@amd.com |
|---|---|
| State | Rejected, archived |
| Headers | show |
| Series | [scarthgap,master] tune-cortexr52: Add support for ARM Cortex-R52 32-bit | expand |
LGTM On Thu, May 29, 2025 at 8:20 PM Sandeep Gundlupet Raju <sandeep.gundlupet-raju@amd.com> wrote: > > Add tune variant for ARM Cortex-R52 32-bit in GCC as there is no > support for Cortex-R52 32-bit toolchain. > > Signed-off-by: Sandeep Gundlupet Raju <sandeep.gundlupet-raju@amd.com> > Signed-off-by: Sandeep Gundlupet Raju <grsandeep85@gmail.com> > --- > meta/conf/machine/include/arm/armv8r/tune-cortexr52.inc | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/meta/conf/machine/include/arm/armv8r/tune-cortexr52.inc b/meta/conf/machine/include/arm/armv8r/tune-cortexr52.inc > index 89f0e09450..ba1c2ffa28 100644 > --- a/meta/conf/machine/include/arm/armv8r/tune-cortexr52.inc > +++ b/meta/conf/machine/include/arm/armv8r/tune-cortexr52.inc > @@ -18,3 +18,8 @@ AVAILTUNES += "cortexr52hf" > ARMPKGARCH:tune-cortexr52hf = "cortexr52" > TUNE_FEATURES:tune-cortexr52hf = "${TUNE_FEATURES:tune-cortexr52} callconvention-hard" > PACKAGE_EXTRA_ARCHS:tune-cortexr52hf = "cortexr52hf" > + > +AVAILTUNES += "cortexr52-32" > +ARMPKGARCH:tune-cortexr52-32 = "cortexr52" > +TUNE_FEATURES:tune-cortexr52-32 = "${TUNE_FEATURES:tune-armv8r-crc-simd} cortexr52" > +PACKAGE_EXTRA_ARCHS:tune-cortexr52-32 = "${PACKAGE_EXTRA_ARCHS:tune-armv8r-crc-simd} cortexr52 cortexr52-32" > -- > 2.34.1 >
On 30 May 2025, at 04:20, Sandeep Gundlupet Raju via lists.openembedded.org <sandeep.gundlupet-raju=amd.com@lists.openembedded.org> wrote: > > Add tune variant for ARM Cortex-R52 32-bit in GCC as there is no > support for Cortex-R52 32-bit toolchain. This is the wrong fix as the existing tune file is just wrong. The cortexr52 tune says: TUNE_FEATURES:tune-cortexr52 = "aarch64 crc simd cortexr52” But the Cortex R52 Technical Reference Manual[1] says "The Cortex®-R52 processor implements the Armv8-R AArch32 architecture”, so there is no 64-bit R52. The solution here is to stop it claiming to be 64-bit at all. Ross [1] https://developer.arm.com/documentation/100026/0104/The-Cortex-R52-processor/Supported-standards/Arm-architecture?lang=en
On Thu, Jun 5, 2025 at 7:12 AM Ross Burton <Ross.Burton@arm.com> wrote: > > On 30 May 2025, at 04:20, Sandeep Gundlupet Raju via lists.openembedded.org <sandeep.gundlupet-raju=amd.com@lists.openembedded.org> wrote: > > > > Add tune variant for ARM Cortex-R52 32-bit in GCC as there is no > > support for Cortex-R52 32-bit toolchain. > > This is the wrong fix as the existing tune file is just wrong. > > The cortexr52 tune says: > > TUNE_FEATURES:tune-cortexr52 = "aarch64 crc simd cortexr52” > > But the Cortex R52 Technical Reference Manual[1] says "The Cortex®-R52 processor implements the Armv8-R AArch32 architecture”, so there is no 64-bit R52. > > The solution here is to stop it claiming to be 64-bit at all. agreed, I see that Cortex-R82 is one which implements 64bit ISA and not Cortex-R52 > > Ross > > [1] https://developer.arm.com/documentation/100026/0104/The-Cortex-R52-processor/Supported-standards/Arm-architecture?lang=en
On 6/5/2025 8:12 AM, Ross Burton via lists.openembedded.org wrote: > On 30 May 2025, at 04:20, Sandeep Gundlupet Raju via lists.openembedded.org <sandeep.gundlupet-raju=amd.com@lists.openembedded.org> wrote: >> Add tune variant for ARM Cortex-R52 32-bit in GCC as there is no >> support for Cortex-R52 32-bit toolchain. > This is the wrong fix as the existing tune file is just wrong. > > The cortexr52 tune says: > > TUNE_FEATURES:tune-cortexr52 = "aarch64 crc simd cortexr52” > > But the Cortex R52 Technical Reference Manual[1] says "The Cortex®-R52 processor implements the Armv8-R AArch32 architecture”, so there is no 64-bit R52. > > The solution here is to stop it claiming to be 64-bit at all. > > Ross > > [1] https://developer.arm.com/documentation/100026/0104/The-Cortex-R52-processor/Supported-standards/Arm-architecture?lang=en [Sandeep]: Ross, Thanks for the reference point. I can send a v2 patch by removing 64-bit references. But I won't able to test all the use cases. > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#218026): https://lists.openembedded.org/g/openembedded-core/message/218026 > Mute This Topic: https://lists.openembedded.org/mt/113374193/3619217 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [sandeep.gundlupet-raju@amd.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On 6/5/2025 9:31 AM, Sandeep Gundlupet Raju via lists.openembedded.org wrote: > > On 6/5/2025 8:12 AM, Ross Burton via lists.openembedded.org wrote: >> On 30 May 2025, at 04:20, Sandeep Gundlupet Raju via >> lists.openembedded.org >> <sandeep.gundlupet-raju=amd.com@lists.openembedded.org> wrote: >>> Add tune variant for ARM Cortex-R52 32-bit in GCC as there is no >>> support for Cortex-R52 32-bit toolchain. >> This is the wrong fix as the existing tune file is just wrong. >> >> The cortexr52 tune says: >> >> TUNE_FEATURES:tune-cortexr52 = "aarch64 crc simd cortexr52” >> >> But the Cortex R52 Technical Reference Manual[1] says "The >> Cortex®-R52 processor implements the Armv8-R AArch32 architecture”, >> so there is no 64-bit R52. >> >> The solution here is to stop it claiming to be 64-bit at all. >> >> Ross >> >> [1] >> https://developer.arm.com/documentation/100026/0104/The-Cortex-R52-processor/Supported-standards/Arm-architecture?lang=en > [Sandeep]: Ross, Thanks for the reference point. I can send a v2 patch > by removing 64-bit references. But I won't able to test all the use > cases. [Sandeep]: I had a chat with Khem and he said we can enable 64-bit ISA optionally. I will wait for Khem to reply wiht right pointers. This is blocking some of our deliverables to build r52-bit baremetal and zephyr application. >> >> >> > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#218036): https://lists.openembedded.org/g/openembedded-core/message/218036 > Mute This Topic: https://lists.openembedded.org/mt/113374193/3619217 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [sandeep.gundlupet-raju@amd.com] > -=-=-=-=-=-=-=-=-=-=-=- >
Hi Sandeep On Fri, Jun 6, 2025 at 10:35 AM Gundlupet Raju, Sandeep <sandeep.gundlupet-raju@amd.com> wrote: > > > On 6/5/2025 9:31 AM, Sandeep Gundlupet Raju via lists.openembedded.org > wrote: > > > > On 6/5/2025 8:12 AM, Ross Burton via lists.openembedded.org wrote: > >> On 30 May 2025, at 04:20, Sandeep Gundlupet Raju via > >> lists.openembedded.org > >> <sandeep.gundlupet-raju=amd.com@lists.openembedded.org> wrote: > >>> Add tune variant for ARM Cortex-R52 32-bit in GCC as there is no > >>> support for Cortex-R52 32-bit toolchain. > >> This is the wrong fix as the existing tune file is just wrong. > >> > >> The cortexr52 tune says: > >> > >> TUNE_FEATURES:tune-cortexr52 = "aarch64 crc simd cortexr52” > >> > >> But the Cortex R52 Technical Reference Manual[1] says "The > >> Cortex®-R52 processor implements the Armv8-R AArch32 architecture”, > >> so there is no 64-bit R52. > >> > >> The solution here is to stop it claiming to be 64-bit at all. Looking at web for docs I see Cortex-r82 which is based on ARMv8-R with aarch64 ISA https://developer.arm.com/Processors/Cortex-R82 Cortex-r52 which is under question here says its ARMv8-R but with 32bit ISA https://developer.arm.com/Processors/Cortex-R52 So I think we should remove aarch64 from this tune, that will be right thing to do for r52 > >> > >> Ross > >> > >> [1] > >> https://developer.arm.com/documentation/100026/0104/The-Cortex-R52-processor/Supported-standards/Arm-architecture?lang=en > > [Sandeep]: Ross, Thanks for the reference point. I can send a v2 patch > > by removing 64-bit references. But I won't able to test all the use > > cases. > [Sandeep]: I had a chat with Khem and he said we can enable 64-bit ISA > optionally. I will wait for Khem to reply wiht right pointers. This is > blocking some of our deliverables to build r52-bit baremetal and zephyr > application. > >> > >> > >> > > > > -=-=-=-=-=-=-=-=-=-=-=- > > Links: You receive all messages sent to this group. > > View/Reply Online (#218036): https://lists.openembedded.org/g/openembedded-core/message/218036 > > Mute This Topic: https://lists.openembedded.org/mt/113374193/3619217 > > Group Owner: openembedded-core+owner@lists.openembedded.org > > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [sandeep.gundlupet-raju@amd.com] > > -=-=-=-=-=-=-=-=-=-=-=- > >
On 6/6/2025 5:21 PM, Khem Raj via lists.openembedded.org wrote: > Hi Sandeep > > On Fri, Jun 6, 2025 at 10:35 AM Gundlupet Raju, Sandeep > <sandeep.gundlupet-raju@amd.com> wrote: >> >> On 6/5/2025 9:31 AM, Sandeep Gundlupet Raju via lists.openembedded.org >> wrote: >>> On 6/5/2025 8:12 AM, Ross Burton via lists.openembedded.org wrote: >>>> On 30 May 2025, at 04:20, Sandeep Gundlupet Raju via >>>> lists.openembedded.org >>>> <sandeep.gundlupet-raju=amd.com@lists.openembedded.org> wrote: >>>>> Add tune variant for ARM Cortex-R52 32-bit in GCC as there is no >>>>> support for Cortex-R52 32-bit toolchain. >>>> This is the wrong fix as the existing tune file is just wrong. >>>> >>>> The cortexr52 tune says: >>>> >>>> TUNE_FEATURES:tune-cortexr52 = "aarch64 crc simd cortexr52” >>>> >>>> But the Cortex R52 Technical Reference Manual[1] says "The >>>> Cortex®-R52 processor implements the Armv8-R AArch32 architecture”, >>>> so there is no 64-bit R52. >>>> >>>> The solution here is to stop it claiming to be 64-bit at all. > Looking at web for docs I see > > Cortex-r82 which is based on ARMv8-R with aarch64 ISA > > https://developer.arm.com/Processors/Cortex-R82 > > Cortex-r52 which is under question here says its ARMv8-R but with 32bit ISA > > https://developer.arm.com/Processors/Cortex-R52 > > So I think we should remove aarch64 from this tune, that will be right > thing to do for r52 [Sandeep]: Mathieu please drop https://git.openembedded.org/openembedded-core-contrib/commit/meta/conf/machine/include/arm/armv8r?h=mathieu/master-next&id=10bce00fb2176515a35c422028d43adb10d02def patch from master-next branch. > > >>>> Ross >>>> >>>> [1] >>>> https://developer.arm.com/documentation/100026/0104/The-Cortex-R52-processor/Supported-standards/Arm-architecture?lang=en >>> [Sandeep]: Ross, Thanks for the reference point. I can send a v2 patch >>> by removing 64-bit references. But I won't able to test all the use >>> cases. >> [Sandeep]: I had a chat with Khem and he said we can enable 64-bit ISA >> optionally. I will wait for Khem to reply wiht right pointers. This is >> blocking some of our deliverables to build r52-bit baremetal and zephyr >> application. >>>> >>>> >>> >>> >>> >>> -=-=-=-=-=-=-=-=-=-=-=- >>> Links: You receive all messages sent to this group. >>> View/Reply Online (#218189): https://lists.openembedded.org/g/openembedded-core/message/218189 >>> Mute This Topic: https://lists.openembedded.org/mt/113374193/3619217 >>> Group Owner: openembedded-core+owner@lists.openembedded.org >>> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [sandeep.gundlupet-raju@amd.com] >>> -=-=-=-=-=-=-=-=-=-=-=- >>>
diff --git a/meta/conf/machine/include/arm/armv8r/tune-cortexr52.inc b/meta/conf/machine/include/arm/armv8r/tune-cortexr52.inc index 89f0e09450..ba1c2ffa28 100644 --- a/meta/conf/machine/include/arm/armv8r/tune-cortexr52.inc +++ b/meta/conf/machine/include/arm/armv8r/tune-cortexr52.inc @@ -18,3 +18,8 @@ AVAILTUNES += "cortexr52hf" ARMPKGARCH:tune-cortexr52hf = "cortexr52" TUNE_FEATURES:tune-cortexr52hf = "${TUNE_FEATURES:tune-cortexr52} callconvention-hard" PACKAGE_EXTRA_ARCHS:tune-cortexr52hf = "cortexr52hf" + +AVAILTUNES += "cortexr52-32" +ARMPKGARCH:tune-cortexr52-32 = "cortexr52" +TUNE_FEATURES:tune-cortexr52-32 = "${TUNE_FEATURES:tune-armv8r-crc-simd} cortexr52" +PACKAGE_EXTRA_ARCHS:tune-cortexr52-32 = "${PACKAGE_EXTRA_ARCHS:tune-armv8r-crc-simd} cortexr52 cortexr52-32"