| Message ID | 20250521191449.1486927-3-ross.burton@arm.com |
|---|---|
| State | Accepted, archived |
| Commit | 79dcbed250cfe8ab05dd6e075905ad37de6d3bc4 |
| Headers | show |
| Series | [1/3] rust: remove python3-native DEPENDS | expand |
Hi Ross, On 5/21/25 9:14 PM, Ross Burton via lists.openembedded.org wrote: > It's unclear what this was for: there's no use of "file" or libmagic in > the recipe, and the guide to building Rust from source doesn't list file > as a dependency[1]. > > [1] https://github.com/rust-lang/rust/blob/master/INSTALL.md#dependencies > > Signed-off-by: Ross Burton <ross.burton@arm.com> > --- > meta/recipes-devtools/rust/rust_1.85.1.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-devtools/rust/rust_1.85.1.bb b/meta/recipes-devtools/rust/rust_1.85.1.bb > index 6411e43c961..a4a2c69d9d8 100644 > --- a/meta/recipes-devtools/rust/rust_1.85.1.bb > +++ b/meta/recipes-devtools/rust/rust_1.85.1.bb > @@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://COPYRIGHT;md5=9c0fae516fe8aaea2fb601db4800daf7" > inherit rust > inherit cargo_common > > -DEPENDS += "file-native rust-llvm" > +DEPENDS += "rust-llvm" Also not sure it's a big issue if missing since file is a dependency of OE/BitBake according to the ASSUME_PROVIDED variable in meta/conf/bitbake.conf? So being there or not shouldn't change anything? Cheers, Quentin
On 22 May 2025, at 13:31, Quentin Schulz <quentin.schulz@cherry.de> wrote:
> Also not sure it's a big issue if missing since file is a dependency of OE/BitBake according to the ASSUME_PROVIDED variable in meta/conf/bitbake.conf? So being there or not shouldn't change anything?
Ha, I’d not noticed that. Yes, this literally doesn’t change anything as the dependency never had any impact.
Ross
diff --git a/meta/recipes-devtools/rust/rust_1.85.1.bb b/meta/recipes-devtools/rust/rust_1.85.1.bb index 6411e43c961..a4a2c69d9d8 100644 --- a/meta/recipes-devtools/rust/rust_1.85.1.bb +++ b/meta/recipes-devtools/rust/rust_1.85.1.bb @@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://COPYRIGHT;md5=9c0fae516fe8aaea2fb601db4800daf7" inherit rust inherit cargo_common -DEPENDS += "file-native rust-llvm" +DEPENDS += "rust-llvm" # native rust uses cargo/rustc from binary snapshots to bootstrap # but everything else should use our native builds DEPENDS:append:class-target = " cargo-native rust-native"
It's unclear what this was for: there's no use of "file" or libmagic in the recipe, and the guide to building Rust from source doesn't list file as a dependency[1]. [1] https://github.com/rust-lang/rust/blob/master/INSTALL.md#dependencies Signed-off-by: Ross Burton <ross.burton@arm.com> --- meta/recipes-devtools/rust/rust_1.85.1.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)