diff mbox series

[v2,03/28] vte: Disable gi data generation when using clang on arm

Message ID 20250520-clang-toolchain-v2-3-db97c2eb3756@gmail.com
State New
Headers show
Series clang: Add clang C/C++ toolchain | expand

Commit Message

Khem Raj May 21, 2025, 6:19 a.m. UTC
Fixes Qemu usermode crashes

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-support/vte/vte_0.78.2.bb | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Ross Burton May 22, 2025, 9:38 a.m. UTC | #1
> On 21 May 2025, at 07:19, Khem Raj via lists.openembedded.org <raj.khem=gmail.com@lists.openembedded.org> wrote:
> +# qemu usermode crashes when using clang as system compiler but works with gcc
> +# see https://patchwork.yoctoproject.org/project/oe-core/patch/20240923234336.3978188-1-raj.khem@gmail.com/
> +GI_DATA_ENABLED:pn-vte:toolchain-clang:armv7ve = "False"

No need for :pn-vte:

Ross
Ross Burton May 22, 2025, 9:42 a.m. UTC | #2
On 21 May 2025, at 07:19, Khem Raj via lists.openembedded.org <raj.khem=gmail.com@lists.openembedded.org> wrote:
> +# qemu usermode crashes when using clang as system compiler but works with gcc
> +# see https://patchwork.yoctoproject.org/project/oe-core/patch/20240923234336.3978188-1-raj.khem@gmail.com/
> +GI_DATA_ENABLED:pn-vte:toolchain-clang:armv7ve = "False"

Was this failure replicated with current master?  I’m concerned as to why vte fails but nothing else using G-I.

Ross
Khem Raj May 22, 2025, 3:33 p.m. UTC | #3
On Thu, May 22, 2025 at 2:43 AM Ross Burton <Ross.Burton@arm.com> wrote:
>
> On 21 May 2025, at 07:19, Khem Raj via lists.openembedded.org <raj.khem=gmail.com@lists.openembedded.org> wrote:
> > +# qemu usermode crashes when using clang as system compiler but works with gcc
> > +# see https://patchwork.yoctoproject.org/project/oe-core/patch/20240923234336.3978188-1-raj.khem@gmail.com/
> > +GI_DATA_ENABLED:pn-vte:toolchain-clang:armv7ve = "False"
>
> Was this failure replicated with current master?  I’m concerned as to why vte fails but nothing else using G-I.
>
Yes it still happens.
qemu in usermode crashes during gi data generation with binaries built
with clang, I did not have time to go look
why qemu is crashing if someone can it would help.

> Ross
Richard Purdie May 29, 2025, 9:18 a.m. UTC | #4
On Tue, 2025-05-20 at 23:19 -0700, Khem Raj via lists.openembedded.org wrote:
> Fixes Qemu usermode crashes
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/recipes-support/vte/vte_0.78.2.bb | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/meta/recipes-support/vte/vte_0.78.2.bb b/meta/recipes-support/vte/vte_0.78.2.bb
> index 0593d16cd8678d010c240581138caf22f2908659..e37d59833cf3313bdb369f4e0957dfc5e3cb3ace 100644
> --- a/meta/recipes-support/vte/vte_0.78.2.bb
> +++ b/meta/recipes-support/vte/vte_0.78.2.bb
> @@ -26,6 +26,10 @@ SRC_URI[archive.sha256sum] = "35d7bcde07356846b4a12881c8e016705b70a9004a9082285e
>  
>  ANY_OF_DISTRO_FEATURES = "${GTK3DISTROFEATURES}"
>  
> +# qemu usermode crashes when using clang as system compiler but works with gcc
> +# see https://patchwork.yoctoproject.org/project/oe-core/patch/20240923234336.3978188-1-raj.khem@gmail.com/
> +GI_DATA_ENABLED:pn-vte:toolchain-clang:armv7ve = "False"
> +
>  EXTRA_OEMESON += "${@bb.utils.contains('GI_DATA_ENABLED', 'True', '-Dvapi=true', '-Dvapi=false', d)}"
>  EXTRA_OEMESON:append = " ${@bb.utils.contains('GI_DATA_ENABLED', 'False', '-Ddocs=false', '', d)}"

I don't really want to regress a feature like like this in a very
specific target as it is just going to confuse people. We should
probably just force gcc until this gets resolved.

I'm also puzzled why some people can replicate and some can't. We need
therefore better data on this too.

As such I'm reluctant to merge due to the difference in features it
creates.

Cheers,

Richard
diff mbox series

Patch

diff --git a/meta/recipes-support/vte/vte_0.78.2.bb b/meta/recipes-support/vte/vte_0.78.2.bb
index 0593d16cd8678d010c240581138caf22f2908659..e37d59833cf3313bdb369f4e0957dfc5e3cb3ace 100644
--- a/meta/recipes-support/vte/vte_0.78.2.bb
+++ b/meta/recipes-support/vte/vte_0.78.2.bb
@@ -26,6 +26,10 @@  SRC_URI[archive.sha256sum] = "35d7bcde07356846b4a12881c8e016705b70a9004a9082285e
 
 ANY_OF_DISTRO_FEATURES = "${GTK3DISTROFEATURES}"
 
+# qemu usermode crashes when using clang as system compiler but works with gcc
+# see https://patchwork.yoctoproject.org/project/oe-core/patch/20240923234336.3978188-1-raj.khem@gmail.com/
+GI_DATA_ENABLED:pn-vte:toolchain-clang:armv7ve = "False"
+
 EXTRA_OEMESON += "${@bb.utils.contains('GI_DATA_ENABLED', 'True', '-Dvapi=true', '-Dvapi=false', d)}"
 EXTRA_OEMESON:append = " ${@bb.utils.contains('GI_DATA_ENABLED', 'False', '-Ddocs=false', '', d)}"