diff mbox series

[v2] util-linux: ignore mkfds BPF related ptests

Message ID 20250501054339.3770986-1-richard.purdie@linuxfoundation.org
State Accepted, archived
Commit dc989569d3528d999f2a1f4363a9ef8325e09600
Headers show
Series [v2] util-linux: ignore mkfds BPF related ptests | expand

Commit Message

Richard Purdie May 1, 2025, 5:43 a.m. UTC 
From: Khem Raj <raj.khem@gmail.com>

They do not pass with GCC-15, ignore them for now

[RP: Fix formatting of exclude to be whitespace separated]
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/recipes-core/util-linux/util-linux/run-ptest | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ross Burton May 1, 2025, 1:13 p.m. UTC | #1 
On 1 May 2025, at 06:43, Richard Purdie via lists.openembedded.org <richard.purdie=linuxfoundation.org@lists.openembedded.org> wrote:
> # lsfd/option-inet has races in the test script:
> # https://github.com/util-linux/util-linux/issues/2399
> -./tests/run.sh --use-system-commands --parsable --show-diff --exclude=lsfd/option-inet | sed -u '{
> +./tests/run.sh --use-system-commands --parsable --show-diff --exclude='lsfd/option-inet lsfd/mkfds-bpf-map lsfd/mkfds-bpf-

I’d like to see a comment in the recipe like the lsfd tests giving some context to the skips to avoid having to dig into git history, especially as the intention that these are being skipped temporarily.

For reference, https://github.com/util-linux/util-linux/pull/3343 is the upstream PR to use GCC 15 in their CI which _presumably_ sees the same problem.

Ross
Richard Purdie May 1, 2025, 1:34 p.m. UTC | #2 
On Thu, 2025-05-01 at 13:13 +0000, Ross Burton wrote:
> On 1 May 2025, at 06:43, Richard Purdie via lists.openembedded.org
> <richard.purdie=linuxfoundation.org@lists.openembedded.org> wrote:
> > # lsfd/option-inet has races in the test script:
> > # https://github.com/util-linux/util-linux/issues/2399
> > -./tests/run.sh --use-system-commands --parsable --show-diff --
> > exclude=lsfd/option-inet | sed -u '{
> > +./tests/run.sh --use-system-commands --parsable --show-diff --
> > exclude='lsfd/option-inet lsfd/mkfds-bpf-map lsfd/mkfds-bpf-
> 
> I’d like to see a comment in the recipe like the lsfd tests giving
> some context to the skips to avoid having to dig into git history,
> especially as the intention that these are being skipped temporarily.
> 
> For reference, https://github.com/util-linux/util-linux/pull/3343 is
> the upstream PR to use GCC 15 in their CI which _presumably_ sees the
> same problem.

This was the final piece of gcc 15 so I merged it with a small comment.
If anyone wants to extend it, I'm happy to take followups.

Cheers,

Richard
diff mbox series

Patch

diff --git a/meta/recipes-core/util-linux/util-linux/run-ptest b/meta/recipes-core/util-linux/util-linux/run-ptest
index 7b6b1d1dc2a..87fc0f11451 100644
--- a/meta/recipes-core/util-linux/util-linux/run-ptest
+++ b/meta/recipes-core/util-linux/util-linux/run-ptest
@@ -24,7 +24,7 @@  mount --make-shared /
 
 # lsfd/option-inet has races in the test script:
 # https://github.com/util-linux/util-linux/issues/2399
-./tests/run.sh --use-system-commands --parsable --show-diff --exclude=lsfd/option-inet | sed -u '{
+./tests/run.sh --use-system-commands --parsable --show-diff --exclude='lsfd/option-inet lsfd/mkfds-bpf-map lsfd/mkfds-bpf-prog' | sed -u '{
       s/^\(.*\):\(.*\) \.\.\. OK$/PASS: \1:\2/                              
       s/^\(.*\):\(.*\) \.\.\. FAILED \(.*\)$/FAIL: \1:\2 \3/                
       s/^\(.*\):\(.*\) \.\.\. SKIPPED \(.*\)$/SKIP: \1:\2 \3/