| Message ID | FR2P281MB0121CBAFBE8CD25844976884B8832@FR2P281MB0121.DEUP281.PROD.OUTLOOK.COM |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [meta-oe] sdbus-c++: Upgrade to 2.1.0 release | expand |
On Wed, Apr 30, 2025 at 5:10 AM Thomas Noack via lists.openembedded.org <thomas.noack=iris-sensing.com@lists.openembedded.org> wrote: > > > Signed-off-by: Thomas Noack <thomas.noack@iris-sensing.com> > --- > .../{sdbus-c++-tools_2.0.0.bb => sdbus-c++-tools_2.1.0.bb} | 2 +- > .../sdbus-c++/{sdbus-c++_2.0.0.bb => sdbus-c++_2.1.0.bb} | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > rename meta-oe/recipes-core/sdbus-c++/{sdbus-c++-tools_2.0.0.bb => sdbus-c++-tools_2.1.0.bb} (88%) > rename meta-oe/recipes-core/sdbus-c++/{sdbus-c++_2.0.0.bb => sdbus-c++_2.1.0.bb} (97%) > > diff --git a/meta-oe/recipes-core/sdbus-c++/sdbus-c++-tools_2.0.0.bb b/meta-oe/recipes-core/sdbus-c++/sdbus-c++-tools_2.1.0.bb > similarity index 88% > rename from meta-oe/recipes-core/sdbus-c++/sdbus-c++-tools_2.0.0.bb > rename to meta-oe/recipes-core/sdbus-c++/sdbus-c++-tools_2.1.0.bb > index af112ced88..10704a6cd3 100644 > --- a/meta-oe/recipes-core/sdbus-c++/sdbus-c++-tools_2.0.0.bb > +++ b/meta-oe/recipes-core/sdbus-c++/sdbus-c++-tools_2.1.0.bb > @@ -8,7 +8,7 @@ inherit cmake > > DEPENDS += "expat" > > -SRCREV = "e62472b210d9e7f06a5e611c23471d414c99a99c" > +SRCREV = "0261d0ec60b68c1f0a6ec9acf63d1379f7d569f8" > SRC_URI = "git://github.com/Kistler-Group/sdbus-cpp.git;protocol=https;branch=master;subpath=tools" > > S = "${WORKDIR}/tools" > diff --git a/meta-oe/recipes-core/sdbus-c++/sdbus-c++_2.0.0.bb b/meta-oe/recipes-core/sdbus-c++/sdbus-c++_2.1.0.bb > similarity index 97% > rename from meta-oe/recipes-core/sdbus-c++/sdbus-c++_2.0.0.bb > rename to meta-oe/recipes-core/sdbus-c++/sdbus-c++_2.1.0.bb > index a3e7c9ab54..a81d94d2aa 100644 > --- a/meta-oe/recipes-core/sdbus-c++/sdbus-c++_2.0.0.bb > +++ b/meta-oe/recipes-core/sdbus-c++/sdbus-c++_2.1.0.bb > @@ -17,7 +17,7 @@ PACKAGECONFIG[with-tests] = "-DSDBUSCPP_BUILD_TESTS=ON -DSDBUSCPP_INSTALL_TESTS= > DEPENDS += "expat" > > PV .= "+git" If SHA is at exact release 2.1.0 then delete adding +git to PV > -SRCREV = "e62472b210d9e7f06a5e611c23471d414c99a99c" > +SRCREV = "0261d0ec60b68c1f0a6ec9acf63d1379f7d569f8" > SRC_URI = "git://github.com/Kistler-Group/sdbus-cpp.git;protocol=https;branch=master \ > file://run-ptest" > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#117252): https://lists.openembedded.org/g/openembedded-devel/message/117252 > Mute This Topic: https://lists.openembedded.org/mt/112537365/1997914 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
> -----Original Message----- > From: openembedded-devel@lists.openembedded.org <openembedded- > devel@lists.openembedded.org> On Behalf Of Khem Raj via > lists.openembedded.org > Sent: Wednesday, April 30, 2025 16:59 > To: thomas.noack@iris-sensing.com > Cc: openembedded-devel@lists.openembedded.org > Subject: Re: [oe] [meta-oe][PATCH] sdbus-c++: Upgrade to 2.1.0 release > > On Wed, Apr 30, 2025 at 5:10 AM Thomas Noack via > lists.openembedded.org > <thomas.noack=iris-sensing.com@lists.openembedded.org> wrote: > > > > > > Signed-off-by: Thomas Noack <thomas.noack@iris-sensing.com> > > --- > > .../{sdbus-c++-tools_2.0.0.bb => sdbus-c++-tools_2.1.0.bb} | 2 +- > > .../sdbus-c++/{sdbus-c++_2.0.0.bb => sdbus-c++_2.1.0.bb} | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > rename meta-oe/recipes-core/sdbus-c++/{sdbus-c++-tools_2.0.0.bb => sdbus- > c++-tools_2.1.0.bb} (88%) > > rename meta-oe/recipes-core/sdbus-c++/{sdbus-c++_2.0.0.bb => sdbus- > c++_2.1.0.bb} (97%) > > > > diff --git a/meta-oe/recipes-core/sdbus-c++/sdbus-c++-tools_2.0.0.bb b/meta- > oe/recipes-core/sdbus-c++/sdbus-c++-tools_2.1.0.bb > > similarity index 88% > > rename from meta-oe/recipes-core/sdbus-c++/sdbus-c++-tools_2.0.0.bb > > rename to meta-oe/recipes-core/sdbus-c++/sdbus-c++-tools_2.1.0.bb > > index af112ced88..10704a6cd3 100644 > > --- a/meta-oe/recipes-core/sdbus-c++/sdbus-c++-tools_2.0.0.bb > > +++ b/meta-oe/recipes-core/sdbus-c++/sdbus-c++-tools_2.1.0.bb > > @@ -8,7 +8,7 @@ inherit cmake > > > > DEPENDS += "expat" > > > > -SRCREV = "e62472b210d9e7f06a5e611c23471d414c99a99c" > > +SRCREV = "0261d0ec60b68c1f0a6ec9acf63d1379f7d569f8" > > SRC_URI = "git://github.com/Kistler-Group/sdbus- > cpp.git;protocol=https;branch=master;subpath=tools" > > > > S = "${WORKDIR}/tools" > > diff --git a/meta-oe/recipes-core/sdbus-c++/sdbus-c++_2.0.0.bb b/meta- > oe/recipes-core/sdbus-c++/sdbus-c++_2.1.0.bb > > similarity index 97% > > rename from meta-oe/recipes-core/sdbus-c++/sdbus-c++_2.0.0.bb > > rename to meta-oe/recipes-core/sdbus-c++/sdbus-c++_2.1.0.bb > > index a3e7c9ab54..a81d94d2aa 100644 > > --- a/meta-oe/recipes-core/sdbus-c++/sdbus-c++_2.0.0.bb > > +++ b/meta-oe/recipes-core/sdbus-c++/sdbus-c++_2.1.0.bb > > @@ -17,7 +17,7 @@ PACKAGECONFIG[with-tests] = "- > DSDBUSCPP_BUILD_TESTS=ON -DSDBUSCPP_INSTALL_TESTS= > > DEPENDS += "expat" > > > > PV .= "+git" > > If SHA is at exact release 2.1.0 then delete adding +git to PV And add tag to SRC_URI. > > > -SRCREV = "e62472b210d9e7f06a5e611c23471d414c99a99c" > > +SRCREV = "0261d0ec60b68c1f0a6ec9acf63d1379f7d569f8" > > SRC_URI = "git://github.com/Kistler-Group/sdbus- > cpp.git;protocol=https;branch=master \ > > file://run-ptest" > > > > > > > >
> And add tag to SRC_URI.
AFAIK this is not possible / bad practise, unless there were some recent changes to OE that I am unaware of. You can either specify "rev" directly in the SRC_URI or SRCREV, not both. So if you set rev to a git tag in SRC_URI, you cannot set a git commit hash within SRCREV, thus you lose reproducibility since you are now only referencing a floating rev. See also: https://stackoverflow.com/questions/78127309/how-to-set-srcrev-for-git-tag-in-yocto/78127354#78127354.
So setting the git commit hash in SRC_URI as rev or directly in SRCREV is the way to go.
On 5/6/25 13:10, Jasper Orschulko via lists.openembedded.org wrote: > > And add tag to SRC_URI. > > AFAIK this is not possible / bad practise, unless there were some > recent changes to OE that I am unaware of. There were some recent developments[1] in this front. Now tags and the SRCREV are matched to each other, so you can be sure that the SRCREV is correlated to PV, and they are not randomly set. [1]: e.g. https://git.openembedded.org/bitbake/commit/?id=d591d7633fe8d739ec00395920e44910b0b77e27 > You can either specify "rev" directly in the SRC_URI or SRCREV, not > both. So if you set rev to a git tag in SRC_URI, you cannot set a git > commit hash within SRCREV, thus you lose reproducibility since you are > now only referencing a floating rev. See also: > https://stackoverflow.com/questions/78127309/how-to-set-srcrev-for-git-tag-in-yocto/78127354#78127354. > > So setting the git commit hash in SRC_URI as rev or directly in SRCREV > is the way to go. > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#117344): https://lists.openembedded.org/g/openembedded-devel/message/117344 > Mute This Topic: https://lists.openembedded.org/mt/112537365/6084445 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [skandigraun@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On Tue, May 6, 2025 at 1:10 PM Jasper Orschulko via lists.openembedded.org <jasper=fancydomain.eu@lists.openembedded.org> wrote: > > > And add tag to SRC_URI. > > AFAIK this is not possible / bad practise, unless there were some recent changes to OE that I am unaware of. See https://git.openembedded.org/bitbake/commit/?id=d591d7633fe8d739ec00395920e44910b0b77e27 and various recent commits in oe-core and meta-oe which use both SHA in SRCREV and tag param in SRC_URI. > You can either specify "rev" directly in the SRC_URI or SRCREV, not both. So if you set rev to a git tag in SRC_URI, you cannot set a git commit hash within SRCREV, thus you lose reproducibility since you are now only referencing a floating rev. See also: https://stackoverflow.com/questions/78127309/how-to-set-srcrev-for-git-tag-in-yocto/78127354#78127354. > > So setting the git commit hash in SRC_URI as rev or directly in SRCREV is the way to go. > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#117344): https://lists.openembedded.org/g/openembedded-devel/message/117344 > Mute This Topic: https://lists.openembedded.org/mt/112537365/3617156 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [martin.jansa@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
> -----Original Message----- > From: openembedded-devel@lists.openembedded.org <openembedded- > devel@lists.openembedded.org> On Behalf Of Jasper Orschulko via > lists.openembedded.org > Sent: Tuesday, May 6, 2025 13:10 > To: openembedded-devel@lists.openembedded.org > Subject: Re: [oe] [meta-oe][PATCH] sdbus-c++: Upgrade to 2.1.0 release > > > And add tag to SRC_URI. > > AFAIK this is not possible / bad practise, unless there were some recent changes > to OE that I am unaware of. You can either specify "rev" directly in the SRC_URI or > SRCREV, not both. So if you set rev to a git tag in SRC_URI, you cannot set a git > commit hash within SRCREV, thus you lose reproducibility since you are now only > referencing a floating rev. See also: > https://stackoverflow.com/questions/78127309/how-to-set-srcrev-for-git-tag-in- > yocto/78127354#78127354. > > So setting the git commit hash in SRC_URI as rev or directly in SRCREV is the way > to go. Yes, this feature was introduced less than 2 months ago... https://git.openembedded.org/bitbake/commit/?id=d591d7633fe8d739ec00395920e44910b0b77e27 Quote: This means we can start requiring people to put tags in git SRC_URIs when revisions are used, making review a little easier that it isn't some random revision.
I stand corrected. :) Thanks for the info, I was not aware of this change! A bit OT: https://docs.yoctoproject.org/bitbake/dev/bitbake-user-manual/bitbake-user-manual-fetching.html#git-fetcher-git could use a update then, as it still states: > “tag”: Specifies a tag to use for the checkout. To correctly resolve tags, BitBake must access the network. For that reason, tags are often not used. As far as Git is concerned, the “tag” parameter behaves effectively the same as the “rev” parameter. https://docs.yoctoproject.org/bitbake/dev/bitbake-user-manual/bitbake-user-manual-fetching.html#git-fetcher-git On Tue, May 6, 2025 at 01:17 PM, Gyorgy Sarvari wrote: > > On 5/6/25 13:10, Jasper Orschulko via lists.openembedded.org wrote: > >> >>> And add tag to SRC_URI. >> >> AFAIK this is not possible / bad practise, unless there were some >> recent changes to OE that I am unaware of. > > There were some recent developments[1] in this front. Now tags and the > SRCREV are matched to each other, so you can be sure that the SRCREV is > correlated to PV, and they are not randomly set. > > [1]: e.g. > https://git.openembedded.org/bitbake/commit/?id=d591d7633fe8d739ec00395920e44910b0b77e27 > > > >> You can either specify "rev" directly in the SRC_URI or SRCREV, not >> both. So if you set rev to a git tag in SRC_URI, you cannot set a git >> commit hash within SRCREV, thus you lose reproducibility since you are >> now only referencing a floating rev. See also: >> https://stackoverflow.com/questions/78127309/how-to-set-srcrev-for-git-tag-in-yocto/78127354#78127354 >> . >> >> So setting the git commit hash in SRC_URI as rev or directly in SRCREV >> is the way to go. >> >> >> > >
diff --git a/meta-oe/recipes-core/sdbus-c++/sdbus-c++-tools_2.0.0.bb b/meta-oe/recipes-core/sdbus-c++/sdbus-c++-tools_2.1.0.bb similarity index 88% rename from meta-oe/recipes-core/sdbus-c++/sdbus-c++-tools_2.0.0.bb rename to meta-oe/recipes-core/sdbus-c++/sdbus-c++-tools_2.1.0.bb index af112ced88..10704a6cd3 100644 --- a/meta-oe/recipes-core/sdbus-c++/sdbus-c++-tools_2.0.0.bb +++ b/meta-oe/recipes-core/sdbus-c++/sdbus-c++-tools_2.1.0.bb @@ -8,7 +8,7 @@ inherit cmake DEPENDS += "expat" -SRCREV = "e62472b210d9e7f06a5e611c23471d414c99a99c" +SRCREV = "0261d0ec60b68c1f0a6ec9acf63d1379f7d569f8" SRC_URI = "git://github.com/Kistler-Group/sdbus-cpp.git;protocol=https;branch=master;subpath=tools" S = "${WORKDIR}/tools" diff --git a/meta-oe/recipes-core/sdbus-c++/sdbus-c++_2.0.0.bb b/meta-oe/recipes-core/sdbus-c++/sdbus-c++_2.1.0.bb similarity index 97% rename from meta-oe/recipes-core/sdbus-c++/sdbus-c++_2.0.0.bb rename to meta-oe/recipes-core/sdbus-c++/sdbus-c++_2.1.0.bb index a3e7c9ab54..a81d94d2aa 100644 --- a/meta-oe/recipes-core/sdbus-c++/sdbus-c++_2.0.0.bb +++ b/meta-oe/recipes-core/sdbus-c++/sdbus-c++_2.1.0.bb @@ -17,7 +17,7 @@ PACKAGECONFIG[with-tests] = "-DSDBUSCPP_BUILD_TESTS=ON -DSDBUSCPP_INSTALL_TESTS= DEPENDS += "expat" PV .= "+git" -SRCREV = "e62472b210d9e7f06a5e611c23471d414c99a99c" +SRCREV = "0261d0ec60b68c1f0a6ec9acf63d1379f7d569f8" SRC_URI = "git://github.com/Kistler-Group/sdbus-cpp.git;protocol=https;branch=master \ file://run-ptest"
Signed-off-by: Thomas Noack <thomas.noack@iris-sensing.com> --- .../{sdbus-c++-tools_2.0.0.bb => sdbus-c++-tools_2.1.0.bb} | 2 +- .../sdbus-c++/{sdbus-c++_2.0.0.bb => sdbus-c++_2.1.0.bb} | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) rename meta-oe/recipes-core/sdbus-c++/{sdbus-c++-tools_2.0.0.bb => sdbus-c++-tools_2.1.0.bb} (88%) rename meta-oe/recipes-core/sdbus-c++/{sdbus-c++_2.0.0.bb => sdbus-c++_2.1.0.bb} (97%)