diff mbox series

systemd-systemctl-native: disable meson's auto-features

Message ID 20250423135226.5535-1-twoerner@gmail.com
State New
Headers show
Series systemd-systemctl-native: disable meson's auto-features | expand

Commit Message

Trevor Woerner April 23, 2025, 1:52 p.m. UTC
Disable meson's ability to analyze the entire host's system to determine which
features to enable. Which features are enabled should be limited to the
features that are explicitly enabled, not simply discovered.

Signed-off-by: Trevor Woerner <twoerner@gmail.com>
---
 meta/recipes-core/systemd/systemd-systemctl-native_257.5.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alexander Kanavin April 23, 2025, 3 p.m. UTC | #1
This sounds like something that should be in meson.bbclass, rather
than one specific recipe?

Alex

On Wed, 23 Apr 2025 at 15:52, Trevor Woerner via
lists.openembedded.org <twoerner=gmail.com@lists.openembedded.org>
wrote:
>
> Disable meson's ability to analyze the entire host's system to determine which
> features to enable. Which features are enabled should be limited to the
> features that are explicitly enabled, not simply discovered.
>
> Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> ---
>  meta/recipes-core/systemd/systemd-systemctl-native_257.5.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/systemd/systemd-systemctl-native_257.5.bb b/meta/recipes-core/systemd/systemd-systemctl-native_257.5.bb
> index 041a040a2654..591a1747d63a 100644
> --- a/meta/recipes-core/systemd/systemd-systemctl-native_257.5.bb
> +++ b/meta/recipes-core/systemd/systemd-systemctl-native_257.5.bb
> @@ -8,7 +8,7 @@ inherit pkgconfig meson native
>
>  MESON_TARGET = "systemctl:executable"
>  MESON_INSTALL_TAGS = "systemctl"
> -EXTRA_OEMESON += "-Dlink-systemctl-shared=false"
> +EXTRA_OEMESON += "-Dlink-systemctl-shared=false --auto-features=disabled"
>
>  # Systemctl is supposed to operate on target, but the target sysroot is not
>  # determined at run-time, but rather set during configure
> --
> 2.44.0.501.g19981daefd7c
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#215309): https://lists.openembedded.org/g/openembedded-core/message/215309
> Mute This Topic: https://lists.openembedded.org/mt/112414248/1686489
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Trevor Woerner April 25, 2025, 4:42 p.m. UTC | #2
On Wed 2025-04-23 @ 05:00:42 PM, Alexander Kanavin wrote:
> This sounds like something that should be in meson.bbclass, rather
> than one specific recipe?

As an experiment I moved the --auto-features=disabled flag to the
meson.bbclass. Unsurprisingly when doing a world build of oe-core a bunch of
additional recipes fail. Surprisingly the list is not as long as I would have
thought:
	gconf (+native)
	efivar
	libfm
	consolekit
	cairo (+native)
	pulseaudio

I'm working through the list to discover which features are being
auto-detected rather than explicitly set. For each feature I'm adding a
PACKAGECONFIG, then enabling it by default.

If I can get through the above list successfully then I'll have a v2 to send.
Realistically I should do the same exercise with meta-oe before sending a v2.

> Alex
> 
> On Wed, 23 Apr 2025 at 15:52, Trevor Woerner via
> lists.openembedded.org <twoerner=gmail.com@lists.openembedded.org>
> wrote:
> >
> > Disable meson's ability to analyze the entire host's system to determine which
> > features to enable. Which features are enabled should be limited to the
> > features that are explicitly enabled, not simply discovered.
> >
> > Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> > ---
> >  meta/recipes-core/systemd/systemd-systemctl-native_257.5.bb | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-core/systemd/systemd-systemctl-native_257.5.bb b/meta/recipes-core/systemd/systemd-systemctl-native_257.5.bb
> > index 041a040a2654..591a1747d63a 100644
> > --- a/meta/recipes-core/systemd/systemd-systemctl-native_257.5.bb
> > +++ b/meta/recipes-core/systemd/systemd-systemctl-native_257.5.bb
> > @@ -8,7 +8,7 @@ inherit pkgconfig meson native
> >
> >  MESON_TARGET = "systemctl:executable"
> >  MESON_INSTALL_TAGS = "systemctl"
> > -EXTRA_OEMESON += "-Dlink-systemctl-shared=false"
> > +EXTRA_OEMESON += "-Dlink-systemctl-shared=false --auto-features=disabled"
> >
> >  # Systemctl is supposed to operate on target, but the target sysroot is not
> >  # determined at run-time, but rather set during configure
> > --
> > 2.44.0.501.g19981daefd7c
> >
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#215309): https://lists.openembedded.org/g/openembedded-core/message/215309
> > Mute This Topic: https://lists.openembedded.org/mt/112414248/1686489
> > Group Owner: openembedded-core+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
diff mbox series

Patch

diff --git a/meta/recipes-core/systemd/systemd-systemctl-native_257.5.bb b/meta/recipes-core/systemd/systemd-systemctl-native_257.5.bb
index 041a040a2654..591a1747d63a 100644
--- a/meta/recipes-core/systemd/systemd-systemctl-native_257.5.bb
+++ b/meta/recipes-core/systemd/systemd-systemctl-native_257.5.bb
@@ -8,7 +8,7 @@  inherit pkgconfig meson native
 
 MESON_TARGET = "systemctl:executable"
 MESON_INSTALL_TAGS = "systemctl"
-EXTRA_OEMESON += "-Dlink-systemctl-shared=false"
+EXTRA_OEMESON += "-Dlink-systemctl-shared=false --auto-features=disabled"
 
 # Systemctl is supposed to operate on target, but the target sysroot is not
 # determined at run-time, but rather set during configure