| Message ID | 20250422032816.785-1-liuyd.fnst@fujitsu.com |
|---|---|
| State | Under Review |
| Headers | show |
| Series | [meta-oe] mozjs-128: INSANE_SKIP 32bit-time QA issue | expand |
On 4/22/25 05:28, Yiding Liu (Fujitsu) via lists.openembedded.org wrote: > |WARNING: lib32-mozjs-128-128.5.2-r0 do_package_qa: QA Issue: /usr/lib/libmozjs-128.so uses 32-bit api 'stat64' [32bit-time] > |WARNING: lib32-mozjs-128-128.5.2-r0 do_package_qa: QA Issue: /usr/lib/libmozjs-128.so uses 32-bit api 'fstat64' [32bit-time] > |WARNING: lib32-mozjs-128-128.5.2-r0 do_package_qa: QA Issue: Suppress with INSANE_SKIP = "32bit-time" [32bit-time] > |WARNING: lib32-mozjs-128-128.5.2-r0 do_package_qa: QA Issue: /usr/bin/js128 uses 32-bit api 'stat64' [32bit-time] > |WARNING: lib32-mozjs-128-128.5.2-r0 do_package_qa: QA Issue: /usr/bin/js128 uses 32-bit api 'fstat64' [32bit-time] > |WARNING: lib32-mozjs-128-128.5.2-r0 do_package_qa: QA Issue: Suppress with INSANE_SKIP = "32bit-time" [32bit-time] > > It's a false positive warning that I have checked the compiling log, > "-D_TIME_BITS=64 -D_FILE_OFFSET_BITS=64" are really being passed to compiler > > Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com> > --- > meta-oe/recipes-extended/mozjs/mozjs-128_128.5.2.bb | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/meta-oe/recipes-extended/mozjs/mozjs-128_128.5.2.bb b/meta-oe/recipes-extended/mozjs/mozjs-128_128.5.2.bb > index 4b56a17f84..488bb0eccc 100644 > --- a/meta-oe/recipes-extended/mozjs/mozjs-128_128.5.2.bb > +++ b/meta-oe/recipes-extended/mozjs/mozjs-128_128.5.2.bb > @@ -99,6 +99,7 @@ do_install:append() { > rm -f ${D}${libdir}/libjs_static.ajs > } > > +INSANE_SKIP = "32bit-time" Could you please use "+=" instead of "=", to avoid overwriting possible previous values? Also, the ref docs say that it should be postfixed with packagename for which the reason I'm not sure about... but having it should do no harm. See also https://docs.yoctoproject.org/ref-manual/variables.html#term-INSANE_SKIP > PACKAGE_DEBUG_SPLIT_STYLE = "debug-without-src" > PACKAGES =+ "lib${BPN}" > FILES:lib${BPN} += "${libdir}/lib*" > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#117015): https://lists.openembedded.org/g/openembedded-devel/message/117015 > Mute This Topic: https://lists.openembedded.org/mt/112389114/6084445 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [skandigraun@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
-----邮件原件----- 发件人: Gyorgy Sarvari <skandigraun@gmail.com> 发送时间: 2025年4月22日 16:54 收件人: Liu, Yiding/刘 乙丁 <liuyd.fnst@fujitsu.com>; Khem Raj <raj.khem@gmail.com> 抄送: openembedded-devel@lists.openembedded.org 主题: Re: [oe] [meta-oe] [PATCH] mozjs-128: INSANE_SKIP 32bit-time QA issue On 4/22/25 05:28, Yiding Liu (Fujitsu) via lists.openembedded.org wrote: > |WARNING: lib32-mozjs-128-128.5.2-r0 do_package_qa: QA Issue: > |/usr/lib/libmozjs-128.so uses 32-bit api 'stat64' [32bit-time] > |WARNING: lib32-mozjs-128-128.5.2-r0 do_package_qa: QA Issue: > |/usr/lib/libmozjs-128.so uses 32-bit api 'fstat64' [32bit-time] > |WARNING: lib32-mozjs-128-128.5.2-r0 do_package_qa: QA Issue: Suppress > |with INSANE_SKIP = "32bit-time" [32bit-time] > |WARNING: lib32-mozjs-128-128.5.2-r0 do_package_qa: QA Issue: > |/usr/bin/js128 uses 32-bit api 'stat64' [32bit-time] > |WARNING: lib32-mozjs-128-128.5.2-r0 do_package_qa: QA Issue: > |/usr/bin/js128 uses 32-bit api 'fstat64' [32bit-time] > |WARNING: lib32-mozjs-128-128.5.2-r0 do_package_qa: QA Issue: Suppress > |with INSANE_SKIP = "32bit-time" [32bit-time] > > It's a false positive warning that I have checked the compiling log, > "-D_TIME_BITS=64 -D_FILE_OFFSET_BITS=64" are really being passed to > compiler > > Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com> > --- > meta-oe/recipes-extended/mozjs/mozjs-128_128.5.2.bb | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/meta-oe/recipes-extended/mozjs/mozjs-128_128.5.2.bb > b/meta-oe/recipes-extended/mozjs/mozjs-128_128.5.2.bb > index 4b56a17f84..488bb0eccc 100644 > --- a/meta-oe/recipes-extended/mozjs/mozjs-128_128.5.2.bb > +++ b/meta-oe/recipes-extended/mozjs/mozjs-128_128.5.2.bb > @@ -99,6 +99,7 @@ do_install:append() { > rm -f ${D}${libdir}/libjs_static.ajs } > > +INSANE_SKIP = "32bit-time" >Could you please use "+=" instead of "=", to avoid overwriting possible previous values? Thank you, release refer to v2 patch >Also, the ref docs say that it should be postfixed with packagename for which the reason I'm not sure about... but having it should do no harm. Thank you, but I have tested that INSANE_SKIP:${PN} += "32bit-time" doesn't work Since 32bit-time INSANE_SKIP only can recognize "INSANE_SKIP" not "INSANE_SKIP:" because in poky/meta/classes-global/insane.bbclass 607: allowed = "32bit-time" in (d.getVar('INSANE_SKIP') or '').split() However other INSANE_SKIP can recognize both INSANE_SKIP and INSANE_SKIP: in poky/meta/classes-global/insane.bbclass 1161: skip = set((d.getVar('INSANE_SKIP') or "").split() + 1162: (d.getVar('INSANE_SKIP:' + package) or "").split()) >See also >https://docs.yoctoproject.org/ref-manual/variables.html#term-INSANE_SKIP > PACKAGE_DEBUG_SPLIT_STYLE = "debug-without-src" > PACKAGES =+ "lib${BPN}" > FILES:lib${BPN} += "${libdir}/lib*" > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#117015): > https://lists.openembedded.org/g/openembedded-devel/message/117015 > Mute This Topic: https://lists.openembedded.org/mt/112389114/6084445 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub > [skandigraun@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
diff --git a/meta-oe/recipes-extended/mozjs/mozjs-128_128.5.2.bb b/meta-oe/recipes-extended/mozjs/mozjs-128_128.5.2.bb index 4b56a17f84..488bb0eccc 100644 --- a/meta-oe/recipes-extended/mozjs/mozjs-128_128.5.2.bb +++ b/meta-oe/recipes-extended/mozjs/mozjs-128_128.5.2.bb @@ -99,6 +99,7 @@ do_install:append() { rm -f ${D}${libdir}/libjs_static.ajs } +INSANE_SKIP = "32bit-time" PACKAGE_DEBUG_SPLIT_STYLE = "debug-without-src" PACKAGES =+ "lib${BPN}" FILES:lib${BPN} += "${libdir}/lib*"
|WARNING: lib32-mozjs-128-128.5.2-r0 do_package_qa: QA Issue: /usr/lib/libmozjs-128.so uses 32-bit api 'stat64' [32bit-time] |WARNING: lib32-mozjs-128-128.5.2-r0 do_package_qa: QA Issue: /usr/lib/libmozjs-128.so uses 32-bit api 'fstat64' [32bit-time] |WARNING: lib32-mozjs-128-128.5.2-r0 do_package_qa: QA Issue: Suppress with INSANE_SKIP = "32bit-time" [32bit-time] |WARNING: lib32-mozjs-128-128.5.2-r0 do_package_qa: QA Issue: /usr/bin/js128 uses 32-bit api 'stat64' [32bit-time] |WARNING: lib32-mozjs-128-128.5.2-r0 do_package_qa: QA Issue: /usr/bin/js128 uses 32-bit api 'fstat64' [32bit-time] |WARNING: lib32-mozjs-128-128.5.2-r0 do_package_qa: QA Issue: Suppress with INSANE_SKIP = "32bit-time" [32bit-time] It's a false positive warning that I have checked the compiling log, "-D_TIME_BITS=64 -D_FILE_OFFSET_BITS=64" are really being passed to compiler Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com> --- meta-oe/recipes-extended/mozjs/mozjs-128_128.5.2.bb | 1 + 1 file changed, 1 insertion(+)