diff mbox series

arm/classes: add support to configure fvp-bindir

Message ID PH0PR10MB554502D8256670F2960C0569DEBC2@PH0PR10MB5545.namprd10.prod.outlook.com
State New
Headers show
Series arm/classes: add support to configure fvp-bindir | expand

Commit Message

Mohammed Javith Akthar M April 17, 2025, 9:23 a.m. UTC
Currently, fvp-bindir is configured to use the build path. This commit
allows customization of this path by defining a new variable FVP_BINDIR
in fvpconf. This change enables the runfvp script to execute without
BitBake initialization.

Testing:
- Tested using OpenBMC FVP build.
- Defined FVP_BINDIR variable with a custom path in fvp-config.inc and
observed the changes after the build.

Before changes:
$ jq . ~/openbmc/build/fvp/tmp/deploy/images/fvp/obmc-phosphor-image-fvp.fvpconf | grep
fvp-bindir
  "fvp-bindir": "/home/javith/build/openbmc/build/fvp/tmp/sysroots
-components/x86_64/fvp-base-a-aem-native/usr/bin",

After changes:
$ jq . ~/openbmc/build/fvp/tmp/deploy/images/fvp/obmc-phosphor-image-fvp.fvpconf | grep
fvp-bindir
  "fvp-bindir": "utilities/fvp/usr/bin",

Signed-off-by: Mohammed Javith Akthar M <mohammedjavitham@ami.com>
---
 meta-arm/classes/fvpboot.bbclass | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

Comments

Jon Mason April 19, 2025, 3:15 a.m. UTC | #1
On Thu, 17 Apr 2025 09:23:03 +0000, Mohammed Javith Akthar M wrote:
> Currently, fvp-bindir is configured to use the build path. This commit
> allows customization of this path by defining a new variable FVP_BINDIR
> in fvpconf. This change enables the runfvp script to execute without
> BitBake initialization.
> 
> Testing:
> - Tested using OpenBMC FVP build.
> - Defined FVP_BINDIR variable with a custom path in fvp-config.inc and
> observed the changes after the build.
> 
> [...]

Applied, thanks!

[1/1] arm/classes: add support to configure fvp-bindir
      commit: 42390742b10a62658d7cdd941d7f8f26c185c38a

Best regards,
diff mbox series

Patch

diff --git a/meta-arm/classes/fvpboot.bbclass b/meta-arm/classes/fvpboot.bbclass
index 3d8536fc..e5ffbac6 100644
--- a/meta-arm/classes/fvpboot.bbclass
+++ b/meta-arm/classes/fvpboot.bbclass
@@ -48,7 +48,11 @@  python do_write_fvpboot_conf() {
     provider = d.getVar("FVP_PROVIDER")
     if provider:
         data["provider"] = provider
-        data["fvp-bindir"] = os.path.join(d.getVar("COMPONENTS_DIR"),
+        bindir = d.getVar("FVP_BINDIR")
+        if bindir:
+            data["fvp-bindir"] = bindir
+        else:
+            data["fvp-bindir"] = os.path.join(d.getVar("COMPONENTS_DIR"),
                                             d.getVar("BUILD_ARCH"),
                                             provider,
                                             "usr", "bin")