| Message ID | 20250418014123.3684623-1-raj.khem@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [meta-initramfs] klibc.bbclass: Add spaces around assignment | expand |
On 4/18/25 03:41, Khem Raj via lists.openembedded.org wrote: > +LDFLAGS=" ${TUNE_CCARGS}" > +LDFLAGS[export] = "1" That space is still off by one in the upper line.
On Fri, Apr 18, 2025 at 3:41 AM Khem Raj via lists.openembedded.org <raj.khem=gmail.com@lists.openembedded.org> wrote: > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > --- > meta-initramfs/classes/klibc.bbclass | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/meta-initramfs/classes/klibc.bbclass b/meta-initramfs/classes/klibc.bbclass > index ca50a3d431..935ee10c40 100644 > --- a/meta-initramfs/classes/klibc.bbclass > +++ b/meta-initramfs/classes/klibc.bbclass > @@ -9,8 +9,13 @@ CC:append:armv7ve = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE > CC:append:armv7a = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE_CCARGS_MFLOAT') != '') else ''}" > > # klcc uses own optimizations by default. See klcc(1) man file. > -export CFLAGS="${TUNE_CCARGS} ${DEBUG_PREFIX_MAP}" > -export CPPFLAGS="${TUNE_CCARGS}" > -export LDFLAGS="${TUNE_CCARGS}" > +CFLAGS = "${TUNE_CCARGS} ${DEBUG_PREFIX_MAP}" > +CFLAGS[export] = "1" > + > +CPPFLAGS = "${TUNE_CCARGS}" > +CPPFLAGS[export] = "1" > + > +LDFLAGS=" ${TUNE_CCARGS}" > +LDFLAGS[export] = "1" Why the change in export syntax, is the varflag preferred now?
On 4/18/25 13:30, Martin Jansa via lists.openembedded.org wrote: > On Fri, Apr 18, 2025 at 3:41 AM Khem Raj via lists.openembedded.org > <raj.khem=gmail.com@lists.openembedded.org> wrote: >> Signed-off-by: Khem Raj <raj.khem@gmail.com> >> --- >> meta-initramfs/classes/klibc.bbclass | 11 ++++++++--- >> 1 file changed, 8 insertions(+), 3 deletions(-) >> >> diff --git a/meta-initramfs/classes/klibc.bbclass b/meta-initramfs/classes/klibc.bbclass >> index ca50a3d431..935ee10c40 100644 >> --- a/meta-initramfs/classes/klibc.bbclass >> +++ b/meta-initramfs/classes/klibc.bbclass >> @@ -9,8 +9,13 @@ CC:append:armv7ve = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE >> CC:append:armv7a = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE_CCARGS_MFLOAT') != '') else ''}" >> >> # klcc uses own optimizations by default. See klcc(1) man file. >> -export CFLAGS="${TUNE_CCARGS} ${DEBUG_PREFIX_MAP}" >> -export CPPFLAGS="${TUNE_CCARGS}" >> -export LDFLAGS="${TUNE_CCARGS}" >> +CFLAGS = "${TUNE_CCARGS} ${DEBUG_PREFIX_MAP}" >> +CFLAGS[export] = "1" >> + >> +CPPFLAGS = "${TUNE_CCARGS}" >> +CPPFLAGS[export] = "1" >> + >> +LDFLAGS=" ${TUNE_CCARGS}" >> +LDFLAGS[export] = "1" > Why the change in export syntax, is the varflag preferred now? Meta comment: maybe it should be preferred... It is at least a bit confusing that bitbake's and shell's "export" look and work very very similarly, but one of them complains about not having spaces, and the other complains about having spaces.
On Fri, Apr 18, 2025 at 5:25 AM Gyorgy Sarvari <skandigraun@gmail.com> wrote: > > On 4/18/25 13:30, Martin Jansa via lists.openembedded.org wrote: > > On Fri, Apr 18, 2025 at 3:41 AM Khem Raj via lists.openembedded.org > > <raj.khem=gmail.com@lists.openembedded.org> wrote: > >> Signed-off-by: Khem Raj <raj.khem@gmail.com> > >> --- > >> meta-initramfs/classes/klibc.bbclass | 11 ++++++++--- > >> 1 file changed, 8 insertions(+), 3 deletions(-) > >> > >> diff --git a/meta-initramfs/classes/klibc.bbclass > b/meta-initramfs/classes/klibc.bbclass > >> index ca50a3d431..935ee10c40 100644 > >> --- a/meta-initramfs/classes/klibc.bbclass > >> +++ b/meta-initramfs/classes/klibc.bbclass > >> @@ -9,8 +9,13 @@ CC:append:armv7ve = " ${@' > -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE > >> CC:append:armv7a = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if > (d.getVar('TUNE_CCARGS_MFLOAT') != '') else ''}" > >> > >> # klcc uses own optimizations by default. See klcc(1) man file. > >> -export CFLAGS="${TUNE_CCARGS} ${DEBUG_PREFIX_MAP}" > >> -export CPPFLAGS="${TUNE_CCARGS}" > >> -export LDFLAGS="${TUNE_CCARGS}" > >> +CFLAGS = "${TUNE_CCARGS} ${DEBUG_PREFIX_MAP}" > >> +CFLAGS[export] = "1" > >> + > >> +CPPFLAGS = "${TUNE_CCARGS}" > >> +CPPFLAGS[export] = "1" > >> + > >> +LDFLAGS=" ${TUNE_CCARGS}" > >> +LDFLAGS[export] = "1" > > Why the change in export syntax, is the varflag preferred now? It’s fine either way. I preferred bitbakes way of doing it here for not mixing shell syntax ourside of functions > > Meta comment: maybe it should be preferred... It is at least a bit > confusing that bitbake's and shell's "export" look and work very very > similarly, but one of them complains about not having spaces, and the > other complains about having spaces. >
diff --git a/meta-initramfs/classes/klibc.bbclass b/meta-initramfs/classes/klibc.bbclass index ca50a3d431..935ee10c40 100644 --- a/meta-initramfs/classes/klibc.bbclass +++ b/meta-initramfs/classes/klibc.bbclass @@ -9,8 +9,13 @@ CC:append:armv7ve = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE CC:append:armv7a = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE_CCARGS_MFLOAT') != '') else ''}" # klcc uses own optimizations by default. See klcc(1) man file. -export CFLAGS="${TUNE_CCARGS} ${DEBUG_PREFIX_MAP}" -export CPPFLAGS="${TUNE_CCARGS}" -export LDFLAGS="${TUNE_CCARGS}" +CFLAGS = "${TUNE_CCARGS} ${DEBUG_PREFIX_MAP}" +CFLAGS[export] = "1" + +CPPFLAGS = "${TUNE_CCARGS}" +CPPFLAGS[export] = "1" + +LDFLAGS=" ${TUNE_CCARGS}" +LDFLAGS[export] = "1" OVERRIDES =. "libc-klibc:"
Signed-off-by: Khem Raj <raj.khem@gmail.com> --- meta-initramfs/classes/klibc.bbclass | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)