Message ID | 20250404003320.1703471-1-Randy.MacLeod@windriver.com |
---|---|
State | Under Review |
Headers | show |
Series | [v2] nano: update from 8.3 -> 8.4 | expand |
Hi, > On 4 Apr 2025, at 3:33, Randy MacLeod via lists.openembedded.org <randy.macleod=windriver.com@lists.openembedded.org> wrote: > > From: Randy MacLeod <Randy.MacLeod@windriver.com> > > Release notes: > https://lists.gnu.org/archive/html/info-gnu/2025-04/msg00001.html > > The license file checksum changed because upstream added the line: > SPDX-License-Identifier: BSD-3-Clause > Add OECONF to avoid build-time checks for strcase[str|cmp], both of > which have been in glibc and musl for > 10 years so it's sensible to > default to yes. > > Adjust the patches using devtool and manually munge the Upstream-Status-es. > > Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com> > — The commit message doesn’t fully match the contents, there’s no license file changes nor updated patches. Regards, Anders > .../recipes-support/nano/{nano_8.3.bb => nano_8.4.bb} | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > rename meta-oe/recipes-support/nano/{nano_8.3.bb => nano_8.4.bb} (75%) > > diff --git a/meta-oe/recipes-support/nano/nano_8.3.bb b/meta-oe/recipes-support/nano/nano_8.4.bb > similarity index 75% > rename from meta-oe/recipes-support/nano/nano_8.3.bb > rename to meta-oe/recipes-support/nano/nano_8.4.bb > index d1af89ef8d..1aae49d3b6 100644 > --- a/meta-oe/recipes-support/nano/nano_8.3.bb > +++ b/meta-oe/recipes-support/nano/nano_8.4.bb > @@ -13,10 +13,17 @@ RDEPENDS:${PN} = "ncurses-terminfo-base" > PV_MAJOR = "${@d.getVar('PV').split('.')[0]}" > > SRC_URI = "https://nano-editor.org/dist/v${PV_MAJOR}/nano-${PV}.tar.xz" > -SRC_URI[sha256sum] = "551b717b2e28f7e90f749323686a1b5bbbd84cfa1390604d854a3ca3778f111e" > +SRC_URI[sha256sum] = "5ad29222bbd55624d87ea677928b3106a743114d6c6f9b41f36c97be2a8e628d" > > UPSTREAM_CHECK_URI = "https://ftp.gnu.org/gnu/nano" > > inherit autotools gettext pkgconfig > > +EXTRA_OECONF = " \ > + ac_cv_func_strcasestr=yes \ > + gl_cv_func_strcasecmp_works=yes \ > + ac_cv_func_strcasecmp=yes \ > +" > + > + > PACKAGECONFIG[tiny] = "--enable-tiny," > -- > 2.34.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#116553): https://lists.openembedded.org/g/openembedded-devel/message/116553 > Mute This Topic: https://lists.openembedded.org/mt/112076927/3618057 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [Anders.Montonen@iki.fi] > -=-=-=-=-=-=-=-=-=-=-=- >
On 2025-04-04 6:58 p.m., Anders Montonen wrote: > Hi, > >> On 4 Apr 2025, at 3:33, Randy MacLeod via lists.openembedded.org<randy.macleod=windriver.com@lists.openembedded.org> wrote: >> >> From: Randy MacLeod<Randy.MacLeod@windriver.com> >> >> Release notes: >> https://lists.gnu.org/archive/html/info-gnu/2025-04/msg00001.html >> >> The license file checksum changed because upstream added the line: >> SPDX-License-Identifier: BSD-3-Clause >> Add OECONF to avoid build-time checks for strcase[str|cmp], both of >> which have been in glibc and musl for > 10 years so it's sensible to >> default to yes. >> >> Adjust the patches using devtool and manually munge the Upstream-Status-es. >> >> Signed-off-by: Randy MacLeod<Randy.MacLeod@windriver.com> >> — > The commit message doesn’t fully match the contents, there’s no license file changes nor updated patches. Yikes. I can't possibly have messed up that much, can I? Anyway, I'll check and send a v3. Sorry for the noise, I may eventually learn to double, triple check my work before sending commits in the rush to branching. ../Randy > > Regards, > Anders > >> .../recipes-support/nano/{nano_8.3.bb => nano_8.4.bb} | 9 ++++++++- >> 1 file changed, 8 insertions(+), 1 deletion(-) >> rename meta-oe/recipes-support/nano/{nano_8.3.bb => nano_8.4.bb} (75%) >> >> diff --git a/meta-oe/recipes-support/nano/nano_8.3.bb b/meta-oe/recipes-support/nano/nano_8.4.bb >> similarity index 75% >> rename from meta-oe/recipes-support/nano/nano_8.3.bb >> rename to meta-oe/recipes-support/nano/nano_8.4.bb >> index d1af89ef8d..1aae49d3b6 100644 >> --- a/meta-oe/recipes-support/nano/nano_8.3.bb >> +++ b/meta-oe/recipes-support/nano/nano_8.4.bb >> @@ -13,10 +13,17 @@ RDEPENDS:${PN} = "ncurses-terminfo-base" >> PV_MAJOR ="${@d.getVar('PV').split('.')[0]}" >> >> SRC_URI ="https://nano-editor.org/dist/v${PV_MAJOR}/nano-${PV}.tar.xz" >> -SRC_URI[sha256sum] = "551b717b2e28f7e90f749323686a1b5bbbd84cfa1390604d854a3ca3778f111e" >> +SRC_URI[sha256sum] = "5ad29222bbd55624d87ea677928b3106a743114d6c6f9b41f36c97be2a8e628d" >> >> UPSTREAM_CHECK_URI ="https://ftp.gnu.org/gnu/nano" >> >> inherit autotools gettext pkgconfig >> >> +EXTRA_OECONF = " \ >> + ac_cv_func_strcasestr=yes \ >> + gl_cv_func_strcasecmp_works=yes \ >> + ac_cv_func_strcasecmp=yes \ >> +" >> + >> + >> PACKAGECONFIG[tiny] = "--enable-tiny," >> -- >> 2.34.1 >> >> >> -=-=-=-=-=-=-=-=-=-=-=- >> Links: You receive all messages sent to this group. >> View/Reply Online (#116553):https://lists.openembedded.org/g/openembedded-devel/message/116553 >> Mute This Topic:https://lists.openembedded.org/mt/112076927/3618057 >> Group Owner:openembedded-devel+owner@lists.openembedded.org >> Unsubscribe:https://lists.openembedded.org/g/openembedded-devel/unsub [Anders.Montonen@iki.fi] >> -=-=-=-=-=-=-=-=-=-=-=- >>
On 2025-04-04 8:39 p.m., Randy MacLeod via lists.openembedded.org wrote: > On 2025-04-04 6:58 p.m., Anders Montonen wrote: >> Hi, >> >>> On 4 Apr 2025, at 3:33, Randy MacLeod via lists.openembedded.org<randy.macleod=windriver.com@lists.openembedded.org> wrote: >>> >>> From: Randy MacLeod<Randy.MacLeod@windriver.com> >>> >>> Release notes: >>> https://lists.gnu.org/archive/html/info-gnu/2025-04/msg00001.html >>> >>> The license file checksum changed because upstream added the line: >>> SPDX-License-Identifier: BSD-3-Clause >>> Add OECONF to avoid build-time checks for strcase[str|cmp], both of >>> which have been in glibc and musl for > 10 years so it's sensible to >>> default to yes. >>> >>> Adjust the patches using devtool and manually munge the Upstream-Status-es. >>> >>> Signed-off-by: Randy MacLeod<Randy.MacLeod@windriver.com> >>> — >> The commit message doesn’t fully match the contents, there’s no license file changes nor updated patches. > > > Yikes. I can't possibly have messed up that much, can I? > Anyway, I'll check and send a v3. > > Sorry for the noise, I may eventually learn to double, triple check my > work > before sending commits in the rush to branching. > The bug has been reported to the nano tracker: https://savannah.gnu.org/bugs/?66978 Updating nano isn't that important since the updates are only: • Bracketed pastes over a slow connection are more reliable. • Tabs in an external paste at a prompt are not dropped. • Feedback occurs when the cursor sits on a Byte Order Mark. • The Execute prompt is more forgiving of a typo. and 3 minor (?) bug fixes. I'll wait a bit until upstream straightens things out and issue a new release. ../Randy > ../Randy > > >> Regards, >> Anders >> >>> .../recipes-support/nano/{nano_8.3.bb => nano_8.4.bb} | 9 ++++++++- >>> 1 file changed, 8 insertions(+), 1 deletion(-) >>> rename meta-oe/recipes-support/nano/{nano_8.3.bb => nano_8.4.bb} (75%) >>> >>> diff --git a/meta-oe/recipes-support/nano/nano_8.3.bb b/meta-oe/recipes-support/nano/nano_8.4.bb >>> similarity index 75% >>> rename from meta-oe/recipes-support/nano/nano_8.3.bb >>> rename to meta-oe/recipes-support/nano/nano_8.4.bb >>> index d1af89ef8d..1aae49d3b6 100644 >>> --- a/meta-oe/recipes-support/nano/nano_8.3.bb >>> +++ b/meta-oe/recipes-support/nano/nano_8.4.bb >>> @@ -13,10 +13,17 @@ RDEPENDS:${PN} = "ncurses-terminfo-base" >>> PV_MAJOR ="${@d.getVar('PV').split('.')[0]}" >>> >>> SRC_URI ="https://nano-editor.org/dist/v${PV_MAJOR}/nano-${PV}.tar.xz" >>> -SRC_URI[sha256sum] = "551b717b2e28f7e90f749323686a1b5bbbd84cfa1390604d854a3ca3778f111e" >>> +SRC_URI[sha256sum] = "5ad29222bbd55624d87ea677928b3106a743114d6c6f9b41f36c97be2a8e628d" >>> >>> UPSTREAM_CHECK_URI ="https://ftp.gnu.org/gnu/nano" >>> >>> inherit autotools gettext pkgconfig >>> >>> +EXTRA_OECONF = " \ >>> + ac_cv_func_strcasestr=yes \ >>> + gl_cv_func_strcasecmp_works=yes \ >>> + ac_cv_func_strcasecmp=yes \ >>> +" >>> + >>> + >>> PACKAGECONFIG[tiny] = "--enable-tiny," >>> -- >>> 2.34.1 >>> >>> >>> >>> > > -- > # Randy MacLeod > # Wind River Linux > pLK@tY:ATbOf1"dW > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#116595):https://lists.openembedded.org/g/openembedded-devel/message/116595 > Mute This Topic:https://lists.openembedded.org/mt/112076927/3616765 > Group Owner:openembedded-devel+owner@lists.openembedded.org > Unsubscribe:https://lists.openembedded.org/g/openembedded-devel/unsub [randy.macleod@windriver.com] > -=-=-=-=-=-=-=-=-=-=-=- >
diff --git a/meta-oe/recipes-support/nano/nano_8.3.bb b/meta-oe/recipes-support/nano/nano_8.4.bb similarity index 75% rename from meta-oe/recipes-support/nano/nano_8.3.bb rename to meta-oe/recipes-support/nano/nano_8.4.bb index d1af89ef8d..1aae49d3b6 100644 --- a/meta-oe/recipes-support/nano/nano_8.3.bb +++ b/meta-oe/recipes-support/nano/nano_8.4.bb @@ -13,10 +13,17 @@ RDEPENDS:${PN} = "ncurses-terminfo-base" PV_MAJOR = "${@d.getVar('PV').split('.')[0]}" SRC_URI = "https://nano-editor.org/dist/v${PV_MAJOR}/nano-${PV}.tar.xz" -SRC_URI[sha256sum] = "551b717b2e28f7e90f749323686a1b5bbbd84cfa1390604d854a3ca3778f111e" +SRC_URI[sha256sum] = "5ad29222bbd55624d87ea677928b3106a743114d6c6f9b41f36c97be2a8e628d" UPSTREAM_CHECK_URI = "https://ftp.gnu.org/gnu/nano" inherit autotools gettext pkgconfig +EXTRA_OECONF = " \ + ac_cv_func_strcasestr=yes \ + gl_cv_func_strcasecmp_works=yes \ + ac_cv_func_strcasecmp=yes \ +" + + PACKAGECONFIG[tiny] = "--enable-tiny,"