diff mbox series

[3/4] gnupg: follow odd-even scheme in upstream version checks

Message ID 20250311100500.355914-3-alex.kanavin@gmail.com
State Accepted, archived
Commit 7e505c1506ea6a079b0291f84e4ec6774064ef20
Headers show
Series [1/4] systemd-systemctl-native: correctly set PV | expand

Commit Message

Alexander Kanavin March 11, 2025, 10:04 a.m. UTC
From: Alexander Kanavin <alex@linutronix.de>

Unfortunately this has been overlooked, and resulted in
erroneous updates to testing/development releases.

The check will report an 'unknown' latest version until 2.6.0
is released.

Signed-off-by: Alexander Kanavin <alex@linutronix.de>
---
 meta/recipes-support/gnupg/gnupg_2.5.4.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Marta Rybczynska March 11, 2025, 10:42 a.m. UTC | #1
On Tue, Mar 11, 2025 at 11:05 AM Alexander Kanavin via
lists.openembedded.org <alex.kanavin=gmail.com@lists.openembedded.org>
wrote:

> From: Alexander Kanavin <alex@linutronix.de>
>
> Unfortunately this has been overlooked, and resulted in
> erroneous updates to testing/development releases.
>
> The check will report an 'unknown' latest version until 2.6.0
> is released.
>
> Signed-off-by: Alexander Kanavin <alex@linutronix.de>
> ---
>  meta/recipes-support/gnupg/gnupg_2.5.4.bb | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-support/gnupg/gnupg_2.5.4.bb
> b/meta/recipes-support/gnupg/gnupg_2.5.4.bb
> index e6a7e3fb407..0001631d2c5 100644
> --- a/meta/recipes-support/gnupg/gnupg_2.5.4.bb
> +++ b/meta/recipes-support/gnupg/gnupg_2.5.4.bb
> @@ -11,9 +11,9 @@ LIC_FILES_CHKSUM =
> "file://COPYING;md5=189af8afca6d6075ba6c9e0aa8077626 \
>
>  DEPENDS = "npth libassuan libksba zlib bzip2 readline libgcrypt"
>
> -inherit autotools gettext texinfo pkgconfig
> +inherit autotools gettext texinfo pkgconfig upstream-version-is-even
>
> -UPSTREAM_CHECK_URI = "https://gnupg.org/download/index.html"
> +UPSTREAM_CHECK_URI = "https://gnupg.org/ftp/gcrypt/gnupg/"
>  SRC_URI = "${GNUPG_MIRROR}/${BPN}/${BPN}-${PV}.tar.bz2 \
>             file://0002-use-pkgconfig-instead-of-npth-config.patch \
>
> file://0004-autogen.sh-fix-find-version-for-beta-checking.patch \
>
>
Could you maybe add a comment next to the version hash saying that the
project is using odd/even
convention and that people should only update to stable branches? At least
it might avoid the error
next time.

Kind regards,
Marta
Alexander Kanavin March 11, 2025, 10:49 a.m. UTC | #2
On Tue, 11 Mar 2025 at 11:42, Marta Rybczynska <rybczynska@gmail.com> wrote:

> Could you maybe add a comment next to the version hash saying that the project is using odd/even
> convention and that people should only update to stable branches? At least it might avoid the error
> next time.

This change is not only for version checks, it also affects version
upgrade attempts with devtool or AUH, that from now on would only
consider even versions.

We have many other recipes with this restriction, and generally people
don't attempt to manually update to something else.

Alex
diff mbox series

Patch

diff --git a/meta/recipes-support/gnupg/gnupg_2.5.4.bb b/meta/recipes-support/gnupg/gnupg_2.5.4.bb
index e6a7e3fb407..0001631d2c5 100644
--- a/meta/recipes-support/gnupg/gnupg_2.5.4.bb
+++ b/meta/recipes-support/gnupg/gnupg_2.5.4.bb
@@ -11,9 +11,9 @@  LIC_FILES_CHKSUM = "file://COPYING;md5=189af8afca6d6075ba6c9e0aa8077626 \
 
 DEPENDS = "npth libassuan libksba zlib bzip2 readline libgcrypt"
 
-inherit autotools gettext texinfo pkgconfig
+inherit autotools gettext texinfo pkgconfig upstream-version-is-even
 
-UPSTREAM_CHECK_URI = "https://gnupg.org/download/index.html"
+UPSTREAM_CHECK_URI = "https://gnupg.org/ftp/gcrypt/gnupg/"
 SRC_URI = "${GNUPG_MIRROR}/${BPN}/${BPN}-${PV}.tar.bz2 \
            file://0002-use-pkgconfig-instead-of-npth-config.patch \
            file://0004-autogen.sh-fix-find-version-for-beta-checking.patch \