| Message ID | 20250311070202.229491-1-yi.zhao@windriver.com |
|---|---|
| State | New |
| Headers | show |
| Series | [meta-oe] hiredis: remove runtime dependency on redis | expand |
On 11.03.25 08:02, Yi Zhao via lists.openembedded.org wrote: > Now hiredis can be used not only with Redis, but also with Valkey, an > open source key/value datastore that is fully compatible with Redis. As > Redis changed its license, many users have switched to Valkey. Therefore > remove this specified runtime dependency. > > Signed-off-by: Yi Zhao <yi.zhao@windriver.com> > --- > meta-oe/recipes-extended/hiredis/hiredis_1.2.0.bb | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/meta-oe/recipes-extended/hiredis/hiredis_1.2.0.bb b/meta-oe/recipes-extended/hiredis/hiredis_1.2.0.bb > index d081242736..93273919e5 100644 > --- a/meta-oe/recipes-extended/hiredis/hiredis_1.2.0.bb > +++ b/meta-oe/recipes-extended/hiredis/hiredis_1.2.0.bb > @@ -35,5 +35,4 @@ do_install_ptest() { > > FILES:${PN}-dev += "${datadir}/hiredis_ssl ${prefix}/build" > > -RDEPENDS:${PN} = "redis" > RDEPENDS:${PN}-ptest = "${@bb.utils.contains('PACKAGECONFIG', 'testssl', 'openssl-bin', '', d)}" It still depends on either valkey or redis at runtime, is it not? If yes, wouldn't it be better to set something like 'RPROVIDES = "virtual-redis"' (or something like that) in both valkey and redis recipes, and set that as RDEPENDS here?
On 3/11/25 16:48, Gyorgy Sarvari wrote: > On 11.03.25 08:02, Yi Zhao via lists.openembedded.org wrote: >> Now hiredis can be used not only with Redis, but also with Valkey, an >> open source key/value datastore that is fully compatible with Redis. As >> Redis changed its license, many users have switched to Valkey. Therefore >> remove this specified runtime dependency. >> >> Signed-off-by: Yi Zhao <yi.zhao@windriver.com> >> --- >> meta-oe/recipes-extended/hiredis/hiredis_1.2.0.bb | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/meta-oe/recipes-extended/hiredis/hiredis_1.2.0.bb b/meta-oe/recipes-extended/hiredis/hiredis_1.2.0.bb >> index d081242736..93273919e5 100644 >> --- a/meta-oe/recipes-extended/hiredis/hiredis_1.2.0.bb >> +++ b/meta-oe/recipes-extended/hiredis/hiredis_1.2.0.bb >> @@ -35,5 +35,4 @@ do_install_ptest() { >> >> FILES:${PN}-dev += "${datadir}/hiredis_ssl ${prefix}/build" >> >> -RDEPENDS:${PN} = "redis" >> RDEPENDS:${PN}-ptest = "${@bb.utils.contains('PACKAGECONFIG', 'testssl', 'openssl-bin', '', d)}" > It still depends on either valkey or redis at runtime, is it not? > If yes, wouldn't it be better to set something like 'RPROVIDES = > "virtual-redis"' (or something like that) in both valkey and redis > recipes, and set that as RDEPENDS here? Thanks. I will send V2. //Yi
diff --git a/meta-oe/recipes-extended/hiredis/hiredis_1.2.0.bb b/meta-oe/recipes-extended/hiredis/hiredis_1.2.0.bb index d081242736..93273919e5 100644 --- a/meta-oe/recipes-extended/hiredis/hiredis_1.2.0.bb +++ b/meta-oe/recipes-extended/hiredis/hiredis_1.2.0.bb @@ -35,5 +35,4 @@ do_install_ptest() { FILES:${PN}-dev += "${datadir}/hiredis_ssl ${prefix}/build" -RDEPENDS:${PN} = "redis" RDEPENDS:${PN}-ptest = "${@bb.utils.contains('PACKAGECONFIG', 'testssl', 'openssl-bin', '', d)}"
Now hiredis can be used not only with Redis, but also with Valkey, an open source key/value datastore that is fully compatible with Redis. As Redis changed its license, many users have switched to Valkey. Therefore remove this specified runtime dependency. Signed-off-by: Yi Zhao <yi.zhao@windriver.com> --- meta-oe/recipes-extended/hiredis/hiredis_1.2.0.bb | 1 - 1 file changed, 1 deletion(-)