diff mbox series

dhcpcd: fix for unexpected syscall 135 for 10.1.0 version

Message ID 20250305064101.4065316-1-quic_bpothuno@quicinc.com
State Accepted, archived
Commit 2bb20f49ada56f1c7707565e475051174feba945
Headers show
Series dhcpcd: fix for unexpected syscall 135 for 10.1.0 version | expand

Commit Message

Balaji Pothunoori March 5, 2025, 6:41 a.m. UTC 
Current dhcpcd (version 10.1.0) service crashes on the WiFi (wlan0)
interface with the following error:

"ps_seccomp_violation: unexpected syscall 135"

This update pulls in fix #421 for dhcpcd 10.1.0 to address this issue.

Signed-off-by: Balaji Pothunoori <quic_bpothuno@quicinc.com>
---
 .../dhcpcd/dhcpcd_10.1.0.bb                   |  1 +
 ...llow-the-__NR_rt_sigprocmask-syscall.patch | 30 +++++++++++++++++++
 2 files changed, 31 insertions(+)
 create mode 100644 meta/recipes-connectivity/dhcpcd/files/0001-linux-Allow-the-__NR_rt_sigprocmask-syscall.patch

Comments

Dmitry Baryshkov March 5, 2025, 8:46 a.m. UTC | #1 
On Wed, Mar 05, 2025 at 12:11:01PM +0530, Balaji Pothunoori wrote:
> Current dhcpcd (version 10.1.0) service crashes on the WiFi (wlan0)
> interface with the following error:

There are newer releases, which already have this patch. Any reason for
not upgrading? For example there was an AUH message from March 1st.

> 
> "ps_seccomp_violation: unexpected syscall 135"
> 
> This update pulls in fix #421 for dhcpcd 10.1.0 to address this issue.
> 
> Signed-off-by: Balaji Pothunoori <quic_bpothuno@quicinc.com>
> ---
>  .../dhcpcd/dhcpcd_10.1.0.bb                   |  1 +
>  ...llow-the-__NR_rt_sigprocmask-syscall.patch | 30 +++++++++++++++++++
>  2 files changed, 31 insertions(+)
>  create mode 100644 meta/recipes-connectivity/dhcpcd/files/0001-linux-Allow-the-__NR_rt_sigprocmask-syscall.patch
> 
> diff --git a/meta/recipes-connectivity/dhcpcd/dhcpcd_10.1.0.bb b/meta/recipes-connectivity/dhcpcd/dhcpcd_10.1.0.bb
> index 3f806bb18783..99b72852bf34 100644
> --- a/meta/recipes-connectivity/dhcpcd/dhcpcd_10.1.0.bb
> +++ b/meta/recipes-connectivity/dhcpcd/dhcpcd_10.1.0.bb
> @@ -15,6 +15,7 @@ SRC_URI = "git://github.com/NetworkConfiguration/dhcpcd;protocol=https;branch=ma
>             file://dhcpcd.service \
>             file://dhcpcd@.service \
>             file://0001-dhcpcd.8-Fix-conflict-error-when-enable-multilib.patch \
> +           file://0001-linux-Allow-the-__NR_rt_sigprocmask-syscall.patch \
>             "
>  
>  SRCREV = "57c3506a5622e199cf0e3fc1ef26a71cdedc9521"
> diff --git a/meta/recipes-connectivity/dhcpcd/files/0001-linux-Allow-the-__NR_rt_sigprocmask-syscall.patch b/meta/recipes-connectivity/dhcpcd/files/0001-linux-Allow-the-__NR_rt_sigprocmask-syscall.patch
> new file mode 100644
> index 000000000000..7058330165f3
> --- /dev/null
> +++ b/meta/recipes-connectivity/dhcpcd/files/0001-linux-Allow-the-__NR_rt_sigprocmask-syscall.patch
> @@ -0,0 +1,30 @@
> +From e9e40400003db2e4f12dba85acabbaf2212a520f Mon Sep 17 00:00:00 2001
> +From: Scott Shambarger <devel@shambarger.net>
> +Date: Sat, 7 Dec 2024 16:37:28 +0000
> +Subject: [PATCH] linux: Allow the __NR_rt_sigprocmask syscall
> +
> +Fixes recent glibc changes to getrandom() used by arc4random().
> +Fixes #421.
> +
> +Upstream-Status: Backport
> +See details in https://github.com/NetworkConfiguration/dhcpcd/issues/421

This doesn't follow the established standard. I doubt that it will not
trigger QA error.
Balaji Pothunoori March 5, 2025, 12:08 p.m. UTC | #2 
> -----Original Message-----
> From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Sent: Wednesday, March 5, 2025 2:17 PM
> To: Balaji Pothunoori (QUIC) <quic_bpothuno@quicinc.com>
> Cc: openembedded-core@lists.openembedded.org
> Subject: Re: [PATCH] dhcpcd: fix for unexpected syscall 135 for 10.1.0 version
> 
> On Wed, Mar 05, 2025 at 12:11:01PM +0530, Balaji Pothunoori wrote:
> > Current dhcpcd (version 10.1.0) service crashes on the WiFi (wlan0)
> > interface with the following error:
> 
> There are newer releases, which already have this patch. Any reason for not
> upgrading? For example there was an AUH message from March 1st.

Few patches are applied as OE Specific in https://git.openembedded.org/openembedded-core/tree/meta/recipes-connectivity/dhcpcd/files 
Hence, I can't perform end to end testing for upgrade, So proceeded with patch BACKPORT for 10.1.0 version.

> 
> >
> > "ps_seccomp_violation: unexpected syscall 135"
> >
> > This update pulls in fix #421 for dhcpcd 10.1.0 to address this issue.
> >
> > Signed-off-by: Balaji Pothunoori <quic_bpothuno@quicinc.com>
> > ---
> >  .../dhcpcd/dhcpcd_10.1.0.bb                   |  1 +
> >  ...llow-the-__NR_rt_sigprocmask-syscall.patch | 30
> > +++++++++++++++++++
> >  2 files changed, 31 insertions(+)
> >  create mode 100644
> > meta/recipes-connectivity/dhcpcd/files/0001-linux-Allow-the-__NR_rt_si
> > gprocmask-syscall.patch
> >
> > diff --git a/meta/recipes-connectivity/dhcpcd/dhcpcd_10.1.0.bb
> > b/meta/recipes-connectivity/dhcpcd/dhcpcd_10.1.0.bb
> > index 3f806bb18783..99b72852bf34 100644
> > --- a/meta/recipes-connectivity/dhcpcd/dhcpcd_10.1.0.bb
> > +++ b/meta/recipes-connectivity/dhcpcd/dhcpcd_10.1.0.bb
> > @@ -15,6 +15,7 @@ SRC_URI =
> "git://github.com/NetworkConfiguration/dhcpcd;protocol=https;branch=ma
> >             file://dhcpcd.service \
> >             file://dhcpcd@.service \
> >
> > file://0001-dhcpcd.8-Fix-conflict-error-when-enable-multilib.patch \
> > +
> > + file://0001-linux-Allow-the-__NR_rt_sigprocmask-syscall.patch \
> >             "
> >
> >  SRCREV = "57c3506a5622e199cf0e3fc1ef26a71cdedc9521"
> > diff --git
> > a/meta/recipes-connectivity/dhcpcd/files/0001-linux-Allow-the-__NR_rt_
> > sigprocmask-syscall.patch
> > b/meta/recipes-connectivity/dhcpcd/files/0001-linux-Allow-the-__NR_rt_
> > sigprocmask-syscall.patch
> > new file mode 100644
> > index 000000000000..7058330165f3
> > --- /dev/null
> > +++ b/meta/recipes-connectivity/dhcpcd/files/0001-linux-Allow-the-__NR
> > +++ _rt_sigprocmask-syscall.patch
> > @@ -0,0 +1,30 @@
> > +From e9e40400003db2e4f12dba85acabbaf2212a520f Mon Sep 17
> 00:00:00
> > +2001
> > +From: Scott Shambarger <devel@shambarger.net>
> > +Date: Sat, 7 Dec 2024 16:37:28 +0000
> > +Subject: [PATCH] linux: Allow the __NR_rt_sigprocmask syscall
> > +
> > +Fixes recent glibc changes to getrandom() used by arc4random().
> > +Fixes #421.
> > +
> > +Upstream-Status: Backport
> > +See details in
> > +https://github.com/NetworkConfiguration/dhcpcd/issues/421
> 
> This doesn't follow the established standard. I doubt that it will not trigger QA
> error.

Validated the patch using " patchtest --patch <patch_name>"

> 
> --
> With best wishes
> Dmitry

Regards,
Balaji.
Dmitry Baryshkov March 5, 2025, 10:14 p.m. UTC | #3 
On Wed, Mar 05, 2025 at 12:08:09PM +0000, Balaji Pothunoori (QUIC) wrote:
> > -----Original Message-----
> > From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > Sent: Wednesday, March 5, 2025 2:17 PM
> > To: Balaji Pothunoori (QUIC) <quic_bpothuno@quicinc.com>
> > Cc: openembedded-core@lists.openembedded.org
> > Subject: Re: [PATCH] dhcpcd: fix for unexpected syscall 135 for 10.1.0 version
> > 
> > On Wed, Mar 05, 2025 at 12:11:01PM +0530, Balaji Pothunoori wrote:
> > > Current dhcpcd (version 10.1.0) service crashes on the WiFi (wlan0)
> > > interface with the following error:
> > 
> > There are newer releases, which already have this patch. Any reason for not
> > upgrading? For example there was an AUH message from March 1st.
> 
> Few patches are applied as OE Specific in https://git.openembedded.org/openembedded-core/tree/meta/recipes-connectivity/dhcpcd/files 
> Hence, I can't perform end to end testing for upgrade, So proceeded with patch BACKPORT for 10.1.0 version.

I don't follow this. Surely you can. Upgrade the dhcpcd, refresh the
patches (or just apply the patch from AUH, I hope you've seen it),
verify the end-result, post the upgrade patch.

> 
> > 
> > >
> > > "ps_seccomp_violation: unexpected syscall 135"
> > >
> > > This update pulls in fix #421 for dhcpcd 10.1.0 to address this issue.
> > >
> > > Signed-off-by: Balaji Pothunoori <quic_bpothuno@quicinc.com>
> > > ---
> > >  .../dhcpcd/dhcpcd_10.1.0.bb                   |  1 +
> > >  ...llow-the-__NR_rt_sigprocmask-syscall.patch | 30
> > > +++++++++++++++++++
> > >  2 files changed, 31 insertions(+)
> > >  create mode 100644
> > > meta/recipes-connectivity/dhcpcd/files/0001-linux-Allow-the-__NR_rt_si
> > > gprocmask-syscall.patch
> > >
> > > diff --git a/meta/recipes-connectivity/dhcpcd/dhcpcd_10.1.0.bb
> > > b/meta/recipes-connectivity/dhcpcd/dhcpcd_10.1.0.bb
> > > index 3f806bb18783..99b72852bf34 100644
> > > --- a/meta/recipes-connectivity/dhcpcd/dhcpcd_10.1.0.bb
> > > +++ b/meta/recipes-connectivity/dhcpcd/dhcpcd_10.1.0.bb
> > > @@ -15,6 +15,7 @@ SRC_URI =
> > "git://github.com/NetworkConfiguration/dhcpcd;protocol=https;branch=ma
> > >             file://dhcpcd.service \
> > >             file://dhcpcd@.service \
> > >
> > > file://0001-dhcpcd.8-Fix-conflict-error-when-enable-multilib.patch \
> > > +
> > > + file://0001-linux-Allow-the-__NR_rt_sigprocmask-syscall.patch \
> > >             "
> > >
> > >  SRCREV = "57c3506a5622e199cf0e3fc1ef26a71cdedc9521"
> > > diff --git
> > > a/meta/recipes-connectivity/dhcpcd/files/0001-linux-Allow-the-__NR_rt_
> > > sigprocmask-syscall.patch
> > > b/meta/recipes-connectivity/dhcpcd/files/0001-linux-Allow-the-__NR_rt_
> > > sigprocmask-syscall.patch
> > > new file mode 100644
> > > index 000000000000..7058330165f3
> > > --- /dev/null
> > > +++ b/meta/recipes-connectivity/dhcpcd/files/0001-linux-Allow-the-__NR
> > > +++ _rt_sigprocmask-syscall.patch
> > > @@ -0,0 +1,30 @@
> > > +From e9e40400003db2e4f12dba85acabbaf2212a520f Mon Sep 17
> > 00:00:00
> > > +2001
> > > +From: Scott Shambarger <devel@shambarger.net>
> > > +Date: Sat, 7 Dec 2024 16:37:28 +0000
> > > +Subject: [PATCH] linux: Allow the __NR_rt_sigprocmask syscall
> > > +
> > > +Fixes recent glibc changes to getrandom() used by arc4random().
> > > +Fixes #421.
> > > +
> > > +Upstream-Status: Backport
> > > +See details in
> > > +https://github.com/NetworkConfiguration/dhcpcd/issues/421
> > 
> > This doesn't follow the established standard. I doubt that it will not trigger QA
> > error.
> 
> Validated the patch using " patchtest --patch <patch_name>"

See https://docs.yoctoproject.org/contributor-guide/recipe-style-guide.html#patch-upstream-status

> 
> > 
> > --
> > With best wishes
> > Dmitry
> 
> Regards,
> Balaji.
>
diff mbox series

Patch

diff --git a/meta/recipes-connectivity/dhcpcd/dhcpcd_10.1.0.bb b/meta/recipes-connectivity/dhcpcd/dhcpcd_10.1.0.bb
index 3f806bb18783..99b72852bf34 100644
--- a/meta/recipes-connectivity/dhcpcd/dhcpcd_10.1.0.bb
+++ b/meta/recipes-connectivity/dhcpcd/dhcpcd_10.1.0.bb
@@ -15,6 +15,7 @@  SRC_URI = "git://github.com/NetworkConfiguration/dhcpcd;protocol=https;branch=ma
            file://dhcpcd.service \
            file://dhcpcd@.service \
            file://0001-dhcpcd.8-Fix-conflict-error-when-enable-multilib.patch \
+           file://0001-linux-Allow-the-__NR_rt_sigprocmask-syscall.patch \
            "
 
 SRCREV = "57c3506a5622e199cf0e3fc1ef26a71cdedc9521"
diff --git a/meta/recipes-connectivity/dhcpcd/files/0001-linux-Allow-the-__NR_rt_sigprocmask-syscall.patch b/meta/recipes-connectivity/dhcpcd/files/0001-linux-Allow-the-__NR_rt_sigprocmask-syscall.patch
new file mode 100644
index 000000000000..7058330165f3
--- /dev/null
+++ b/meta/recipes-connectivity/dhcpcd/files/0001-linux-Allow-the-__NR_rt_sigprocmask-syscall.patch
@@ -0,0 +1,30 @@ 
+From e9e40400003db2e4f12dba85acabbaf2212a520f Mon Sep 17 00:00:00 2001
+From: Scott Shambarger <devel@shambarger.net>
+Date: Sat, 7 Dec 2024 16:37:28 +0000
+Subject: [PATCH] linux: Allow the __NR_rt_sigprocmask syscall
+
+Fixes recent glibc changes to getrandom() used by arc4random().
+Fixes #421.
+
+Upstream-Status: Backport
+See details in https://github.com/NetworkConfiguration/dhcpcd/issues/421
+
+Signed-off-by: Scott Shambarger <devel@shambarger.net>
+---
+ src/privsep-linux.c | 3 +++
+ 1 file changed, 3 insertions(+)
+
+diff --git a/src/privsep-linux.c b/src/privsep-linux.c
+index 8357904c9c9a..e3485a2efdfc 100644
+--- a/src/privsep-linux.c
++++ b/src/privsep-linux.c
+@@ -409,6 +409,9 @@ static struct sock_filter ps_seccomp_filter[] = {
+ #ifdef __NR_recvmsg
+ 	SECCOMP_ALLOW(__NR_recvmsg),
+ #endif
++#ifdef __NR_rt_sigprocmask
++	SECCOMP_ALLOW(__NR_rt_sigprocmask),
++#endif
+ #ifdef __NR_rt_sigreturn
+ 	SECCOMP_ALLOW(__NR_rt_sigreturn),
+ #endif