| Message ID | 20250222170033.1061080-1-raj.khem@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [meta-oe] gphoto: Fix the sed expression to remove --sysroot from config.h | expand |
Hi Khem Raj, I want to ask If --sysroot= empty, what does it affect? Does it cause any build/runtime errors? I just want to know to backport your patch to our layers. and do you plan to backport this patch to Scarthgap and Styhead? Thanks.
On Sat, Feb 22, 2025 at 10:30 PM Hieu Van Nguyen via lists.openembedded.org <hieu2.nguyen=lge.com@lists.openembedded.org> wrote: > Hi Khem Raj, > > I want to ask If --sysroot= empty, what does it affect? Does it cause any > build/runtime errors? > Yes it causes errors because it also deletes terminating quote character of BUILD_CC String > I just want to know to backport your patch to our layers. > and do you plan to backport this patch to Scarthgap and Styhead? > I am not planning to but if you need to then test it there and send a backport patch > Thanks. > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#115543): > https://lists.openembedded.org/g/openembedded-devel/message/115543 > Mute This Topic: https://lists.openembedded.org/mt/111328249/1997914 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [ > raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
oh sorry, I understand this patch is to fix your commit before:
https://git.openembedded.org/meta-openembedded/commit/meta-oe/recipes-graphics/gphoto2/gphoto2_2.5.28.bb?id=bdbc71f61a86b598fc72bcc167e6bf1f7cc33b08
I meant do we really need to remove "--sysrooot="? What happens when I remove ${RECIPE_SYSROOT} only?
>
> #define HAVE_CC "...... -Werror=format-security --sysroot="
>
On 23.02.25 10:00, Hieu Van Nguyen via lists.openembedded.org wrote: > oh sorry, I understand this patch is to fix your commit before: > https://git.openembedded.org/meta-openembedded/commit/meta-oe/recipes-graphics/gphoto2/gphoto2_2.5.28.bb?id=bdbc71f61a86b598fc72bcc167e6bf1f7cc33b08 > I meant do we really need to remove "--sysrooot="? What happens when I > remove ${RECIPE_SYSROOT} only? > > #define HAVE_CC "...... -Werror=format-security --sysroot=" > At the first sight it looks like it used only as part of the string output when invoking "gphoto2 -v" - otherwise this macro seems to be unused.
diff --git a/meta-oe/recipes-graphics/gphoto2/gphoto2_2.5.28.bb b/meta-oe/recipes-graphics/gphoto2/gphoto2_2.5.28.bb index c53504378a..6a2f7164b5 100644 --- a/meta-oe/recipes-graphics/gphoto2/gphoto2_2.5.28.bb +++ b/meta-oe/recipes-graphics/gphoto2/gphoto2_2.5.28.bb @@ -20,5 +20,5 @@ EXTRA_OECONF += "--with-jpeg-prefix=${STAGING_INCDIR} \ " do_configure:append() { - sed -i -E 's/--sysroot=[^ "]*([" ])/\1/g' ${B}/config.h + sed -i 's/--sysroot[^ "]*//g' ${B}/config.h }
Signed-off-by: Khem Raj <raj.khem@gmail.com> --- meta-oe/recipes-graphics/gphoto2/gphoto2_2.5.28.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)