diff mbox series

[v12.1,1/5] rpm-sequoia-crypto-policy: New recipe

Message ID 20250213152144.4016665-1-zboszor@gmail.com
State New
Headers show
Series [v12.1,1/5] rpm-sequoia-crypto-policy: New recipe | expand

Commit Message

Böszörményi Zoltán Feb. 13, 2025, 3:21 p.m. UTC
This ships a crypto policy file for rpm-sequoia.

Signed-off-by: Zoltán Böszörményi <zboszor@gmail.com>
---
 meta/conf/distro/include/maintainers.inc      |  1 +
 .../rpm-sequoia-crypto-policy_git.bb          | 38 +++++++++++++++++++
 2 files changed, 39 insertions(+)
 create mode 100644 meta/recipes-devtools/rpm-sequoia/rpm-sequoia-crypto-policy_git.bb

Comments

Ross Burton Feb. 20, 2025, 2:43 p.m. UTC | #1
On 13 Feb 2025, at 15:21, Zoltan Boszormenyi via lists.openembedded.org <zboszor=gmail.com@lists.openembedded.org> wrote:
> +DEPENDS = "coreutils-native openssl-native make-native"
> +
> +inherit allarch python3native

These dependencies seem unexpected, and if they’re needed then they should be explained.

We assume make on the host, so why do you need make-native? If there’s a good reason, please comment why.

Ditto for coreutils-native: presumably there’s a tool that isn’t in HOSTTOOLS?  What tool?

Typically there’s no need to inherit python3native unless you’re also depending on python3-something-native modules, as by definition there’s a capable python interpreter as it’s running bitbake.

Thanks,
Ross
Böszörményi Zoltán Feb. 22, 2025, 7:56 a.m. UTC | #2
2025. 02. 20. 15:43 keltezéssel, Ross Burton írta:
> On 13 Feb 2025, at 15:21, Zoltan Boszormenyi via lists.openembedded.org <zboszor=gmail.com@lists.openembedded.org> wrote:
>> +DEPENDS = "coreutils-native openssl-native make-native"
>> +
>> +inherit allarch python3native
> These dependencies seem unexpected, and if they’re needed then they should be explained.
>
> We assume make on the host, so why do you need make-native? If there’s a good reason, please comment why.
>
> Ditto for coreutils-native: presumably there’s a tool that isn’t in HOSTTOOLS?  What tool?
>
> Typically there’s no need to inherit python3native unless you’re also depending on python3-something-native modules, as by definition there’s a capable python interpreter as it’s running bitbake.

Thanks, I will send a followup patch after testing the dependency changes.

>
> Thanks,
> Ross
diff mbox series

Patch

diff --git a/meta/conf/distro/include/maintainers.inc b/meta/conf/distro/include/maintainers.inc
index bec55a7c1c..648c8fceb8 100644
--- a/meta/conf/distro/include/maintainers.inc
+++ b/meta/conf/distro/include/maintainers.inc
@@ -744,6 +744,7 @@  RECIPE_MAINTAINER:pn-rpcbind = "Hongxu Jia <hongxu.jia@windriver.com>"
 RECIPE_MAINTAINER:pn-rng-tools = "Anuj Mittal <anuj.mittal@intel.com>"
 RECIPE_MAINTAINER:pn-rpcsvc-proto = "Khem Raj <raj.khem@gmail.com>"
 RECIPE_MAINTAINER:pn-rpm = "Robert Yang <liezhi.yang@windriver.com>"
+RECIPE_MAINTAINER:pn-rpm-sequoia-crypto-policy = "Zoltán Böszörményi <zboszor@gmail.com>"
 RECIPE_MAINTAINER:pn-rsync = "Yi Zhao <yi.zhao@windriver.com>"
 RECIPE_MAINTAINER:pn-rt-tests = "Unassigned <unassigned@yoctoproject.org>"
 RECIPE_MAINTAINER:pn-ruby = "Ross Burton <ross.burton@arm.com>"
diff --git a/meta/recipes-devtools/rpm-sequoia/rpm-sequoia-crypto-policy_git.bb b/meta/recipes-devtools/rpm-sequoia/rpm-sequoia-crypto-policy_git.bb
new file mode 100644
index 0000000000..098881e3da
--- /dev/null
+++ b/meta/recipes-devtools/rpm-sequoia/rpm-sequoia-crypto-policy_git.bb
@@ -0,0 +1,38 @@ 
+SUMMARY = "Crypto policy for rpm-sequoia"
+HOMEPAGE = "https://gitlab.com/redhat-crypto/fedora-crypto-policies/"
+
+LICENSE = "LGPL-2.1-or-later"
+
+LIC_FILES_CHKSUM = "file://COPYING.LESSER;md5=a6f89e2100d9b6cdffcea4f398e37343"
+
+DEPENDS = "coreutils-native openssl-native make-native"
+
+inherit allarch python3native
+
+SRC_URI = "git://gitlab.com/redhat-crypto/fedora-crypto-policies.git;protocol=https;branch=master"
+
+SRCREV = "032b418a6db842f0eab330eb5909e4604e888728"
+UPSTREAM_CHECK_COMMITS = "1"
+
+S = "${UNPACKDIR}/git"
+
+do_compile () {
+	# Remove most policy variants, leave DEFAULT.pol
+	# It speeds up the build and we only need DEFAULT/rpm-sequoia.
+	rm -f $(ls -1 policies/*.pol | grep -v DEFAULT.pol) || echo nothing to delete
+
+	# Don't validate openssh policy variants.
+	# Validation may fail and these variants are not needed.
+	export OLD_OPENSSH=1
+
+	make ASCIIDOC=echo XSLTPROC=echo
+}
+
+do_install () {
+	install -d -m755 ${D}${datadir}/crypto-policies/back-ends
+	install -m644 ${S}/output/DEFAULT/rpm-sequoia.txt ${D}${datadir}/crypto-policies/back-ends/rpm-sequoia.config
+}
+
+FILES:${PN} = "${datadir}/crypto-policies/back-ends/*"
+
+BBCLASSEXTEND = "native"