| Message ID | 20250210164649.395225-1-richard.purdie@linuxfoundation.org |
|---|---|
| State | New |
| Headers | show |
| Series | package_ipk: Use preferred for of --force-postinstall | expand |
> Op 10 feb 2025, om 17:46 heeft Richard Purdie via lists.openembedded.org <richard.purdie=linuxfoundation.org@lists.openembedded.org> het volgende geschreven: [OE-core] [PATCH] package_ipk: Use preferred for of --force-postinstall Nitpick: the subject lacks the 'm' in for(m). regards, Koen > > opkg accepts both - and _ in its options but use the help text > preferred format. From https://github.com/yoctoproject/poky/pull/14 > from Philipp-Alexander Blum <blum@gessler.de>. > > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> > --- > meta/classes-global/package_ipk.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/classes-global/package_ipk.bbclass b/meta/classes-global/package_ipk.bbclass > index 209568ae5f1..3e72c4c4941 100644 > --- a/meta/classes-global/package_ipk.bbclass > +++ b/meta/classes-global/package_ipk.bbclass > @@ -17,7 +17,7 @@ PKGWRITEDIRIPK = "${WORKDIR}/deploy-ipks" > # Program to be used to build opkg packages > OPKGBUILDCMD ??= 'opkg-build -Z zstd -a "${ZSTD_DEFAULTS}"' > > -OPKG_ARGS += "--force_postinstall --prefer-arch-to-version" > +OPKG_ARGS += "--force-postinstall --prefer-arch-to-version" > OPKG_ARGS += "${@['', '--no-install-recommends'][d.getVar("NO_RECOMMENDATIONS") == "1"]}" > OPKG_ARGS += "${@['', '--add-exclude ' + ' --add-exclude '.join((d.getVar('PACKAGE_EXCLUDE') or "").split())][(d.getVar("PACKAGE_EXCLUDE") or "").strip() != ""]}" > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#211105): https://lists.openembedded.org/g/openembedded-core/message/211105 > Mute This Topic: https://lists.openembedded.org/mt/111105521/9418801 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [koen.kooi@oss.qualcomm.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On Thu, 2025-02-13 at 14:04 +0100, Koen Kooi wrote: > > > > Op 10 feb 2025, om 17:46 heeft Richard Purdie via lists.openembedded.org <richard.purdie=linuxfoundation.org@lists.openembedded.org> het volgende geschreven: > > [OE-core] [PATCH] package_ipk: Use preferred for of --force-postinstall > > Nitpick: the subject lacks the 'm' in for(m). It was noticed during review/merging so the version in the repo was corrected! I didn't re-send to the list. Cheers, Richard
diff --git a/meta/classes-global/package_ipk.bbclass b/meta/classes-global/package_ipk.bbclass index 209568ae5f1..3e72c4c4941 100644 --- a/meta/classes-global/package_ipk.bbclass +++ b/meta/classes-global/package_ipk.bbclass @@ -17,7 +17,7 @@ PKGWRITEDIRIPK = "${WORKDIR}/deploy-ipks" # Program to be used to build opkg packages OPKGBUILDCMD ??= 'opkg-build -Z zstd -a "${ZSTD_DEFAULTS}"' -OPKG_ARGS += "--force_postinstall --prefer-arch-to-version" +OPKG_ARGS += "--force-postinstall --prefer-arch-to-version" OPKG_ARGS += "${@['', '--no-install-recommends'][d.getVar("NO_RECOMMENDATIONS") == "1"]}" OPKG_ARGS += "${@['', '--add-exclude ' + ' --add-exclude '.join((d.getVar('PACKAGE_EXCLUDE') or "").split())][(d.getVar("PACKAGE_EXCLUDE") or "").strip() != ""]}"
opkg accepts both - and _ in its options but use the help text preferred format. From https://github.com/yoctoproject/poky/pull/14 from Philipp-Alexander Blum <blum@gessler.de>. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> --- meta/classes-global/package_ipk.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)