| Message ID | 20250204135159.1219199-1-mikko.rapeli@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | genericarm64.conf: allow overriding u-boot and qemuboot variables | expand |
Thank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information: --- Testing patch /home/patchtest/share/mboxes/genericarm64.conf-allow-overriding-u-boot-and-qemuboot-variables.patch FAIL: test target mailing list: Series sent to the wrong mailing list or some patches from the series correspond to different mailing lists (test_mbox.TestMbox.test_target_mailing_list) PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence) PASS: test author valid (test_mbox.TestMbox.test_author_valid) PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence) PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags) PASS: test max line length (test_metadata.TestMetadata.test_max_line_length) PASS: test mbox format (test_mbox.TestMbox.test_mbox_format) PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade) PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format) PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length) SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint) SKIP: pretest src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.pretest_src_uri_left_files) SKIP: test CVE check ignore: No modified recipes or older target branch, skipping test (test_metadata.TestMetadata.test_cve_check_ignore) SKIP: test CVE tag format: No new CVE patches introduced (test_patch.TestPatch.test_cve_tag_format) SKIP: test Signed-off-by presence: No new CVE patches introduced (test_patch.TestPatch.test_signed_off_by_presence) SKIP: test Upstream-Status presence: No new CVE patches introduced (test_patch.TestPatch.test_upstream_status_presence_format) SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format) SKIP: test lic files chksum modified not mentioned: No modified recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned) SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence) SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence) SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint) SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head) SKIP: test src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.test_src_uri_left_files) SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence) --- Please address the issues identified and submit a new revision of the patch, or alternatively, reply to this email with an explanation of why the patch should be accepted. If you believe these results are due to an error in patchtest, please submit a bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category under 'Yocto Project Subprojects'). For more information on specific failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank you!
diff --git a/meta-yocto-bsp/conf/machine/genericarm64.conf b/meta-yocto-bsp/conf/machine/genericarm64.conf index b6dfb8042d..f5000402e5 100644 --- a/meta-yocto-bsp/conf/machine/genericarm64.conf +++ b/meta-yocto-bsp/conf/machine/genericarm64.conf @@ -33,31 +33,31 @@ SERIAL_CONSOLES ?= "115200;ttyAMA0 115200;hvc0 115200;ttyS0 115200;ttyS1 115200; # Allow u-boot to be built for use with qemu-system-aarch64. # This u-boot is _not_ suitable for use with real hardware, and the expectation # of this machine is that real hardware comes with the firmware pre-loaded. -UBOOT_MACHINE = "qemu_arm64_defconfig" +UBOOT_MACHINE ?= "qemu_arm64_defconfig" # runqemu configuration to run a genericarm64 image inside a qemu-system-aarch64. You will need # to build u-boot explicitly. IMAGE_CLASSES += "qemuboot" -QB_SYSTEM_NAME = "qemu-system-aarch64" +QB_SYSTEM_NAME ?= "qemu-system-aarch64" # Boot the virtual machine with either an emulated Cortex-A76, or the host if using KVM -QB_MACHINE = "-machine virt" -QB_CPU = "-cpu cortex-a76" -QB_CPU_KVM = "-cpu host -machine gic-version=3" -QB_SMP = "-smp 4" +QB_MACHINE ?= "-machine virt" +QB_CPU ?= "-cpu cortex-a76" +QB_CPU_KVM ?= "-cpu host -machine gic-version=3" +QB_SMP ?= "-smp 4" # Boot into U-Boot and let that scan the disk for the next step, don't pass any kernel or filesystem hints -QB_DEFAULT_BIOS = "u-boot.bin" -QB_DEFAULT_KERNEL = "none" -QB_DEFAULT_FSTYPE = "wic" -QB_FSINFO = "wic:no-kernel-in-fs" +QB_DEFAULT_BIOS ?= "u-boot.bin" +QB_DEFAULT_KERNEL ?= "none" +QB_DEFAULT_FSTYPE ?= "wic" +QB_FSINFO ?= "wic:no-kernel-in-fs" # Mount the wic rootfs as a virtio block device -QB_ROOTFS_OPT = "-drive id=root,file=@ROOTFS@,if=none,format=raw -device virtio-blk-pci,drive=root" +QB_ROOTFS_OPT ?= "-drive id=root,file=@ROOTFS@,if=none,format=raw -device virtio-blk-pci,drive=root" # Virtio graphics -QB_GRAPHICS = "-device virtio-gpu-pci" +QB_GRAPHICS ?= "-device virtio-gpu-pci" # Virtio serial consoles -QB_SERIAL_OPT = "-device virtio-serial-pci -chardev null,id=virtcon -device virtconsole,chardev=virtcon" -QB_TCPSERIAL_OPT = "-device virtio-serial-pci -chardev socket,id=virtcon,port=@PORT@,host=127.0.0.1,nodelay=on -device virtconsole,chardev=virtcon" +QB_SERIAL_OPT ?= "-device virtio-serial-pci -chardev null,id=virtcon -device virtconsole,chardev=virtcon" +QB_TCPSERIAL_OPT ?= "-device virtio-serial-pci -chardev socket,id=virtcon,port=@PORT@,host=127.0.0.1,nodelay=on -device virtconsole,chardev=virtcon" # Virtio networking -QB_TAP_OPT = "-netdev tap,id=net0,ifname=@TAP@,script=no,downscript=no" +QB_TAP_OPT ?= "-netdev tap,id=net0,ifname=@TAP@,script=no,downscript=no" # If we're running testimage then we're in a qemu, so ensure u-boot is build TESTIMAGEDEPENDS:append = " u-boot:do_deploy"
Assignment in machine config can not be overwritten in local.conf because former is evaluated later than latter. Use ?= conditional assignment for u-boot and qemuboot variables so that they can be overwritten in local.conf if a different test setup is wanted for kernel, initrd and rootfs built for genericarm64 machine config. Signed-off-by: Mikko Rapeli <mikko.rapeli@linaro.org> --- meta-yocto-bsp/conf/machine/genericarm64.conf | 30 +++++++++---------- 1 file changed, 15 insertions(+), 15 deletions(-)