| Message ID | 20250203-b4-support-v2-1-848008ad29ea@cherry.de |
|---|---|
| State | New |
| Headers | show |
| Series | add basic b4 config file | expand |
Thank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information: --- Testing patch /home/patchtest/share/mboxes/v2-1-2-add-basic-b4-config-file.patch FAIL: test shortlog format: Commit shortlog (first line of commit message) should follow the format "<target>: <summary>" (test_mbox.TestMbox.test_shortlog_format) PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence) PASS: test author valid (test_mbox.TestMbox.test_author_valid) PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence) PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags) PASS: test max line length (test_metadata.TestMetadata.test_max_line_length) PASS: test mbox format (test_mbox.TestMbox.test_mbox_format) PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade) PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length) PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list) SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint) SKIP: pretest src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.pretest_src_uri_left_files) SKIP: test CVE check ignore: No modified recipes or older target branch, skipping test (test_metadata.TestMetadata.test_cve_check_ignore) SKIP: test CVE tag format: No new CVE patches introduced (test_patch.TestPatch.test_cve_tag_format) SKIP: test Signed-off-by presence: No new CVE patches introduced (test_patch.TestPatch.test_signed_off_by_presence) SKIP: test Upstream-Status presence: No new CVE patches introduced (test_patch.TestPatch.test_upstream_status_presence_format) SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format) SKIP: test lic files chksum modified not mentioned: No modified recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned) SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence) SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence) SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint) SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head) SKIP: test src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.test_src_uri_left_files) SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence) --- Please address the issues identified and submit a new revision of the patch, or alternatively, reply to this email with an explanation of why the patch should be accepted. If you believe these results are due to an error in patchtest, please submit a bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category under 'Yocto Project Subprojects'). For more information on specific failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank you!
Hi all, On 2/3/25 4:17 PM, Quentin Schulz wrote: > From: Quentin Schulz <quentin.schulz@cherry.de> > > b4[1] is a very nice tool for mail-based contribution. A config[2] file > exists to set up a few defaults. We can use it to set the Cc recipients > to always add, in our case the mailing list. > > Because we do not have anything to check for now, disable needs-checking > so patches can be sent without running b4 prep --check. The > mid-term/long-term plan is to use patchtest locally. > > Because we do not have any auto-to-cc support (and the implicit one > using scripts/get_maintainer.pl cannot work for us), also disable > needs-auto-to-cc so patches can be sent without running b4 prep > --auto-to-cc. > > [1] https://pypi.org/project/b4/ > [2] https://b4.docs.kernel.org/en/latest/config.html > > Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de> > --- > .b4-config | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/.b4-config b/.b4-config > new file mode 100644 > index 0000000000000000000000000000000000000000..8ec5ddd91e1da05f27a53ff6f3d7351317461859 > --- /dev/null > +++ b/.b4-config > @@ -0,0 +1,3 @@ > +[b4] > + send-series-cc = openembedded-core@lists.openembedded.org Messed up here and should be send-series-to instead according to our README.md. Same remark applies to all other b4 patches sent to YP/OE. I'll leave a few more days for feedback and send a new version to tackle that oversight. Cheers, Quentin
On Wed, 2025-02-05 at 14:09 +0100, Quentin Schulz via lists.openembedded.org wrote: > Hi all, > > On 2/3/25 4:17 PM, Quentin Schulz wrote: > > From: Quentin Schulz <quentin.schulz@cherry.de> > > > > b4[1] is a very nice tool for mail-based contribution. A config[2] file > > exists to set up a few defaults. We can use it to set the Cc recipients > > to always add, in our case the mailing list. > > > > Because we do not have anything to check for now, disable needs-checking > > so patches can be sent without running b4 prep --check. The > > mid-term/long-term plan is to use patchtest locally. > > > > Because we do not have any auto-to-cc support (and the implicit one > > using scripts/get_maintainer.pl cannot work for us), also disable > > needs-auto-to-cc so patches can be sent without running b4 prep > > --auto-to-cc. > > > > [1] https://pypi.org/project/b4/ > > [2] https://b4.docs.kernel.org/en/latest/config.html > > > > Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de> > > --- > > .b4-config | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/.b4-config b/.b4-config > > new file mode 100644 > > index 0000000000000000000000000000000000000000..8ec5ddd91e1da05f27a53ff6f3d7351317461859 > > --- /dev/null > > +++ b/.b4-config > > @@ -0,0 +1,3 @@ > > +[b4] > > + send-series-cc = openembedded-core@lists.openembedded.org > > Messed up here and should be send-series-to instead according to our > README.md. Same remark applies to all other b4 patches sent to YP/OE. > I'll leave a few more days for feedback and send a new version to tackle > that oversight. I merged the script and was about to look at the config files (which need a little more work by tweaking combo-layer) but I'll hold off given the issue. I think we're ready to merge them... Cheers, Richard
diff --git a/.b4-config b/.b4-config new file mode 100644 index 0000000000000000000000000000000000000000..8ec5ddd91e1da05f27a53ff6f3d7351317461859 --- /dev/null +++ b/.b4-config @@ -0,0 +1,3 @@ +[b4] + send-series-cc = openembedded-core@lists.openembedded.org + prep-pre-flight-checks = disable-needs-auto-to-cc, disable-needs-checking