[v2,2/2] rpm: Re-enable signing

Signed-off-by: Zoltán Böszörményi <zboszor@gmail.com>
---
 meta/lib/oeqa/selftest/cases/signing.py | 1 -
 meta/recipes-devtools/rpm/rpm_4.20.0.bb | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

Thank you for your submission. Patchtest identified one
or more issues with the patch. Please see the log below for
more information:

---
Testing patch /home/patchtest/share/mboxes/v2-2-2-rpm-Re-enable-signing.patch

FAIL: test commit message presence: Please include a commit message on your patch explaining the change (test_mbox.TestMbox.test_commit_message_presence)

PASS: pretest pylint (test_python_pylint.PyLint.pretest_pylint)
PASS: pretest src uri left files (test_metadata.TestMetadata.pretest_src_uri_left_files)
PASS: test CVE check ignore (test_metadata.TestMetadata.test_cve_check_ignore)
PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags)
PASS: test lic files chksum modified not mentioned (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test pylint (test_python_pylint.PyLint.test_pylint)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
PASS: test src uri left files (test_metadata.TestMetadata.test_src_uri_left_files)
PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list)

SKIP: test CVE tag format: No new CVE patches introduced (test_patch.TestPatch.test_cve_tag_format)
SKIP: test Signed-off-by presence: No new CVE patches introduced (test_patch.TestPatch.test_signed_off_by_presence)
SKIP: test Upstream-Status presence: No new CVE patches introduced (test_patch.TestPatch.test_upstream_status_presence_format)
SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence)
SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence)

---

Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this
email with an explanation of why the patch should be accepted. If you
believe these results are due to an error in patchtest, please submit a
bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category
under 'Yocto Project Subprojects'). For more information on specific
failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank
you!

On Wed, 29 Jan 2025 at 11:41, Zoltán Böszörményi <zboszor@gmail.com> wrote:

> -PACKAGECONFIG ??= "archive"
> +PACKAGECONFIG ??= "archive sequoia"

We can't do this. This will add 14 minutes of rust-native to
everyone's builds. Rather you should adjust PACKAGECONFIG for rpm in
the selftest (and your local configuration).

Alex

2025. 01. 29. 12:06 keltezéssel, Alexander Kanavin írta:
> On Wed, 29 Jan 2025 at 11:41, Zoltán Böszörményi <zboszor@gmail.com> wrote:
>
>> -PACKAGECONFIG ??= "archive"
>> +PACKAGECONFIG ??= "archive sequoia"
> We can't do this. This will add 14 minutes of rust-native to
> everyone's builds. Rather you should adjust PACKAGECONFIG for rpm in
> the selftest (and your local configuration).

I'll look at how to customize the configuration in the selftest.

2025. 01. 29. 12:06 keltezéssel, Alexander Kanavin írta:
> On Wed, 29 Jan 2025 at 11:41, Zoltán Böszörményi <zboszor@gmail.com> wrote:
>
>> -PACKAGECONFIG ??= "archive"
>> +PACKAGECONFIG ??= "archive sequoia"
> We can't do this. This will add 14 minutes of rust-native to
> everyone's builds. Rather you should adjust PACKAGECONFIG for rpm in
> the selftest (and your local configuration).

I sent the v3 series with this change, and rpm-sequoia 1.7.0.

I can't run the selftest using my custom distro. It was originally
based on meta-angstrom but over time it deviated too much
from how things are supposed to be with more recent Yocto
versions. Hopefully the test case can be run with the pure Poky.

On Wed, 29 Jan 2025 at 13:52, Böszörményi Zoltán <zboszor@gmail.com> wrote:
> I can't run the selftest using my custom distro. It was originally
> based on meta-angstrom but over time it deviated too much
> from how things are supposed to be with more recent Yocto
> versions. Hopefully the test case can be run with the pure Poky.

You can clone poky master, apply the patches, and run the test in that
setup? If the selftest fails on the autobuilder, you'll have to do it
anyway to reproduce and address the fail.

Alex