diff mbox series

[meta-oe] smarty: update 4.5.5 -> 5.4.2

Message ID 1736911952-10934-1-git-send-email-wangmy@fujitsu.com
State Under Review
Headers show
Series [meta-oe] smarty: update 4.5.5 -> 5.4.2 | expand

Commit Message

Mingyu Wang (Fujitsu) Jan. 15, 2025, 3:32 a.m. UTC
From: Wang Mingyu <wangmy@fujitsu.com>

Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
---
 .../smarty/{smarty_4.5.5.bb => smarty_5.4.2.bb} | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)
 rename meta-oe/recipes-support/smarty/{smarty_4.5.5.bb => smarty_5.4.2.bb} (63%)

Comments

Jörg Sommer Jan. 15, 2025, 6:07 a.m. UTC | #1
wangmy via lists.openembedded.org schrieb am Mi 15. Jan, 11:32 (+0800):
>  S = "${WORKDIR}/git"

Shouldn't this be UNPACKDIR instead of WORKDIR?

S = "${UNPACKDIR}/git"

> +do_compile() {
> +	:
> +}
> +

How about:

do_compile[noexec] = "1"


Regards, Jörg
Jörg Sommer Jan. 15, 2025, 6:11 a.m. UTC | #2
wangmy via lists.openembedded.org schrieb am Mi 15. Jan, 11:32 (+0800):
> -SRC_URI = "git://github.com/smarty-php/smarty.git;protocol=https;branch=support/4"
> -
> -SRCREV = "c4851c12e34ff80073ddeb7d98b059d57dea9de2"
> +SRC_URI = "git://github.com/smarty-php/smarty.git;protocol=https;branch=master"

And could you add BUGTRACKER after HOMEPAGE?

BUGTRACKER = "https://github.com/smarty-php/smarty/issues"


Regards, Jörg
Mingyu Wang (Fujitsu) Jan. 15, 2025, 8:47 a.m. UTC | #3
Sometimes the following errors occur when executing bitbake:

DEBUG: Executing shell function do_compile
NOTE: make -j 4
php ./utilities/make-parser.php src/Parser/TemplateParser.y src/Parser/TemplateParser.php
make: php: No such file or directory
make: *** [Makefile:16: src/Parser/TemplateParser.php] Error 127
ERROR: oe_runmake failed
WARNING: exit code 1 from a shell command.

It seems that this do_compile should not be executed. To avoid this issue, I added an empty do_compile in the bb file

  --
Best Regards
---------------------------------------------------
Wang Mingyu
FUJITSU NANJING SOFTWARE TECHNOLOGY CO., LTD. (FNST)
No.6 Wenzhu Road, Nanjing, 210012, China
TEL:+86+25-86630566--8568
COINS: 79988548
FAX: +86+25-83317685
MAIL: wangmy@fujitsu.com

> -----Original Message-----
> From: Jörg Sommer <joerg.sommer@navimatix.de>
> Sent: Wednesday, January 15, 2025 2:07 PM
> To: Wang, Mingyu/王 鸣瑜 <wangmy@fujitsu.com>
> Cc: openembedded-devel@lists.openembedded.org
> Subject: Re: [oe] [meta-oe] [PATCH] smarty: update 4.5.5 -> 5.4.2
> 
> wangmy via lists.openembedded.org schrieb am Mi 15. Jan, 11:32 (+0800):
> >  S = "${WORKDIR}/git"
> 
> Shouldn't this be UNPACKDIR instead of WORKDIR?
> 
> S = "${UNPACKDIR}/git"
> 
> > +do_compile() {
> > +	:
> > +}
> > +
> 
> How about:
> 
> do_compile[noexec] = "1"
> 
> 
> Regards, Jörg
> 
> --
> Ich halte ihn zwar für einen Schurken und das was er sagt für falsch – aber ich
> bin bereit mein Leben dafür einzusetzen, daß
> er seine Meinung sagen kann.            (Voltaire)
> 
> Navimatix GmbH           T: 03641 - 327 99 0
> Tatzendpromenade 2       F: 03641 - 526 306
> 07745 Jena               www.navimatix.de
> 
> Geschäftsführer: Steffen Späthe, Jan Rommeley
> Registergericht: Amtsgericht Jena, HRB 501480
Jörg Sommer Jan. 15, 2025, 9:50 a.m. UTC | #4
Mingyu Wang (Fujitsu) schrieb am Mi 15. Jan, 08:47 (+0000):
> Sometimes the following errors occur when executing bitbake:
> 
> DEBUG: Executing shell function do_compile
> NOTE: make -j 4
> php ./utilities/make-parser.php src/Parser/TemplateParser.y src/Parser/TemplateParser.php
> make: php: No such file or directory

Does it help to add php-native to DEPENDS?


> make: *** [Makefile:16: src/Parser/TemplateParser.php] Error 127
> ERROR: oe_runmake failed
> WARNING: exit code 1 from a shell command.
> 
> It seems that this do_compile should not be executed. To avoid this issue, I added an empty do_compile in the bb file
> 
>   --
> Best Regards
> ---------------------------------------------------
> Wang Mingyu
> FUJITSU NANJING SOFTWARE TECHNOLOGY CO., LTD. (FNST)
> No.6 Wenzhu Road, Nanjing, 210012, China
> TEL:+86+25-86630566--8568
> COINS: 79988548
> FAX: +86+25-83317685
> MAIL: wangmy@fujitsu.com
> 
> > -----Original Message-----
> > From: Jörg Sommer <joerg.sommer@navimatix.de>
> > Sent: Wednesday, January 15, 2025 2:07 PM
> > To: Wang, Mingyu/王 鸣瑜 <wangmy@fujitsu.com>
> > Cc: openembedded-devel@lists.openembedded.org
> > Subject: Re: [oe] [meta-oe] [PATCH] smarty: update 4.5.5 -> 5.4.2
> > 
> > wangmy via lists.openembedded.org schrieb am Mi 15. Jan, 11:32 (+0800):
> > >  S = "${WORKDIR}/git"
> > 
> > Shouldn't this be UNPACKDIR instead of WORKDIR?
> > 
> > S = "${UNPACKDIR}/git"
> > 
> > > +do_compile() {
> > > +	:
> > > +}
> > > +
> > 
> > How about:
> > 
> > do_compile[noexec] = "1"
> > 
> > 
> > Regards, Jörg
> > 
> > --
> > Ich halte ihn zwar für einen Schurken und das was er sagt für falsch – aber ich
> > bin bereit mein Leben dafür einzusetzen, daß
> > er seine Meinung sagen kann.            (Voltaire)
> > 
> > Navimatix GmbH           T: 03641 - 327 99 0
> > Tatzendpromenade 2       F: 03641 - 526 306
> > 07745 Jena               www.navimatix.de
> > 
> > Geschäftsführer: Steffen Späthe, Jan Rommeley
> > Registergericht: Amtsgericht Jena, HRB 501480
diff mbox series

Patch

diff --git a/meta-oe/recipes-support/smarty/smarty_4.5.5.bb b/meta-oe/recipes-support/smarty/smarty_5.4.2.bb
similarity index 63%
rename from meta-oe/recipes-support/smarty/smarty_4.5.5.bb
rename to meta-oe/recipes-support/smarty/smarty_5.4.2.bb
index e8a63a74a7..906b9e4ee2 100644
--- a/meta-oe/recipes-support/smarty/smarty_4.5.5.bb
+++ b/meta-oe/recipes-support/smarty/smarty_5.4.2.bb
@@ -7,21 +7,22 @@  LIC_FILES_CHKSUM = "file://LICENSE;md5=2c0f216b2120ffc367e20f2b56df51b3"
 
 DEPENDS += "php"
 
-SRC_URI = "git://github.com/smarty-php/smarty.git;protocol=https;branch=support/4"
-
-SRCREV = "c4851c12e34ff80073ddeb7d98b059d57dea9de2"
+SRC_URI = "git://github.com/smarty-php/smarty.git;protocol=https;branch=master"
 
 S = "${WORKDIR}/git"
 
+SRCREV = "642a97adcc2bf6c1b2458d6afeeb36ae001c1c2f"
+
+do_compile() {
+	:
+}
+
 do_install() {
         install -d ${D}${datadir}/php/smarty3/libs/
         install -m 0644 ${S}/libs/*.php ${D}${datadir}/php/smarty3/libs/
 
-        install -d ${D}${datadir}/php/smarty3/libs/plugins
-        install -m 0644 ${S}/libs/plugins/*.php ${D}${datadir}/php/smarty3/libs/plugins/
-
-        install -d ${D}${datadir}/php/smarty3/libs/sysplugins
-        install -m 0644 ${S}/libs/sysplugins/*.php ${D}${datadir}/php/smarty3/libs/sysplugins/
+        install -d ${D}${datadir}/php/smarty3/src/
+        cp -rf ${S}/src/* ${D}${datadir}/php/smarty3/src/
 }
 FILES:${PN} = "${datadir}/php/smarty3/"