diff mbox series

libxkbcommon: remove locale dependecy

Message ID 20241212213429.250224-1-hiagofranco@gmail.com
State New
Headers show
Series libxkbcommon: remove locale dependecy | expand

Commit Message

Hiago De Franco Dec. 12, 2024, 9:34 p.m. UTC 
From: Hiago De Franco <hiago.franco@toradex.com>

The error described does not occur in all cases where libxkbcommon is
used. As example, a Qt application that depends on libxkbcommon might
not require any locales to be installed.

Remove it from RDEPENDS, as libxkbcommon does not seen to have any hard
dependency on libx11-compose-data or libx11-locale. This change can help
save space in the rootfs.

Signed-off-by: Hiago De Franco <hiago.franco@toradex.com>
---
 meta/recipes-graphics/xorg-lib/libxkbcommon_1.7.0.bb | 4 ----
 1 file changed, 4 deletions(-)

Comments

Ross Burton Jan. 13, 2025, 4:45 p.m. UTC | #1 
On 12 Dec 2024, at 21:34, Hiago De Franco via lists.openembedded.org <hiagofranco=gmail.com@lists.openembedded.org> wrote:
> 
> From: Hiago De Franco <hiago.franco@toradex.com>
> 
> The error described does not occur in all cases where libxkbcommon is
> used. As example, a Qt application that depends on libxkbcommon might
> not require any locales to be installed.

This breaks the use of the Compose key, as this needs the data in the locale files.  I suggest making this a recommends instead, which you can then not install.

Ross
Hiago De Franco Jan. 13, 2025, 11:37 p.m. UTC | #2 
On Mon, Jan 13, 2025 at 04:45:38PM +0000, Ross Burton wrote:
> On 12 Dec 2024, at 21:34, Hiago De Franco via lists.openembedded.org <hiagofranco=gmail.com@lists.openembedded.org> wrote:
> > 
> > From: Hiago De Franco <hiago.franco@toradex.com>
> > 
> > The error described does not occur in all cases where libxkbcommon is
> > used. As example, a Qt application that depends on libxkbcommon might
> > not require any locales to be installed.
> 
> This breaks the use of the Compose key, as this needs the data in the locale files.  I suggest making this a recommends instead, which you can then not install.

Sure, I will prepare a v2.

> 
> Ross

Cheers,

Hiago.
diff mbox series

Patch

diff --git a/meta/recipes-graphics/xorg-lib/libxkbcommon_1.7.0.bb b/meta/recipes-graphics/xorg-lib/libxkbcommon_1.7.0.bb
index 40cf616f0bd2..c832dceb09c3 100644
--- a/meta/recipes-graphics/xorg-lib/libxkbcommon_1.7.0.bb
+++ b/meta/recipes-graphics/xorg-lib/libxkbcommon_1.7.0.bb
@@ -31,10 +31,6 @@  python populate_packages:prepend () {
     do_split_packages(d, d.expand('${libdir}'), r'^(lib.*)\.so\.*', '%s', '%s library', extra_depends='', allow_links=True)
 }
 
-# Fix a following runtime error:
-# xkbcommon: ERROR: couldn't find a Compose file for locale "C"
-RDEPENDS:${PN} = "${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'libx11-locale', 'libx11-compose-data', d)}"
-
 BBCLASSEXTEND += "native"
 
 CVE_PRODUCT += "xkbcommon:libxkbcommon"