diff mbox series

[meta-oe,3/5] cpp-netlib: Skip recipe, not buildable with boost >= 1.87

Message ID 20250113044603.3467963-3-raj.khem@gmail.com
State New
Headers show
Series [meta-networking,1/5] vsomeip: Upgrade to 3.5.3 | expand

Commit Message

Khem Raj Jan. 13, 2025, 4:46 a.m. UTC 
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta-oe/recipes-support/cpp-netlib/cpp-netlib_git.bb | 2 ++
 1 file changed, 2 insertions(+)

Comments

Martin Jansa Jan. 13, 2025, 6:59 a.m. UTC | #1 
Hi Khem,

can we use ?= for SKIP_RECIPE? I was asked to do that before, because
it makes it easier to un-skip it locally (hopefully when someone is
preparing the fix for you to merge). e.g.
https://git.openembedded.org/meta-openembedded/commit/?id=96a92761c0a1bb2317fa4ea422c32e4473405103
https://git.openembedded.org/meta-openembedded/commit/?id=d7f5367b53f6fd410e1ebb270f52c2d9f4b3435a

All current SKIP_RECIPE except vlc are using ?=.

Thanks

On Mon, Jan 13, 2025 at 5:46 AM Khem Raj via lists.openembedded.org
<raj.khem=gmail.com@lists.openembedded.org> wrote:
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta-oe/recipes-support/cpp-netlib/cpp-netlib_git.bb | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta-oe/recipes-support/cpp-netlib/cpp-netlib_git.bb b/meta-oe/recipes-support/cpp-netlib/cpp-netlib_git.bb
> index bda5177fc4..3cf166bd4a 100644
> --- a/meta-oe/recipes-support/cpp-netlib/cpp-netlib_git.bb
> +++ b/meta-oe/recipes-support/cpp-netlib/cpp-netlib_git.bb
> @@ -28,3 +28,5 @@ do_install:append() {
>      sed -i -e 's|${RECIPE_SYSROOT}||g' ${D}${libdir}/cmake/cppnetlib/cppnetlibConfig.cmake
>      sed -i -e 's|${RECIPE_SYSROOT}||g' ${D}${libdir}/cmake/cppnetlib/cppnetlibTargets-noconfig.cmake
>  }
> +
> +SKIP_RECIPE[cpp-netlib] = "Does not work with boost >= 1.87"
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#114823): https://lists.openembedded.org/g/openembedded-devel/message/114823
> Mute This Topic: https://lists.openembedded.org/mt/110582198/3617156
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [martin.jansa@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Khem Raj Jan. 13, 2025, 7:28 p.m. UTC | #2 
yeah makes sense. I have fixed it in master-next.

On Sun, Jan 12, 2025 at 10:59 PM Martin Jansa <martin.jansa@gmail.com> wrote:
>
> Hi Khem,
>
> can we use ?= for SKIP_RECIPE? I was asked to do that before, because
> it makes it easier to un-skip it locally (hopefully when someone is
> preparing the fix for you to merge). e.g.
> https://git.openembedded.org/meta-openembedded/commit/?id=96a92761c0a1bb2317fa4ea422c32e4473405103
> https://git.openembedded.org/meta-openembedded/commit/?id=d7f5367b53f6fd410e1ebb270f52c2d9f4b3435a
>
> All current SKIP_RECIPE except vlc are using ?=.
>
> Thanks
>
> On Mon, Jan 13, 2025 at 5:46 AM Khem Raj via lists.openembedded.org
> <raj.khem=gmail.com@lists.openembedded.org> wrote:
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> >  meta-oe/recipes-support/cpp-netlib/cpp-netlib_git.bb | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/meta-oe/recipes-support/cpp-netlib/cpp-netlib_git.bb b/meta-oe/recipes-support/cpp-netlib/cpp-netlib_git.bb
> > index bda5177fc4..3cf166bd4a 100644
> > --- a/meta-oe/recipes-support/cpp-netlib/cpp-netlib_git.bb
> > +++ b/meta-oe/recipes-support/cpp-netlib/cpp-netlib_git.bb
> > @@ -28,3 +28,5 @@ do_install:append() {
> >      sed -i -e 's|${RECIPE_SYSROOT}||g' ${D}${libdir}/cmake/cppnetlib/cppnetlibConfig.cmake
> >      sed -i -e 's|${RECIPE_SYSROOT}||g' ${D}${libdir}/cmake/cppnetlib/cppnetlibTargets-noconfig.cmake
> >  }
> > +
> > +SKIP_RECIPE[cpp-netlib] = "Does not work with boost >= 1.87"
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#114823): https://lists.openembedded.org/g/openembedded-devel/message/114823
> > Mute This Topic: https://lists.openembedded.org/mt/110582198/3617156
> > Group Owner: openembedded-devel+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [martin.jansa@gmail.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
diff mbox series

Patch

diff --git a/meta-oe/recipes-support/cpp-netlib/cpp-netlib_git.bb b/meta-oe/recipes-support/cpp-netlib/cpp-netlib_git.bb
index bda5177fc4..3cf166bd4a 100644
--- a/meta-oe/recipes-support/cpp-netlib/cpp-netlib_git.bb
+++ b/meta-oe/recipes-support/cpp-netlib/cpp-netlib_git.bb
@@ -28,3 +28,5 @@  do_install:append() {
     sed -i -e 's|${RECIPE_SYSROOT}||g' ${D}${libdir}/cmake/cppnetlib/cppnetlibConfig.cmake
     sed -i -e 's|${RECIPE_SYSROOT}||g' ${D}${libdir}/cmake/cppnetlib/cppnetlibTargets-noconfig.cmake
 }
+
+SKIP_RECIPE[cpp-netlib] = "Does not work with boost >= 1.87"