diff mbox series

[v2,1/3] migration-guides: systemd.bbclass do not add Also services for 5.2

Message ID 20250109222015.12658-2-adrian.freihofer@siemens.com
State Superseded
Headers show
Series Cover systemd.bbclass and devtool ide-sdk changes | expand

Commit Message

Adrian Freihofer Jan. 9, 2025, 10:17 p.m. UTC
Covers the chagnes introduced by commit
https://git.yoctoproject.org/poky/commit/?id=efa5f65c2214239ed7aaf7bd8998683e755c5660

Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com>
---
 .../migration-guides/migration-5.2.rst        | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

Comments

Antonin Godard Jan. 10, 2025, 9:23 a.m. UTC | #1
Hi Adrian,

On Thu Jan 9, 2025 at 11:17 PM CET, Adrian Freihofer via lists.yoctoproject.org wrote:
> Covers the chagnes introduced by commit
> https://git.yoctoproject.org/poky/commit/?id=efa5f65c2214239ed7aaf7bd8998683e755c5660
>
> Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com>
> ---
>  .../migration-guides/migration-5.2.rst        | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>
> diff --git a/documentation/migration-guides/migration-5.2.rst b/documentation/migration-guides/migration-5.2.rst
> index cb70e19da..b18ae30d9 100644
> --- a/documentation/migration-guides/migration-5.2.rst
> +++ b/documentation/migration-guides/migration-5.2.rst
> @@ -74,6 +74,25 @@ systemd changes
>     As a consequence, the ``systemd`` recipe no longer contains the ``usrmerge``
>     :term:`PACKAGECONFIG` option as it is now implied by default.
>  
> +-  ``systemd.bbclass``: If a systemd service file had referred to other service
> +   files by starting them as
> +   `Also <https://www.freedesktop.org/software/systemd/man/latest/systemd.unit.html#Also=>`__,
> +   the other service files were automatically added to the :term:`FILES` variable of
> +   the same package. Example: 
> +
> +   a.service contains::
> +
> +      [Install]
> +      Also=b.service
> +
> +   If a.service is packaged in package A, b.service is automatically packaged
> +   into package A as well. This happens even if b.service is explicitly added
> +   to package B using FILES and :term:`SYSTEMD_SERVICE` variables.
> +   This prevents such services from being packaged into different packages.
> +   Therefore, this automatic behavior has been removed for service files (but
> +   not for socket files).
> +   Now all service files must be explicitly added to :term:`FILES`.
> +
>  Recipe changes
>  ~~~~~~~~~~~~~~
>  

Reviewed-by: Antonin Godard <antonin.godard@bootlin.com>

Thank you!
Antonin
Quentin Schulz Jan. 13, 2025, 5:21 p.m. UTC | #2
Hi Adrian,

On 1/9/25 11:17 PM, Adrian Freihofer via lists.yoctoproject.org wrote:
> Covers the chagnes introduced by commit
> https://git.yoctoproject.org/poky/commit/?id=efa5f65c2214239ed7aaf7bd8998683e755c5660
> 
> Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com>
> ---
>   .../migration-guides/migration-5.2.rst        | 19 +++++++++++++++++++
>   1 file changed, 19 insertions(+)
> 
> diff --git a/documentation/migration-guides/migration-5.2.rst b/documentation/migration-guides/migration-5.2.rst
> index cb70e19da..b18ae30d9 100644
> --- a/documentation/migration-guides/migration-5.2.rst
> +++ b/documentation/migration-guides/migration-5.2.rst
> @@ -74,6 +74,25 @@ systemd changes
>      As a consequence, the ``systemd`` recipe no longer contains the ``usrmerge``
>      :term:`PACKAGECONFIG` option as it is now implied by default.
>   
> +-  ``systemd.bbclass``: If a systemd service file had referred to other service

``systemd`` ?

> +   files by starting them as
> +   `Also <https://www.freedesktop.org/software/systemd/man/latest/systemd.unit.html#Also=>`__,
> +   the other service files were automatically added to the :term:`FILES` variable of
> +   the same package. Example:
> +
> +   a.service contains::
> +
> +      [Install]
> +      Also=b.service
> +
> +   If a.service is packaged in package A, b.service is automatically packaged
> +   into package A as well. This happens even if b.service is explicitly added
> +   to package B using FILES and :term:`SYSTEMD_SERVICE` variables.

s/FILES/:term:`FILES`/

For all the above, probably ``a.service``, ``A``, ``b.service``, ``B``, 
for words that aren't English.

Looks good otherwise.

Cheers,
Quentin
diff mbox series

Patch

diff --git a/documentation/migration-guides/migration-5.2.rst b/documentation/migration-guides/migration-5.2.rst
index cb70e19da..b18ae30d9 100644
--- a/documentation/migration-guides/migration-5.2.rst
+++ b/documentation/migration-guides/migration-5.2.rst
@@ -74,6 +74,25 @@  systemd changes
    As a consequence, the ``systemd`` recipe no longer contains the ``usrmerge``
    :term:`PACKAGECONFIG` option as it is now implied by default.
 
+-  ``systemd.bbclass``: If a systemd service file had referred to other service
+   files by starting them as
+   `Also <https://www.freedesktop.org/software/systemd/man/latest/systemd.unit.html#Also=>`__,
+   the other service files were automatically added to the :term:`FILES` variable of
+   the same package. Example: 
+
+   a.service contains::
+
+      [Install]
+      Also=b.service
+
+   If a.service is packaged in package A, b.service is automatically packaged
+   into package A as well. This happens even if b.service is explicitly added
+   to package B using FILES and :term:`SYSTEMD_SERVICE` variables.
+   This prevents such services from being packaged into different packages.
+   Therefore, this automatic behavior has been removed for service files (but
+   not for socket files).
+   Now all service files must be explicitly added to :term:`FILES`.
+
 Recipe changes
 ~~~~~~~~~~~~~~