| Message ID | 20241220171446.2497798-1-raj.khem@gmail.com |
|---|---|
| State | Accepted, archived |
| Commit | a2c5b2cad7857250b4a1b36ba792a8110989733a |
| Headers | show |
| Series | nfs-utils: Use v2 of upstream patch for tpyecast fix | expand |
Thank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information: --- Testing patch /home/patchtest/share/mboxes/nfs-utils-Use-v2-of-upstream-patch-for-tpyecast-fix.patch FAIL: test commit message presence: Please include a commit message on your patch explaining the change (test_mbox.TestMbox.test_commit_message_presence) PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence) PASS: test author valid (test_mbox.TestMbox.test_author_valid) PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags) PASS: test max line length (test_metadata.TestMetadata.test_max_line_length) PASS: test mbox format (test_mbox.TestMbox.test_mbox_format) PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade) PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format) PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length) PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list) SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint) SKIP: pretest src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.pretest_src_uri_left_files) SKIP: test CVE check ignore: No modified recipes or older target branch, skipping test (test_metadata.TestMetadata.test_cve_check_ignore) SKIP: test CVE tag format: No new CVE patches introduced (test_patch.TestPatch.test_cve_tag_format) SKIP: test Signed-off-by presence: No new CVE patches introduced (test_patch.TestPatch.test_signed_off_by_presence) SKIP: test Upstream-Status presence: No new CVE patches introduced (test_patch.TestPatch.test_upstream_status_presence_format) SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format) SKIP: test lic files chksum modified not mentioned: No modified recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned) SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence) SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence) SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint) SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head) SKIP: test src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.test_src_uri_left_files) SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence) --- Please address the issues identified and submit a new revision of the patch, or alternatively, reply to this email with an explanation of why the patch should be accepted. If you believe these results are due to an error in patchtest, please submit a bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category under 'Yocto Project Subprojects'). For more information on specific failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank you!
diff --git a/meta/recipes-connectivity/nfs-utils/nfs-utils/0001-Fix-typecast-warning-with-clang.patch b/meta/recipes-connectivity/nfs-utils/nfs-utils/0001-Fix-typecast-warning-with-clang.patch index 4b38db1f747..f493a3051ef 100644 --- a/meta/recipes-connectivity/nfs-utils/nfs-utils/0001-Fix-typecast-warning-with-clang.patch +++ b/meta/recipes-connectivity/nfs-utils/nfs-utils/0001-Fix-typecast-warning-with-clang.patch @@ -1,29 +1,32 @@ -From bbed752dfad73738baefe518e5959b5c0f038c75 Mon Sep 17 00:00:00 2001 +From 0a64c5ad17786796d84390e480a38b4f762229ae Mon Sep 17 00:00:00 2001 From: Khem Raj <raj.khem@gmail.com> Date: Wed, 18 Dec 2024 19:20:39 -0800 -Subject: [PATCH] Fix typecast warning with clang +Subject: [PATCH v2] Fix typecast warning with clang Fixes file.c:200:8: error: assigning to 'char *' from 'const char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers] -Upstream-Status: Submitted [https://marc.info/?l=linux-nfs&m=173457863307678&w=2] +Upstream-Status: Submitted [https://marc.info/?l=linux-nfs&m=173463533411103&w=2] Signed-off-by: Khem Raj <raj.khem@gmail.com> Cc: Benjamin Coddington <bcodding@redhat.com> Cc: Steve Dickson <steved@redhat.com> --- - support/nsm/file.c | 2 +- - 1 file changed, 1 insertion(+), 1 deletion(-) +v2: Make base as const char pointer insread of trying type punning + + support/nsm/file.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/support/nsm/file.c b/support/nsm/file.c -index de122b0..0fa6164 100644 +index de122b0f..68f99bf0 100644 --- a/support/nsm/file.c +++ b/support/nsm/file.c -@@ -197,7 +197,7 @@ nsm_make_temp_pathname(const char *pathname) - - base = strrchr(pathname, '/'); - if (base == NULL) -- base = pathname; -+ base = (char*)pathname; - else - base++; +@@ -184,7 +184,8 @@ static char * + nsm_make_temp_pathname(const char *pathname) + { + size_t size; +- char *path, *base; ++ char *path; ++ const char *base; + int len; + size = strlen(pathname) + sizeof(".new") + 1;
Signed-off-by: Khem Raj <raj.khem@gmail.com> --- ...0001-Fix-typecast-warning-with-clang.patch | 31 ++++++++++--------- 1 file changed, 17 insertions(+), 14 deletions(-)