diff mbox series

[3/3] oeqa/selftest: Add SPDX 3.0 include source cases for core_image_minimal build

Message ID 20241125081500.4048680-4-hongxu.jia@windriver.com
State New
Headers show
Series SPDX 3.0: Reduce redundant spdxid-hash symlinks to save inode on host | expand

Commit Message

Hongxu Jia Nov. 25, 2024, 8:15 a.m. UTC 
$ oe-selftest -r spdx.SPDX30Check.test_core_image_minimal_include_source
2024-11-09 09:17:54,600 - oe-selftest - INFO - Adding layer libraries:
2024-11-09 09:17:54,601 - oe-selftest - INFO -  path-to/poky/meta/lib
2024-11-09 09:17:54,601 - oe-selftest - INFO -  path-to/poky/meta-yocto-bsp/lib
2024-11-09 09:17:54,601 - oe-selftest - INFO -  path-to/poky/meta-selftest/lib
2024-11-09 09:17:54,601 - oe-selftest - INFO -  path-to/meta-openembedded/meta-oe/lib
2024-11-09 09:17:54,602 - oe-selftest - INFO - Checking base configuration is valid/parsable
2024-11-09 09:17:56,653 - oe-selftest - INFO - Adding: "include selftest.inc" in path-to/build_spdx3-st/conf/local.conf
2024-11-09 09:17:56,653 - oe-selftest - INFO - Adding: "include bblayers.inc" in bblayers.conf
2024-11-09 09:17:56,653 - oe-selftest - INFO - test_core_image_minimal_include_source (spdx.SPDX30Check.test_core_image_minimal_include_source)
2024-11-09 10:41:16,654 - oe-selftest - INFO - Keepalive message
2024-11-09 11:37:53,091 - oe-selftest - INFO -  ... ok
2024-11-09 11:55:18,638 - oe-selftest - INFO - ----------------------------------------------------------------------
2024-11-09 11:55:18,638 - oe-selftest - INFO - Ran 1 test in 9442.187s
2024-11-09 11:55:18,638 - oe-selftest - INFO - OK
2024-11-09 11:55:35,453 - oe-selftest - INFO - RESULTS:
2024-11-09 11:55:35,453 - oe-selftest - INFO - RESULTS - spdx.SPDX30Check.test_core_image_minimal_include_source: PASSED (8396.65s)
2024-11-09 11:55:35,490 - oe-selftest - INFO - SUMMARY:
2024-11-09 11:55:35,490 - oe-selftest - INFO - oe-selftest () - Ran 1 test in 9442.187s
2024-11-09 11:55:35,490 - oe-selftest - INFO - oe-selftest - OK - All required tests passed (successes=1, skipped=0, failures=0, errors=0)

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
 meta/lib/oeqa/selftest/cases/spdx.py | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

Joshua Watt Dec. 4, 2024, 7:24 p.m. UTC | #1 
Is there some advantage to this patch over the test_gcc_include_source test?

On Mon, Nov 25, 2024 at 1:15 AM Hongxu Jia <hongxu.jia@windriver.com> wrote:
>
> $ oe-selftest -r spdx.SPDX30Check.test_core_image_minimal_include_source
> 2024-11-09 09:17:54,600 - oe-selftest - INFO - Adding layer libraries:
> 2024-11-09 09:17:54,601 - oe-selftest - INFO -  path-to/poky/meta/lib
> 2024-11-09 09:17:54,601 - oe-selftest - INFO -  path-to/poky/meta-yocto-bsp/lib
> 2024-11-09 09:17:54,601 - oe-selftest - INFO -  path-to/poky/meta-selftest/lib
> 2024-11-09 09:17:54,601 - oe-selftest - INFO -  path-to/meta-openembedded/meta-oe/lib
> 2024-11-09 09:17:54,602 - oe-selftest - INFO - Checking base configuration is valid/parsable
> 2024-11-09 09:17:56,653 - oe-selftest - INFO - Adding: "include selftest.inc" in path-to/build_spdx3-st/conf/local.conf
> 2024-11-09 09:17:56,653 - oe-selftest - INFO - Adding: "include bblayers.inc" in bblayers.conf
> 2024-11-09 09:17:56,653 - oe-selftest - INFO - test_core_image_minimal_include_source (spdx.SPDX30Check.test_core_image_minimal_include_source)
> 2024-11-09 10:41:16,654 - oe-selftest - INFO - Keepalive message
> 2024-11-09 11:37:53,091 - oe-selftest - INFO -  ... ok
> 2024-11-09 11:55:18,638 - oe-selftest - INFO - ----------------------------------------------------------------------
> 2024-11-09 11:55:18,638 - oe-selftest - INFO - Ran 1 test in 9442.187s
> 2024-11-09 11:55:18,638 - oe-selftest - INFO - OK
> 2024-11-09 11:55:35,453 - oe-selftest - INFO - RESULTS:
> 2024-11-09 11:55:35,453 - oe-selftest - INFO - RESULTS - spdx.SPDX30Check.test_core_image_minimal_include_source: PASSED (8396.65s)
> 2024-11-09 11:55:35,490 - oe-selftest - INFO - SUMMARY:
> 2024-11-09 11:55:35,490 - oe-selftest - INFO - oe-selftest () - Ran 1 test in 9442.187s
> 2024-11-09 11:55:35,490 - oe-selftest - INFO - oe-selftest - OK - All required tests passed (successes=1, skipped=0, failures=0, errors=0)
>
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
>  meta/lib/oeqa/selftest/cases/spdx.py | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/meta/lib/oeqa/selftest/cases/spdx.py b/meta/lib/oeqa/selftest/cases/spdx.py
> index 8384070219..c785f5445f 100644
> --- a/meta/lib/oeqa/selftest/cases/spdx.py
> +++ b/meta/lib/oeqa/selftest/cases/spdx.py
> @@ -174,6 +174,20 @@ class SPDX30Check(SPDX3CheckBase, OESelftestTestCase):
>          # Document should be fully linked
>          self.check_objset_missing_ids(objset)
>
> +    def test_core_image_minimal_include_source(self):
> +        objset = self.check_recipe_spdx(
> +            "core-image-minimal",
> +            "{DEPLOY_DIR_IMAGE}/core-image-minimal-{MACHINE}.rootfs.spdx.json",
> +            extraconf=textwrap.dedent(
> +                """\
> +                SPDX_INCLUDE_SOURCES = "1"
> +                """
> +            ),
> +        )
> +
> +        # Document should be fully linked
> +        self.check_objset_missing_ids(objset)
> +
>      def test_core_image_minimal_sdk(self):
>          objset = self.check_recipe_spdx(
>              "core-image-minimal",
> --
> 2.25.1
>
Hongxu Jia Dec. 11, 2024, 3:04 a.m. UTC | #2 
On 12/5/24 03:24, Joshua Watt wrote:
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and know the content is safe.
>
> Is there some advantage to this patch over the test_gcc_include_source test?

It could check objset missing or not while SPDX_INCLUDE_SOURCES = "1"

//Hongxu

> On Mon, Nov 25, 2024 at 1:15 AM Hongxu Jia<hongxu.jia@windriver.com>  wrote:
>> $ oe-selftest -r spdx.SPDX30Check.test_core_image_minimal_include_source
>> 2024-11-09 09:17:54,600 - oe-selftest - INFO - Adding layer libraries:
>> 2024-11-09 09:17:54,601 - oe-selftest - INFO -  path-to/poky/meta/lib
>> 2024-11-09 09:17:54,601 - oe-selftest - INFO -  path-to/poky/meta-yocto-bsp/lib
>> 2024-11-09 09:17:54,601 - oe-selftest - INFO -  path-to/poky/meta-selftest/lib
>> 2024-11-09 09:17:54,601 - oe-selftest - INFO -  path-to/meta-openembedded/meta-oe/lib
>> 2024-11-09 09:17:54,602 - oe-selftest - INFO - Checking base configuration is valid/parsable
>> 2024-11-09 09:17:56,653 - oe-selftest - INFO - Adding: "include selftest.inc" in path-to/build_spdx3-st/conf/local.conf
>> 2024-11-09 09:17:56,653 - oe-selftest - INFO - Adding: "include bblayers.inc" in bblayers.conf
>> 2024-11-09 09:17:56,653 - oe-selftest - INFO - test_core_image_minimal_include_source (spdx.SPDX30Check.test_core_image_minimal_include_source)
>> 2024-11-09 10:41:16,654 - oe-selftest - INFO - Keepalive message
>> 2024-11-09 11:37:53,091 - oe-selftest - INFO -  ... ok
>> 2024-11-09 11:55:18,638 - oe-selftest - INFO - ----------------------------------------------------------------------
>> 2024-11-09 11:55:18,638 - oe-selftest - INFO - Ran 1 test in 9442.187s
>> 2024-11-09 11:55:18,638 - oe-selftest - INFO - OK
>> 2024-11-09 11:55:35,453 - oe-selftest - INFO - RESULTS:
>> 2024-11-09 11:55:35,453 - oe-selftest - INFO - RESULTS - spdx.SPDX30Check.test_core_image_minimal_include_source: PASSED (8396.65s)
>> 2024-11-09 11:55:35,490 - oe-selftest - INFO - SUMMARY:
>> 2024-11-09 11:55:35,490 - oe-selftest - INFO - oe-selftest () - Ran 1 test in 9442.187s
>> 2024-11-09 11:55:35,490 - oe-selftest - INFO - oe-selftest - OK - All required tests passed (successes=1, skipped=0, failures=0, errors=0)
>>
>> Signed-off-by: Hongxu Jia<hongxu.jia@windriver.com>
>> ---
>>   meta/lib/oeqa/selftest/cases/spdx.py | 14 ++++++++++++++
>>   1 file changed, 14 insertions(+)
>>
>> diff --git a/meta/lib/oeqa/selftest/cases/spdx.py b/meta/lib/oeqa/selftest/cases/spdx.py
>> index 8384070219..c785f5445f 100644
>> --- a/meta/lib/oeqa/selftest/cases/spdx.py
>> +++ b/meta/lib/oeqa/selftest/cases/spdx.py
>> @@ -174,6 +174,20 @@ class SPDX30Check(SPDX3CheckBase, OESelftestTestCase):
>>           # Document should be fully linked
>>           self.check_objset_missing_ids(objset)
>>
>> +    def test_core_image_minimal_include_source(self):
>> +        objset = self.check_recipe_spdx(
>> +            "core-image-minimal",
>> +            "{DEPLOY_DIR_IMAGE}/core-image-minimal-{MACHINE}.rootfs.spdx.json",
>> +            extraconf=textwrap.dedent(
>> +                """\
>> +                SPDX_INCLUDE_SOURCES = "1"
>> +                """
>> +            ),
>> +        )
>> +
>> +        # Document should be fully linked
>> +        self.check_objset_missing_ids(objset)
>> +
>>       def test_core_image_minimal_sdk(self):
>>           objset = self.check_recipe_spdx(
>>               "core-image-minimal",
>> --
>> 2.25.1
>>
diff mbox series

Patch

diff --git a/meta/lib/oeqa/selftest/cases/spdx.py b/meta/lib/oeqa/selftest/cases/spdx.py
index 8384070219..c785f5445f 100644
--- a/meta/lib/oeqa/selftest/cases/spdx.py
+++ b/meta/lib/oeqa/selftest/cases/spdx.py
@@ -174,6 +174,20 @@  class SPDX30Check(SPDX3CheckBase, OESelftestTestCase):
         # Document should be fully linked
         self.check_objset_missing_ids(objset)
 
+    def test_core_image_minimal_include_source(self):
+        objset = self.check_recipe_spdx(
+            "core-image-minimal",
+            "{DEPLOY_DIR_IMAGE}/core-image-minimal-{MACHINE}.rootfs.spdx.json",
+            extraconf=textwrap.dedent(
+                """\
+                SPDX_INCLUDE_SOURCES = "1"
+                """
+            ),
+        )
+
+        # Document should be fully linked
+        self.check_objset_missing_ids(objset)
+
     def test_core_image_minimal_sdk(self):
         objset = self.check_recipe_spdx(
             "core-image-minimal",