| Message ID | 20241206092740.1896316-1-pratheeksha.s.n@ni.com |
|---|---|
| State | New |
| Headers | show |
| Series | opkg-keyrings: mark IPK as allarch | expand |
Thank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information: --- Testing patch /home/patchtest/share/mboxes/opkg-keyrings-mark-IPK-as-allarch.patch FAIL: test Signed-off-by presence: Mbox is missing Signed-off-by. Add it manually or with "git commit --amend -s" (test_mbox.TestMbox.test_signed_off_by_presence) PASS: pretest src uri left files (test_metadata.TestMetadata.pretest_src_uri_left_files) PASS: test CVE check ignore (test_metadata.TestMetadata.test_cve_check_ignore) PASS: test author valid (test_mbox.TestMbox.test_author_valid) PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence) PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags) PASS: test lic files chksum modified not mentioned (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned) PASS: test max line length (test_metadata.TestMetadata.test_max_line_length) PASS: test mbox format (test_mbox.TestMbox.test_mbox_format) PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade) PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format) PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length) PASS: test src uri left files (test_metadata.TestMetadata.test_src_uri_left_files) PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list) SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint) SKIP: test CVE tag format: No new CVE patches introduced (test_patch.TestPatch.test_cve_tag_format) SKIP: test Signed-off-by presence: No new CVE patches introduced (test_patch.TestPatch.test_signed_off_by_presence) SKIP: test Upstream-Status presence: No new CVE patches introduced (test_patch.TestPatch.test_upstream_status_presence_format) SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format) SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence) SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence) SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint) SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head) SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence) --- Please address the issues identified and submit a new revision of the patch, or alternatively, reply to this email with an explanation of why the patch should be accepted. If you believe these results are due to an error in patchtest, please submit a bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category under 'Yocto Project Subprojects'). For more information on specific failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank you!
On Fri, 6 Dec 2024 at 10:27, pratheekshasn via lists.openembedded.org <pratheeksha.s.n=ni.com@lists.openembedded.org> wrote: > > inherit allarch as package contains entirely cross-platform content. > > Signed-off by: Pratheeksha S N <pratheeksha.s.n@ni.com> This is probably handwritten and lacks a hyphen. Use 'git commit -s' to have git insert it for you in the correct format. Alex
RDEPENDS:${PN} = "opkg"
makes it effectively TUNE_PKGARCH unless explicitly removed in
SIGGEN_EXCLUDERECIPES_ABISAFE or SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS
On Fri, Dec 6, 2024 at 10:27 AM pratheekshasn via
lists.openembedded.org <pratheeksha.s.n=ni.com@lists.openembedded.org>
wrote:
>
> inherit allarch as package contains entirely cross-platform content.
>
> Signed-off by: Pratheeksha S N <pratheeksha.s.n@ni.com>
> ---
> meta/recipes-devtools/opkg/opkg-keyrings_1.0.bb | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-devtools/opkg/opkg-keyrings_1.0.bb b/meta/recipes-devtools/opkg/opkg-keyrings_1.0.bb
> index 84aeb98068..75d5b5216c 100644
> --- a/meta/recipes-devtools/opkg/opkg-keyrings_1.0.bb
> +++ b/meta/recipes-devtools/opkg/opkg-keyrings_1.0.bb
> @@ -2,6 +2,8 @@ SUMMARY = "Keyrings for verifying opkg packages and feeds"
> LICENSE = "MIT"
> LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
>
> +inherit allarch
> +
> # Distro-specific keys can be added to this package in two ways:
> #
> # 1) In a .bbappend, add .gpg and/or .asc files to SRC_URI and install them to
> --
> 2.43.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#208408): https://lists.openembedded.org/g/openembedded-core/message/208408
> Mute This Topic: https://lists.openembedded.org/mt/109955189/3617156
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [martin.jansa@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Additionally, when making changes like this, it is useful to run test_sstate_allarch_samesigs from oe-selftest. If that fails, then the package can't be made allarch. Alex On Fri, 6 Dec 2024 at 11:01, Martin Jansa via lists.openembedded.org <martin.jansa=gmail.com@lists.openembedded.org> wrote: > > RDEPENDS:${PN} = "opkg" > > makes it effectively TUNE_PKGARCH unless explicitly removed in > SIGGEN_EXCLUDERECIPES_ABISAFE or SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS > > On Fri, Dec 6, 2024 at 10:27 AM pratheekshasn via > lists.openembedded.org <pratheeksha.s.n=ni.com@lists.openembedded.org> > wrote: > > > > inherit allarch as package contains entirely cross-platform content. > > > > Signed-off by: Pratheeksha S N <pratheeksha.s.n@ni.com> > > --- > > meta/recipes-devtools/opkg/opkg-keyrings_1.0.bb | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/meta/recipes-devtools/opkg/opkg-keyrings_1.0.bb b/meta/recipes-devtools/opkg/opkg-keyrings_1.0.bb > > index 84aeb98068..75d5b5216c 100644 > > --- a/meta/recipes-devtools/opkg/opkg-keyrings_1.0.bb > > +++ b/meta/recipes-devtools/opkg/opkg-keyrings_1.0.bb > > @@ -2,6 +2,8 @@ SUMMARY = "Keyrings for verifying opkg packages and feeds" > > LICENSE = "MIT" > > LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420" > > > > +inherit allarch > > + > > # Distro-specific keys can be added to this package in two ways: > > # > > # 1) In a .bbappend, add .gpg and/or .asc files to SRC_URI and install them to > > -- > > 2.43.0 > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#208413): https://lists.openembedded.org/g/openembedded-core/message/208413 > Mute This Topic: https://lists.openembedded.org/mt/109955189/1686489 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On Fri, 2024-12-06 at 11:10 +0100, Alexander Kanavin via lists.openembedded.org wrote: > Additionally, when making changes like this, it is useful to run > test_sstate_allarch_samesigs from oe-selftest. If that fails, then > the package can't be made allarch. or it would at least need further work as Martin mentions. Cheers, Richard
diff --git a/meta/recipes-devtools/opkg/opkg-keyrings_1.0.bb b/meta/recipes-devtools/opkg/opkg-keyrings_1.0.bb index 84aeb98068..75d5b5216c 100644 --- a/meta/recipes-devtools/opkg/opkg-keyrings_1.0.bb +++ b/meta/recipes-devtools/opkg/opkg-keyrings_1.0.bb @@ -2,6 +2,8 @@ SUMMARY = "Keyrings for verifying opkg packages and feeds" LICENSE = "MIT" LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420" +inherit allarch + # Distro-specific keys can be added to this package in two ways: # # 1) In a .bbappend, add .gpg and/or .asc files to SRC_URI and install them to