diff mbox series

[meta-xfce,2/2] xfce4-settings: ignore some warnings.

Message ID 20241126064854.1685359-2-schonm@gmail.com
State Accepted
Headers show
Series [meta-xfce,1/2] libxfce4ui: Upgrade 4.19.3 -> 4.19.6 | expand

Commit Message

Jason Schonberg Nov. 26, 2024, 6:48 a.m. UTC 
Signed-off-by: Jason Schonberg <schonm@gmail.com>
---
 meta-xfce/recipes-xfce/xfce4-settings/xfce4-settings_4.18.3.bb | 1 +
 1 file changed, 1 insertion(+)

Comments

Khem Raj Nov. 26, 2024, 3:23 p.m. UTC | #1 
On Mon, Nov 25, 2024 at 10:49 PM J. S. via lists.openembedded.org
<schonm=gmail.com@lists.openembedded.org> wrote:
>
> Signed-off-by: Jason Schonberg <schonm@gmail.com>
> ---
>  meta-xfce/recipes-xfce/xfce4-settings/xfce4-settings_4.18.3.bb | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta-xfce/recipes-xfce/xfce4-settings/xfce4-settings_4.18.3.bb b/meta-xfce/recipes-xfce/xfce4-settings/xfce4-settings_4.18.3.bb
> index 7bfcb492f..f9620d85d 100644
> --- a/meta-xfce/recipes-xfce/xfce4-settings/xfce4-settings_4.18.3.bb
> +++ b/meta-xfce/recipes-xfce/xfce4-settings/xfce4-settings_4.18.3.bb
> @@ -11,6 +11,7 @@ REQUIRED_DISTRO_FEATURES = "x11"
>  SRC_URI += "file://0001-xsettings.xml-Set-default-themes.patch"
>  SRC_URI[sha256sum] = "2db9e99be503280739a08779503bdf11db8b9db9851c3a981deb449002f3f1a1"
>
> +CFLAGS += " -Wno-deprecated-declarations -Wno-implicit-function-declaration"

Some context around build failure would be good to document either as
comment or commit msg, that will help in removing
these options in future when code is fixed.

>  EXTRA_OECONF += "--enable-maintainer-mode --disable-debug"
>
>  PACKAGECONFIG ??= " \
> --
> 2.43.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#114059): https://lists.openembedded.org/g/openembedded-devel/message/114059
> Mute This Topic: https://lists.openembedded.org/mt/109786213/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Jason Schonberg Nov. 28, 2024, 3:15 a.m. UTC | #2 
Agreed.

https://patchwork.yoctoproject.org/project/oe/patch/20241127005545.86128-1-schonm@gmail.com/

On Tue, Nov 26, 2024 at 10:23 AM Khem Raj <raj.khem@gmail.com> wrote:
>
> On Mon, Nov 25, 2024 at 10:49 PM J. S. via lists.openembedded.org
> <schonm=gmail.com@lists.openembedded.org> wrote:
> >
> > Signed-off-by: Jason Schonberg <schonm@gmail.com>
> > ---
> >  meta-xfce/recipes-xfce/xfce4-settings/xfce4-settings_4.18.3.bb | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/meta-xfce/recipes-xfce/xfce4-settings/xfce4-settings_4.18.3.bb b/meta-xfce/recipes-xfce/xfce4-settings/xfce4-settings_4.18.3.bb
> > index 7bfcb492f..f9620d85d 100644
> > --- a/meta-xfce/recipes-xfce/xfce4-settings/xfce4-settings_4.18.3.bb
> > +++ b/meta-xfce/recipes-xfce/xfce4-settings/xfce4-settings_4.18.3.bb
> > @@ -11,6 +11,7 @@ REQUIRED_DISTRO_FEATURES = "x11"
> >  SRC_URI += "file://0001-xsettings.xml-Set-default-themes.patch"
> >  SRC_URI[sha256sum] = "2db9e99be503280739a08779503bdf11db8b9db9851c3a981deb449002f3f1a1"
> >
> > +CFLAGS += " -Wno-deprecated-declarations -Wno-implicit-function-declaration"
>
> Some context around build failure would be good to document either as
> comment or commit msg, that will help in removing
> these options in future when code is fixed.
>
> >  EXTRA_OECONF += "--enable-maintainer-mode --disable-debug"
> >
> >  PACKAGECONFIG ??= " \
> > --
> > 2.43.0
> >
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#114059): https://lists.openembedded.org/g/openembedded-devel/message/114059
> > Mute This Topic: https://lists.openembedded.org/mt/109786213/1997914
> > Group Owner: openembedded-devel+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
diff mbox series

Patch

diff --git a/meta-xfce/recipes-xfce/xfce4-settings/xfce4-settings_4.18.3.bb b/meta-xfce/recipes-xfce/xfce4-settings/xfce4-settings_4.18.3.bb
index 7bfcb492f..f9620d85d 100644
--- a/meta-xfce/recipes-xfce/xfce4-settings/xfce4-settings_4.18.3.bb
+++ b/meta-xfce/recipes-xfce/xfce4-settings/xfce4-settings_4.18.3.bb
@@ -11,6 +11,7 @@  REQUIRED_DISTRO_FEATURES = "x11"
 SRC_URI += "file://0001-xsettings.xml-Set-default-themes.patch"
 SRC_URI[sha256sum] = "2db9e99be503280739a08779503bdf11db8b9db9851c3a981deb449002f3f1a1"
 
+CFLAGS += " -Wno-deprecated-declarations -Wno-implicit-function-declaration"
 EXTRA_OECONF += "--enable-maintainer-mode --disable-debug"
 
 PACKAGECONFIG ??= " \