diff mbox series

[kirkstone,1/2] package_rpm: use zstd's default compression level

Message ID 20241121134300.1074541-1-alex.kanavin@gmail.com
State Changes Requested
Delegated to: Steve Sakoman
Headers show
Series [kirkstone,1/2] package_rpm: use zstd's default compression level | expand

Commit Message

Alexander Kanavin Nov. 21, 2024, 1:42 p.m. UTC 
From: Alexander Kanavin <alex@linutronix.de>

zstd uses 3 by default, while 19 is the highest and slowest.
It's not clear why 19 was picked to begin with, possibly
I copy-pasted it from rpm's examples without thinking:
https://git.yoctoproject.org/poky/commit/?h=master-next&id=4a4d5f78a6962dda5f63e9891825c80a8a87bf66

This brings significant speedups in rpm's compression step:
for example compressing webkitgtk takes 11s instead of 36s.

The rpm size increases from 175648k to 234860k. I think it's
a worthy default tradeoff.

Signed-off-by: Alexander Kanavin <alex@linutronix.de>
---
 meta/classes/package_rpm.bbclass | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Steve Sakoman Nov. 22, 2024, 4:24 p.m. UTC | #1 
This is causing breakage on the autobuilder for kirkstone:

https://errors.yoctoproject.org/Errors/Details/822859/

The scarthgap version is fine, haven't tested styhead yet.

Steve

On Thu, Nov 21, 2024 at 5:43 AM Alexander Kanavin via
lists.openembedded.org <alex.kanavin=gmail.com@lists.openembedded.org>
wrote:
>
> From: Alexander Kanavin <alex@linutronix.de>
>
> zstd uses 3 by default, while 19 is the highest and slowest.
> It's not clear why 19 was picked to begin with, possibly
> I copy-pasted it from rpm's examples without thinking:
> https://git.yoctoproject.org/poky/commit/?h=master-next&id=4a4d5f78a6962dda5f63e9891825c80a8a87bf66
>
> This brings significant speedups in rpm's compression step:
> for example compressing webkitgtk takes 11s instead of 36s.
>
> The rpm size increases from 175648k to 234860k. I think it's
> a worthy default tradeoff.
>
> Signed-off-by: Alexander Kanavin <alex@linutronix.de>
> ---
>  meta/classes/package_rpm.bbclass | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/meta/classes/package_rpm.bbclass b/meta/classes/package_rpm.bbclass
> index f403af53439..3541be07aeb 100644
> --- a/meta/classes/package_rpm.bbclass
> +++ b/meta/classes/package_rpm.bbclass
> @@ -2,9 +2,7 @@ inherit package
>
>  IMAGE_PKGTYPE ?= "rpm"
>
> -RPM="rpm"
> -RPMBUILD="rpmbuild"
> -RPMBUILD_COMPMODE ?= "${@'w19T%d.zstdio' % int(d.getVar('ZSTD_THREADS'))}"
> +RPMBUILD_COMPMODE ?= "${@'w3T%d.zstdio' % int(d.getVar('ZSTD_THREADS'))}"
>
>  PKGWRITEDIRRPM = "${WORKDIR}/deploy-rpms"
>
> --
> 2.39.5
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#207535): https://lists.openembedded.org/g/openembedded-core/message/207535
> Mute This Topic: https://lists.openembedded.org/mt/109703382/3620601
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [steve@sakoman.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Alexander Kanavin Nov. 23, 2024, 10:14 a.m. UTC | #2 
On Fri, 22 Nov 2024 at 17:24, Steve Sakoman <steve@sakoman.com> wrote:
>
> This is causing breakage on the autobuilder for kirkstone:
>
> https://errors.yoctoproject.org/Errors/Details/822859/

Thanks, I sent a corrected v2 just now.

Alex
diff mbox series

Patch

diff --git a/meta/classes/package_rpm.bbclass b/meta/classes/package_rpm.bbclass
index f403af53439..3541be07aeb 100644
--- a/meta/classes/package_rpm.bbclass
+++ b/meta/classes/package_rpm.bbclass
@@ -2,9 +2,7 @@  inherit package
 
 IMAGE_PKGTYPE ?= "rpm"
 
-RPM="rpm"
-RPMBUILD="rpmbuild"
-RPMBUILD_COMPMODE ?= "${@'w19T%d.zstdio' % int(d.getVar('ZSTD_THREADS'))}"
+RPMBUILD_COMPMODE ?= "${@'w3T%d.zstdio' % int(d.getVar('ZSTD_THREADS'))}"
 
 PKGWRITEDIRRPM = "${WORKDIR}/deploy-rpms"