| Message ID | 20241122110448.2060-1-f_l_k@t-online.de |
|---|---|
| State | New |
| Headers | show |
| Series | [PATCHv2] libsecret: add pam support depending on DISTRO_FEATURE | expand |
Thank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information: --- Testing patch /home/patchtest/share/mboxes/PATCHv2-libsecret-add-pam-support-depending-on-DISTRO_FEATURE.patch FAIL: test commit message presence: Please include a commit message on your patch explaining the change (test_mbox.TestMbox.test_commit_message_presence) PASS: pretest src uri left files (test_metadata.TestMetadata.pretest_src_uri_left_files) PASS: test CVE check ignore (test_metadata.TestMetadata.test_cve_check_ignore) PASS: test CVE tag format (test_patch.TestPatch.test_cve_tag_format) PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence) PASS: test Signed-off-by presence (test_patch.TestPatch.test_signed_off_by_presence) PASS: test Upstream-Status presence (test_patch.TestPatch.test_upstream_status_presence_format) PASS: test author valid (test_mbox.TestMbox.test_author_valid) PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags) PASS: test lic files chksum modified not mentioned (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned) PASS: test max line length (test_metadata.TestMetadata.test_max_line_length) PASS: test mbox format (test_mbox.TestMbox.test_mbox_format) PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade) PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format) PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length) PASS: test src uri left files (test_metadata.TestMetadata.test_src_uri_left_files) PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list) SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint) SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format) SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence) SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence) SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint) SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head) SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence) --- Please address the issues identified and submit a new revision of the patch, or alternatively, reply to this email with an explanation of why the patch should be accepted. If you believe these results are due to an error in patchtest, please submit a bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category under 'Yocto Project Subprojects'). For more information on specific failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank you!
diff --git a/meta/recipes-gnome/libsecret/libsecret/0001-pam-disable-tests.patch b/meta/recipes-gnome/libsecret/libsecret/0001-pam-disable-tests.patch new file mode 100644 index 0000000000..b7ef6662bc --- /dev/null +++ b/meta/recipes-gnome/libsecret/libsecret/0001-pam-disable-tests.patch @@ -0,0 +1,71 @@ +From a028d36dc7b8d0bc33e674d2a0427b171aef2d32 Mon Sep 17 00:00:00 2001 +From: Markus Volk <f_l_k@t-online.de> +Date: Wed, 20 Nov 2024 16:30:07 +0100 +Subject: [PATCH] pam/meson.build: disable tests + +Otherwise a recipe for pam_wrapper would be required: +https://gitlab.com/cwrap/pam_wrapper + +Signed-off-by: Markus Volk <f_l_k@t-online.de> + +Upstream-Status: Inappropriate [oe-specific] +--- + pam/meson.build | 42 +++++++++++++++++++++--------------------- + 1 file changed, 21 insertions(+), 21 deletions(-) + +diff --git a/pam/meson.build b/pam/meson.build +index 8413b58..06d41c4 100644 +--- a/pam/meson.build ++++ b/pam/meson.build +@@ -19,27 +19,27 @@ pam_gnome_keyring = shared_library('pam_gnome_keyring', + ) + + # pam tests +-pam_wrapper = dependency('pam_wrapper', required: true) +-libpamtest = dependency('libpamtest', required: true) ++#pam_wrapper = dependency('pam_wrapper', required: true) ++#libpamtest = dependency('libpamtest', required: true) + +-subdir('servicedir') ++#subdir('servicedir') + +-test_bin = executable('pam_test', +- sources: [ +- 'test-pam.c', +- ], +- dependencies: [ +- libpamtest, +- glib_deps, +- ], +-) ++#test_bin = executable('pam_test', ++# sources: [ ++# 'test-pam.c', ++# ], ++# dependencies: [ ++# libpamtest, ++# glib_deps, ++# ], ++#) + +-test('pam-test', +- test_bin, +- env: { +- 'LD_PRELOAD': 'libpam_wrapper.so', +- 'PAM_WRAPPER': '1', +- 'PAM_WRAPPER_DEBUGLEVEL': '5', +- 'PAM_WRAPPER_SERVICE_DIR': meson.current_build_dir() + '/servicedir', +- }, +-) ++#test('pam-test', ++# test_bin, ++# env: { ++# 'LD_PRELOAD': 'libpam_wrapper.so', ++# 'PAM_WRAPPER': '1', ++# 'PAM_WRAPPER_DEBUGLEVEL': '5', ++# 'PAM_WRAPPER_SERVICE_DIR': meson.current_build_dir() + '/servicedir', ++# }, ++#) +-- +2.47.0 + diff --git a/meta/recipes-gnome/libsecret/libsecret_0.21.4.bb b/meta/recipes-gnome/libsecret/libsecret_0.21.4.bb index 88c3c73510..1bdd26d500 100644 --- a/meta/recipes-gnome/libsecret/libsecret_0.21.4.bb +++ b/meta/recipes-gnome/libsecret/libsecret_0.21.4.bb @@ -13,11 +13,14 @@ inherit gnomebase gi-docgen vala gobject-introspection manpages DEPENDS += "glib-2.0 libgcrypt gettext-native" +SRC_URI += "file://0001-pam-disable-tests.patch" SRC_URI[archive.sha256sum] = "163d08d783be6d4ab9a979ceb5a4fecbc1d9660d3c34168c581301cd53912b20" GTKDOC_MESON_OPTION = 'gtk_doc' +PACKAGECONFIG ?= "${@bb.utils.filter('DISTRO_FEATURES', 'pam', d)}" PACKAGECONFIG[manpages] = "-Dmanpage=true,-Dmanpage=false,libxslt-native xmlto-native" +PACKAGECONFIG[pam] = "-Dpam=true,-Dpam=false,libpam" # http://errors.yoctoproject.org/Errors/Details/20228/ ARM_INSTRUCTION_SET:armv4 = "arm"
Signed-off-by: Markus Volk <f_l_k@t-online.de> --- .../libsecret/0001-pam-disable-tests.patch | 71 +++++++++++++++++++ .../libsecret/libsecret_0.21.4.bb | 3 + 2 files changed, 74 insertions(+) create mode 100644 meta/recipes-gnome/libsecret/libsecret/0001-pam-disable-tests.patch