diff mbox series

[v2,1/3] bitbake.conf: make ZSTD_COMPRESSION_LEVEL a number rather than a dash-prefixed option

Message ID 20241120153205.2525735-1-alex.kanavin@gmail.com
State New
Headers show
Series [v2,1/3] bitbake.conf: make ZSTD_COMPRESSION_LEVEL a number rather than a dash-prefixed option | expand

Commit Message

Alexander Kanavin Nov. 20, 2024, 3:32 p.m. UTC 
From: Alexander Kanavin <alex@linutronix.de>

This allows using it where only a number is needed, such as rpm compression
setting.

Signed-off-by: Alexander Kanavin <alex@linutronix.de>
---
 meta/conf/bitbake.conf | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Quentin Schulz Nov. 20, 2024, 3:48 p.m. UTC | #1 
Hi Alex,

On 11/20/24 4:32 PM, Alexander Kanavin via lists.openembedded.org wrote:
> From: Alexander Kanavin <alex@linutronix.de>
> 
> This allows using it where only a number is needed, such as rpm compression
> setting.
> 

Sounds good to me except now we need to document this change in content 
format (if someone was modifying it, they need to put a number instead 
of the number prefixed with a dash) in the migration manual for 
walnascar, would you mind sending a patch to the docs for that (or at 
the very least open a bug ticket so it's tracked) once this gets merged?

Looks good to me,

Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>

Thanks!
Quentin
Alexander Kanavin Nov. 21, 2024, 12:37 p.m. UTC | #2 
On Wed, 20 Nov 2024 at 16:48, Quentin Schulz <quentin.schulz@cherry.de> wrote:
> Sounds good to me except now we need to document this change in content
> format (if someone was modifying it, they need to put a number instead
> of the number prefixed with a dash) in the migration manual for
> walnascar, would you mind sending a patch to the docs for that (or at
> the very least open a bug ticket so it's tracked) once this gets merged?

I just sent a patch to docs@ for that.

Alex
diff mbox series

Patch

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 02bbf0e7a52..b8b321dd1b7 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -881,8 +881,8 @@  XZ_DEFAULTS[vardepsexclude] += "XZ_MEMLIMIT XZ_THREADS"
 ZSTD_THREADS ?= "${@oe.utils.cpu_count(at_least=2)}"
 ZSTD_THREADS[vardepvalue] = "1"
 
-ZSTD_COMPRESSION_LEVEL ?= "-3"
-ZSTD_DEFAULTS ?= "--threads=${ZSTD_THREADS} ${ZSTD_COMPRESSION_LEVEL}"
+ZSTD_COMPRESSION_LEVEL ?= "3"
+ZSTD_DEFAULTS ?= "--threads=${ZSTD_THREADS} -${ZSTD_COMPRESSION_LEVEL}"
 ZSTD_DEFAULTS[vardepsexclude] = "ZSTD_THREADS"
 
 # Limit the number of threads that OpenMP libraries will use. Otherwise they