diff mbox series

[1/2] libdisplay-info: add recipe

Message ID 20241120203005.1802141-2-hiagofranco@gmail.com
State New
Headers show
Series weston: upgrade and add libdisplay-info recipe | expand

Commit Message

Hiago De Franco Nov. 20, 2024, 8:30 p.m. UTC
From: Hiago De Franco <hiago.franco@toradex.com>

libdisplay-info is a EDID and DisplayID library. Goals:

- Provide a set of high-level, easy-to-use, opinionated functions as
  well as low-level functions to access detailed information.
- Simplicity and correctness over performance and resource usage.
- Well-tested and fuzzed.

Since commit a16598b038b2 ("backend-drm: make libdisplay-info
mandatory") from Weston, this library is now mandatory in order to
build weston 14.0.1 and newer.

This recipe depends on hwdata-native, which support has been submitted to
meta-openembedded layer at [1].

Therefore, add this recipe.

[1] https://lore.kernel.org/all/20241120160005.8473-1-hiagofranco@gmail.com/

Signed-off-by: Hiago De Franco <hiago.franco@toradex.com>
---
 meta/conf/distro/include/maintainers.inc             |  1 +
 .../libdisplay-info/libdisplay-info_0.2.0.bb         | 12 ++++++++++++
 2 files changed, 13 insertions(+)
 create mode 100644 meta/recipes-support/libdisplay-info/libdisplay-info_0.2.0.bb

Comments

Denys Dmytriyenko Nov. 20, 2024, 11 p.m. UTC | #1
On Wed, Nov 20, 2024 at 05:30:04PM -0300, Hiago De Franco wrote:
> From: Hiago De Franco <hiago.franco@toradex.com>
> 
> libdisplay-info is a EDID and DisplayID library. Goals:
> 
> - Provide a set of high-level, easy-to-use, opinionated functions as
>   well as low-level functions to access detailed information.
> - Simplicity and correctness over performance and resource usage.
> - Well-tested and fuzzed.
> 
> Since commit a16598b038b2 ("backend-drm: make libdisplay-info
> mandatory") from Weston, this library is now mandatory in order to
> build weston 14.0.1 and newer.
> 
> This recipe depends on hwdata-native, which support has been submitted to
> meta-openembedded layer at [1].

OE-Core cannot depend on meta-openembedded and based on the changes being 
submitted, it is a hard dependency and is not optional. If it cannot be made 
optional, hwdata will need to be moved to OE-Core...


> Therefore, add this recipe.
> 
> [1] https://lore.kernel.org/all/20241120160005.8473-1-hiagofranco@gmail.com/
> 
> Signed-off-by: Hiago De Franco <hiago.franco@toradex.com>
> ---
>  meta/conf/distro/include/maintainers.inc             |  1 +
>  .../libdisplay-info/libdisplay-info_0.2.0.bb         | 12 ++++++++++++
>  2 files changed, 13 insertions(+)
>  create mode 100644 meta/recipes-support/libdisplay-info/libdisplay-info_0.2.0.bb
> 
> diff --git a/meta/conf/distro/include/maintainers.inc b/meta/conf/distro/include/maintainers.inc
> index d61b88f7de6c..81989506e19c 100644
> --- a/meta/conf/distro/include/maintainers.inc
> +++ b/meta/conf/distro/include/maintainers.inc
> @@ -324,6 +324,7 @@ RECIPE_MAINTAINER:pn-libcomps = "Alexander Kanavin <alex.kanavin@gmail.com>"
>  RECIPE_MAINTAINER:pn-libconvert-asn1-perl = "Tim Orling <tim.orling@konsulko.com>"
>  RECIPE_MAINTAINER:pn-libdaemon = "Alexander Kanavin <alex.kanavin@gmail.com>"
>  RECIPE_MAINTAINER:pn-libdazzle = "Alexander Kanavin <alex.kanavin@gmail.com>"
> +RECIPE_MAINTAINER:pn-libdisplay-info = "Hiago De Franco <hiago.franco@toradex.com>"
>  RECIPE_MAINTAINER:pn-libdnf = "Alexander Kanavin <alex.kanavin@gmail.com>"
>  RECIPE_MAINTAINER:pn-libdrm = "Otavio Salvador <otavio.salvador@ossystems.com.br>"
>  RECIPE_MAINTAINER:pn-libedit = "Khem Raj <raj.khem@gmail.com>"
> diff --git a/meta/recipes-support/libdisplay-info/libdisplay-info_0.2.0.bb b/meta/recipes-support/libdisplay-info/libdisplay-info_0.2.0.bb
> new file mode 100644
> index 000000000000..b98d2e4452a8
> --- /dev/null
> +++ b/meta/recipes-support/libdisplay-info/libdisplay-info_0.2.0.bb
> @@ -0,0 +1,12 @@
> +SUMMARY = "EDID and DisplayID library."

A minor nitpick - SUMMARY shouldn't normally have a trailing dot, as the 
default DESCRIPTION will end up with two dots...


> +HOMEPAGE = "https://gitlab.freedesktop.org/emersion/libdisplay-info"
> +LICENSE = "MIT"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=e4426409957080ee0352128354cea2de"
> +DEPENDS = "hwdata-native"
> +
> +SRC_URI = "git://gitlab.freedesktop.org/emersion/libdisplay-info.git;branch=main;protocol=https"
> +SRCREV = "66b802d05b374cd8f388dc6ad1e7ae4f08cb3300"
> +
> +S = "${WORKDIR}/git"
> +
> +inherit meson pkgconfig
> -- 
> 2.39.5
Hiago De Franco Nov. 20, 2024, 11:57 p.m. UTC | #2
On Wed, Nov 20, 2024 at 06:00:58PM -0500, Denys Dmytriyenko wrote:
> On Wed, Nov 20, 2024 at 05:30:04PM -0300, Hiago De Franco wrote:
> > From: Hiago De Franco <hiago.franco@toradex.com>
> > 
> > libdisplay-info is a EDID and DisplayID library. Goals:
> > 
> > - Provide a set of high-level, easy-to-use, opinionated functions as
> >   well as low-level functions to access detailed information.
> > - Simplicity and correctness over performance and resource usage.
> > - Well-tested and fuzzed.
> > 
> > Since commit a16598b038b2 ("backend-drm: make libdisplay-info
> > mandatory") from Weston, this library is now mandatory in order to
> > build weston 14.0.1 and newer.
> > 
> > This recipe depends on hwdata-native, which support has been submitted to
> > meta-openembedded layer at [1].
> 
> OE-Core cannot depend on meta-openembedded and based on the changes being 
> submitted, it is a hard dependency and is not optional. If it cannot be made 
> optional, hwdata will need to be moved to OE-Core...

Got it Denys, should I then move hwdata here and make a patch to remove
it from meta-openembedded? What do you suggest?

I would add myself as maintainer of libdisplay-info and hwdata.

> 
> 
> > Therefore, add this recipe.
> > 
> > [1] https://lore.kernel.org/all/20241120160005.8473-1-hiagofranco@gmail.com/
> > 
> > Signed-off-by: Hiago De Franco <hiago.franco@toradex.com>
> > ---
> >  meta/conf/distro/include/maintainers.inc             |  1 +
> >  .../libdisplay-info/libdisplay-info_0.2.0.bb         | 12 ++++++++++++
> >  2 files changed, 13 insertions(+)
> >  create mode 100644 meta/recipes-support/libdisplay-info/libdisplay-info_0.2.0.bb
> > 
> > diff --git a/meta/conf/distro/include/maintainers.inc b/meta/conf/distro/include/maintainers.inc
> > index d61b88f7de6c..81989506e19c 100644
> > --- a/meta/conf/distro/include/maintainers.inc
> > +++ b/meta/conf/distro/include/maintainers.inc
> > @@ -324,6 +324,7 @@ RECIPE_MAINTAINER:pn-libcomps = "Alexander Kanavin <alex.kanavin@gmail.com>"
> >  RECIPE_MAINTAINER:pn-libconvert-asn1-perl = "Tim Orling <tim.orling@konsulko.com>"
> >  RECIPE_MAINTAINER:pn-libdaemon = "Alexander Kanavin <alex.kanavin@gmail.com>"
> >  RECIPE_MAINTAINER:pn-libdazzle = "Alexander Kanavin <alex.kanavin@gmail.com>"
> > +RECIPE_MAINTAINER:pn-libdisplay-info = "Hiago De Franco <hiago.franco@toradex.com>"
> >  RECIPE_MAINTAINER:pn-libdnf = "Alexander Kanavin <alex.kanavin@gmail.com>"
> >  RECIPE_MAINTAINER:pn-libdrm = "Otavio Salvador <otavio.salvador@ossystems.com.br>"
> >  RECIPE_MAINTAINER:pn-libedit = "Khem Raj <raj.khem@gmail.com>"
> > diff --git a/meta/recipes-support/libdisplay-info/libdisplay-info_0.2.0.bb b/meta/recipes-support/libdisplay-info/libdisplay-info_0.2.0.bb
> > new file mode 100644
> > index 000000000000..b98d2e4452a8
> > --- /dev/null
> > +++ b/meta/recipes-support/libdisplay-info/libdisplay-info_0.2.0.bb
> > @@ -0,0 +1,12 @@
> > +SUMMARY = "EDID and DisplayID library."
> 
> A minor nitpick - SUMMARY shouldn't normally have a trailing dot, as the 
> default DESCRIPTION will end up with two dots...

Thanks for letting me know, I will fix it in the v2 patch.

> 
> 
> > +HOMEPAGE = "https://gitlab.freedesktop.org/emersion/libdisplay-info"
> > +LICENSE = "MIT"
> > +LIC_FILES_CHKSUM = "file://LICENSE;md5=e4426409957080ee0352128354cea2de"
> > +DEPENDS = "hwdata-native"
> > +
> > +SRC_URI = "git://gitlab.freedesktop.org/emersion/libdisplay-info.git;branch=main;protocol=https"
> > +SRCREV = "66b802d05b374cd8f388dc6ad1e7ae4f08cb3300"
> > +
> > +S = "${WORKDIR}/git"
> > +
> > +inherit meson pkgconfig
> > -- 
> > 2.39.5

Regards,

Hiago.
diff mbox series

Patch

diff --git a/meta/conf/distro/include/maintainers.inc b/meta/conf/distro/include/maintainers.inc
index d61b88f7de6c..81989506e19c 100644
--- a/meta/conf/distro/include/maintainers.inc
+++ b/meta/conf/distro/include/maintainers.inc
@@ -324,6 +324,7 @@  RECIPE_MAINTAINER:pn-libcomps = "Alexander Kanavin <alex.kanavin@gmail.com>"
 RECIPE_MAINTAINER:pn-libconvert-asn1-perl = "Tim Orling <tim.orling@konsulko.com>"
 RECIPE_MAINTAINER:pn-libdaemon = "Alexander Kanavin <alex.kanavin@gmail.com>"
 RECIPE_MAINTAINER:pn-libdazzle = "Alexander Kanavin <alex.kanavin@gmail.com>"
+RECIPE_MAINTAINER:pn-libdisplay-info = "Hiago De Franco <hiago.franco@toradex.com>"
 RECIPE_MAINTAINER:pn-libdnf = "Alexander Kanavin <alex.kanavin@gmail.com>"
 RECIPE_MAINTAINER:pn-libdrm = "Otavio Salvador <otavio.salvador@ossystems.com.br>"
 RECIPE_MAINTAINER:pn-libedit = "Khem Raj <raj.khem@gmail.com>"
diff --git a/meta/recipes-support/libdisplay-info/libdisplay-info_0.2.0.bb b/meta/recipes-support/libdisplay-info/libdisplay-info_0.2.0.bb
new file mode 100644
index 000000000000..b98d2e4452a8
--- /dev/null
+++ b/meta/recipes-support/libdisplay-info/libdisplay-info_0.2.0.bb
@@ -0,0 +1,12 @@ 
+SUMMARY = "EDID and DisplayID library."
+HOMEPAGE = "https://gitlab.freedesktop.org/emersion/libdisplay-info"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=e4426409957080ee0352128354cea2de"
+DEPENDS = "hwdata-native"
+
+SRC_URI = "git://gitlab.freedesktop.org/emersion/libdisplay-info.git;branch=main;protocol=https"
+SRCREV = "66b802d05b374cd8f388dc6ad1e7ae4f08cb3300"
+
+S = "${WORKDIR}/git"
+
+inherit meson pkgconfig