| Message ID | 20241030151409.208066-1-martin.jansa@gmail.com |
|---|---|
| State | Under Review |
| Headers | show |
| Series | [meta-oe] libgpiod: drop wrong S assignment | expand |
Le 30/10/2024 à 16:14, Martin Jansa via lists.openembedded.org a écrit : > * the default from bitbake.conf: > S = / You meant S = "${WORKDIR}/${BP}" ? > works better, because it points to correct directory even with e.g. when > building lib32-libgpiod with multilib > > Signed-off-by: Martin Jansa <martin.jansa@gmail.com> > --- > meta-oe/recipes-support/libgpiod/libgpiod_2.2.bb | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/meta-oe/recipes-support/libgpiod/libgpiod_2.2.bb b/meta-oe/recipes-support/libgpiod/libgpiod_2.2.bb > index 3d9758e27a..00252dfe64 100644 > --- a/meta-oe/recipes-support/libgpiod/libgpiod_2.2.bb > +++ b/meta-oe/recipes-support/libgpiod/libgpiod_2.2.bb > @@ -17,8 +17,6 @@ SRC_URI += "file://gpio-manager.init" > > SRC_URI[sha256sum] = "ee29735890eb1cc0e4b494001da5163d1a9c4735343201d22485db313601ca07" > > -S = "${UNPACKDIR}/${PN}-2.2" > - > # Enable all project features for ptest > PACKAGECONFIG[tests] = " \ > --enable-tests --enable-tools --enable-bindings-cxx --enable-bindings-glib --enable-gpioset-interactive --enable-dbus, \
Indeed, but wrote it in shell where those 2 variables were empty :), sending v2 now, thanks for review. On Wed, Oct 30, 2024 at 4:18 PM Yoann Congal <yoann.congal@smile.fr> wrote: > > > > Le 30/10/2024 à 16:14, Martin Jansa via lists.openembedded.org a écrit : > > * the default from bitbake.conf: > > S = / > > You meant > S = "${WORKDIR}/${BP}" > ? > > works better, because it points to correct directory even with e.g. when > > building lib32-libgpiod with multilib > > > > Signed-off-by: Martin Jansa <martin.jansa@gmail.com> > > --- > > meta-oe/recipes-support/libgpiod/libgpiod_2.2.bb | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/meta-oe/recipes-support/libgpiod/libgpiod_2.2.bb b/meta-oe/recipes-support/libgpiod/libgpiod_2.2.bb > > index 3d9758e27a..00252dfe64 100644 > > --- a/meta-oe/recipes-support/libgpiod/libgpiod_2.2.bb > > +++ b/meta-oe/recipes-support/libgpiod/libgpiod_2.2.bb > > @@ -17,8 +17,6 @@ SRC_URI += "file://gpio-manager.init" > > > > SRC_URI[sha256sum] = "ee29735890eb1cc0e4b494001da5163d1a9c4735343201d22485db313601ca07" > > > > -S = "${UNPACKDIR}/${PN}-2.2" > > - > > # Enable all project features for ptest > > PACKAGECONFIG[tests] = " \ > > --enable-tests --enable-tools --enable-bindings-cxx --enable-bindings-glib --enable-gpioset-interactive --enable-dbus, \
diff --git a/meta-oe/recipes-support/libgpiod/libgpiod_2.2.bb b/meta-oe/recipes-support/libgpiod/libgpiod_2.2.bb index 3d9758e27a..00252dfe64 100644 --- a/meta-oe/recipes-support/libgpiod/libgpiod_2.2.bb +++ b/meta-oe/recipes-support/libgpiod/libgpiod_2.2.bb @@ -17,8 +17,6 @@ SRC_URI += "file://gpio-manager.init" SRC_URI[sha256sum] = "ee29735890eb1cc0e4b494001da5163d1a9c4735343201d22485db313601ca07" -S = "${UNPACKDIR}/${PN}-2.2" - # Enable all project features for ptest PACKAGECONFIG[tests] = " \ --enable-tests --enable-tools --enable-bindings-cxx --enable-bindings-glib --enable-gpioset-interactive --enable-dbus, \
* the default from bitbake.conf: S = / works better, because it points to correct directory even with e.g. when building lib32-libgpiod with multilib Signed-off-by: Martin Jansa <martin.jansa@gmail.com> --- meta-oe/recipes-support/libgpiod/libgpiod_2.2.bb | 2 -- 1 file changed, 2 deletions(-)