diff mbox series

[meta-networking] mctp: Fix CI build error with musl+clang

Message ID 20241024065109.74010-1-chanh@os.amperecomputing.com
State Under Review
Headers show
Series [meta-networking] mctp: Fix CI build error with musl+clang | expand

Commit Message

Chanh Nguyen Oct. 24, 2024, 6:51 a.m. UTC
Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
---
 meta-networking/recipes-support/mctp/mctp_2.0.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Chanh Nguyen Oct. 24, 2024, 6:52 a.m. UTC | #1
Hi Khem,

This is only a temporary patch. It helps check CI build errors on the 
MCTP repo. Please help run the CI build; if any error you can show here, 
then Jeremy will update the mctp repo to fix errors.

Please don't merge this patch. When the CI builds completely without any 
errors, I will push a new patch with the latest version on the MCTP repo.

Thanks,

Chanh

On 24/10/2024 13:51, Chanh Nguyen wrote:
> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
> ---
>   meta-networking/recipes-support/mctp/mctp_2.0.bb | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-networking/recipes-support/mctp/mctp_2.0.bb b/meta-networking/recipes-support/mctp/mctp_2.0.bb
> index c6aa7c104..793afe755 100644
> --- a/meta-networking/recipes-support/mctp/mctp_2.0.bb
> +++ b/meta-networking/recipes-support/mctp/mctp_2.0.bb
> @@ -5,9 +5,9 @@ LICENSE = "GPL-2.0-only"
>   
>   LIC_FILES_CHKSUM = "file://LICENSE;md5=4cc91856b08b094b4f406a29dc61db21"
>   
> -SRCREV = "f110926b082731b25720b444378ad55d7a9d451d"
> +SRCREV = "089dc53fa7387cca517cd713061c323ca06fb6dd"
>   
> -SRC_URI = "git://github.com/CodeConstruct/mctp;branch=main;protocol=https"
> +SRC_URI = "git://github.com/CodeConstruct/mctp;branch=dev/cross-fixes;protocol=https"
>   
>   S = "${WORKDIR}/git"
>
Jeremy Kerr Oct. 24, 2024, 6:55 a.m. UTC | #2
Hi Chanh,
 
> -SRC_URI = "git://github.com/CodeConstruct/mctp;branch=main;protocol=https"
> +SRC_URI = "git://github.com/CodeConstruct/mctp;branch=dev/cross-fixes;protocol=https"

Note that that this (dev/cross-fixes) branch will not live for long;
it's just for getting you a set of fixes to test.

I assume you are sending this change just for a CI run, so this won't
matter. But just to be clear, this isn't suitable for an upstream
merge.

Cheers,


Jeremy
Chanh Nguyen Oct. 24, 2024, 6:59 a.m. UTC | #3
On 24/10/2024 13:55, Jeremy Kerr wrote:
> Hi Chanh,
>   
>> -SRC_URI = "git://github.com/CodeConstruct/mctp;branch=main;protocol=https"
>> +SRC_URI = "git://github.com/CodeConstruct/mctp;branch=dev/cross-fixes;protocol=https"
> 
> Note that that this (dev/cross-fixes) branch will not live for long;
> it's just for getting you a set of fixes to test.
> 
> I assume you are sending this change just for a CI run, so this won't
> matter. But just to be clear, this isn't suitable for an upstream
> merge.
> 

Yes Jeremy,

This is only a temporary patch. It helps check CI build errors on the 
MCTP repo.

Hi Khem, Please don't merge this patch. When the CI builds completely 
without any errors, I will push a new patch with the latest version on 
the MCTP master branch.

> Cheers,
> 
> 
> Jeremy
Khem Raj Oct. 24, 2024, 12:18 p.m. UTC | #4
Please test it and wait it to merge before sending pull request here,
feature branches are temporary and usually not something we use in OE

On Wed, Oct 23, 2024 at 11:52 PM Chanh Nguyen
<chanh@amperemail.onmicrosoft.com> wrote:
>
> Hi Khem,
>
> This is only a temporary patch. It helps check CI build errors on the
> MCTP repo. Please help run the CI build; if any error you can show here,
> then Jeremy will update the mctp repo to fix errors.
>
> Please don't merge this patch. When the CI builds completely without any
> errors, I will push a new patch with the latest version on the MCTP repo.
>
> Thanks,
>
> Chanh
>
> On 24/10/2024 13:51, Chanh Nguyen wrote:
> > Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
> > ---
> >   meta-networking/recipes-support/mctp/mctp_2.0.bb | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta-networking/recipes-support/mctp/mctp_2.0.bb b/meta-networking/recipes-support/mctp/mctp_2.0.bb
> > index c6aa7c104..793afe755 100644
> > --- a/meta-networking/recipes-support/mctp/mctp_2.0.bb
> > +++ b/meta-networking/recipes-support/mctp/mctp_2.0.bb
> > @@ -5,9 +5,9 @@ LICENSE = "GPL-2.0-only"
> >
> >   LIC_FILES_CHKSUM = "file://LICENSE;md5=4cc91856b08b094b4f406a29dc61db21"
> >
> > -SRCREV = "f110926b082731b25720b444378ad55d7a9d451d"
> > +SRCREV = "089dc53fa7387cca517cd713061c323ca06fb6dd"
> >
> > -SRC_URI = "git://github.com/CodeConstruct/mctp;branch=main;protocol=https"
> > +SRC_URI = "git://github.com/CodeConstruct/mctp;branch=dev/cross-fixes;protocol=https"
> >
> >   S = "${WORKDIR}/git"
> >
>
Chanh Nguyen Oct. 24, 2024, 2:46 p.m. UTC | #5
On 24/10/2024 19:18, Khem Raj wrote:
> Please test it and wait it to merge before sending pull request here,
> feature branches are temporary and usually not something we use in OE
> 

Yes Khem, it is only temporary for CI build checking.

Can you please help run CI build? If any other errors, we'll fix.

Thanks,
Chanh

> On Wed, Oct 23, 2024 at 11:52 PM Chanh Nguyen
> <chanh@amperemail.onmicrosoft.com> wrote:
>>
>> Hi Khem,
>>
>> This is only a temporary patch. It helps check CI build errors on the
>> MCTP repo. Please help run the CI build; if any error you can show here,
>> then Jeremy will update the mctp repo to fix errors.
>>
>> Please don't merge this patch. When the CI builds completely without any
>> errors, I will push a new patch with the latest version on the MCTP repo.
>>
>> Thanks,
>>
>> Chanh
>>
>> On 24/10/2024 13:51, Chanh Nguyen wrote:
>>> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
>>> ---
>>>    meta-networking/recipes-support/mctp/mctp_2.0.bb | 4 ++--
>>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/meta-networking/recipes-support/mctp/mctp_2.0.bb b/meta-networking/recipes-support/mctp/mctp_2.0.bb
>>> index c6aa7c104..793afe755 100644
>>> --- a/meta-networking/recipes-support/mctp/mctp_2.0.bb
>>> +++ b/meta-networking/recipes-support/mctp/mctp_2.0.bb
>>> @@ -5,9 +5,9 @@ LICENSE = "GPL-2.0-only"
>>>
>>>    LIC_FILES_CHKSUM = "file://LICENSE;md5=4cc91856b08b094b4f406a29dc61db21"
>>>
>>> -SRCREV = "f110926b082731b25720b444378ad55d7a9d451d"
>>> +SRCREV = "089dc53fa7387cca517cd713061c323ca06fb6dd"
>>>
>>> -SRC_URI = "git://github.com/CodeConstruct/mctp;branch=main;protocol=https"
>>> +SRC_URI = "git://github.com/CodeConstruct/mctp;branch=dev/cross-fixes;protocol=https"
>>>
>>>    S = "${WORKDIR}/git"
>>>
>>
Khem Raj Oct. 24, 2024, 2:56 p.m. UTC | #6
On Thu, Oct 24, 2024 at 7:47 AM Chanh Nguyen <
chanh@amperemail.onmicrosoft.com> wrote:

>
>
> On 24/10/2024 19:18, Khem Raj wrote:
> > Please test it and wait it to merge before sending pull request here,
> > feature branches are temporary and usually not something we use in OE
> >
>
> Yes Khem, it is only temporary for CI build checking.


In this case please mark them so in subject line
So we know what they are intended for


>
> Can you please help run CI build? If any other errors, we'll fix.
>
> Thanks,
> Chanh
>
> > On Wed, Oct 23, 2024 at 11:52 PM Chanh Nguyen
> > <chanh@amperemail.onmicrosoft.com> wrote:
> >>
> >> Hi Khem,
> >>
> >> This is only a temporary patch. It helps check CI build errors on the
> >> MCTP repo. Please help run the CI build; if any error you can show here,
> >> then Jeremy will update the mctp repo to fix errors.
> >>
> >> Please don't merge this patch. When the CI builds completely without any
> >> errors, I will push a new patch with the latest version on the MCTP
> repo.
> >>
> >> Thanks,
> >>
> >> Chanh
> >>
> >> On 24/10/2024 13:51, Chanh Nguyen wrote:
> >>> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
> >>> ---
> >>>    meta-networking/recipes-support/mctp/mctp_2.0.bb | 4 ++--
> >>>    1 file changed, 2 insertions(+), 2 deletions(-)
> >>>
> >>> diff --git a/meta-networking/recipes-support/mctp/mctp_2.0.bb
> b/meta-networking/recipes-support/mctp/mctp_2.0.bb
> >>> index c6aa7c104..793afe755 100644
> >>> --- a/meta-networking/recipes-support/mctp/mctp_2.0.bb
> >>> +++ b/meta-networking/recipes-support/mctp/mctp_2.0.bb
> >>> @@ -5,9 +5,9 @@ LICENSE = "GPL-2.0-only"
> >>>
> >>>    LIC_FILES_CHKSUM =
> "file://LICENSE;md5=4cc91856b08b094b4f406a29dc61db21"
> >>>
> >>> -SRCREV = "f110926b082731b25720b444378ad55d7a9d451d"
> >>> +SRCREV = "089dc53fa7387cca517cd713061c323ca06fb6dd"
> >>>
> >>> -SRC_URI = "git://
> github.com/CodeConstruct/mctp;branch=main;protocol=https"
> >>> +SRC_URI = "git://
> github.com/CodeConstruct/mctp;branch=dev/cross-fixes;protocol=https"
> >>>
> >>>    S = "${WORKDIR}/git"
> >>>
> >>
>
>
Chanh Nguyen Oct. 24, 2024, 2:57 p.m. UTC | #7
On 24/10/2024 21:46, Chanh Nguyen wrote:
> 
> 
> On 24/10/2024 19:18, Khem Raj wrote:
>> Please test it and wait it to merge before sending pull request here,
>> feature branches are temporary and usually not something we use in OE
>>
> 
> Yes Khem, it is only temporary for CI build checking.
> 
> Can you please help run CI build? If any other errors, we'll fix.
> 
> Thanks,
> Chanh
> 
I and Jeremy used the musl compiler (https://musl.cc/), and it compiled 
the MCTP successfully. It seems the error just happens with your CI run, 
and we haven't known to run the CI to check.

>> On Wed, Oct 23, 2024 at 11:52 PM Chanh Nguyen
>> <chanh@amperemail.onmicrosoft.com> wrote:
>>>
>>> Hi Khem,
>>>
>>> This is only a temporary patch. It helps check CI build errors on the
>>> MCTP repo. Please help run the CI build; if any error you can show here,
>>> then Jeremy will update the mctp repo to fix errors.
>>>
>>> Please don't merge this patch. When the CI builds completely without any
>>> errors, I will push a new patch with the latest version on the MCTP 
>>> repo.
>>>
>>> Thanks,
>>>
>>> Chanh
>>>
>>> On 24/10/2024 13:51, Chanh Nguyen wrote:
>>>> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
>>>> ---
>>>>    meta-networking/recipes-support/mctp/mctp_2.0.bb | 4 ++--
>>>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/meta-networking/recipes-support/mctp/mctp_2.0.bb b/ 
>>>> meta-networking/recipes-support/mctp/mctp_2.0.bb
>>>> index c6aa7c104..793afe755 100644
>>>> --- a/meta-networking/recipes-support/mctp/mctp_2.0.bb
>>>> +++ b/meta-networking/recipes-support/mctp/mctp_2.0.bb
>>>> @@ -5,9 +5,9 @@ LICENSE = "GPL-2.0-only"
>>>>
>>>>    LIC_FILES_CHKSUM = "file:// 
>>>> LICENSE;md5=4cc91856b08b094b4f406a29dc61db21"
>>>>
>>>> -SRCREV = "f110926b082731b25720b444378ad55d7a9d451d"
>>>> +SRCREV = "089dc53fa7387cca517cd713061c323ca06fb6dd"
>>>>
>>>> -SRC_URI = "git://github.com/CodeConstruct/ 
>>>> mctp;branch=main;protocol=https"
>>>> +SRC_URI = "git://github.com/CodeConstruct/mctp;branch=dev/cross- 
>>>> fixes;protocol=https"
>>>>
>>>>    S = "${WORKDIR}/git"
>>>>
>>>
>
Khem Raj Oct. 24, 2024, 3:22 p.m. UTC | #8
On Thu, Oct 24, 2024 at 7:57 AM Chanh Nguyen
<chanh@amperemail.onmicrosoft.com> wrote:
>
>
>
> On 24/10/2024 21:46, Chanh Nguyen wrote:
> >
> >
> > On 24/10/2024 19:18, Khem Raj wrote:
> >> Please test it and wait it to merge before sending pull request here,
> >> feature branches are temporary and usually not something we use in OE
> >>
> >
> > Yes Khem, it is only temporary for CI build checking.
> >
> > Can you please help run CI build? If any other errors, we'll fix.
> >
> > Thanks,
> > Chanh
> >
> I and Jeremy used the musl compiler (https://musl.cc/), and it compiled
> the MCTP successfully. It seems the error just happens with your CI run,
> and we haven't known to run the CI to check.
>

As I mentioned before, the combination is clang19 + musl, musl.cc is
gcc+musl only so
you won't see clang specific issues with it.
That's fine if you can say [RFT] in the subject line to convey the intention.

> >> On Wed, Oct 23, 2024 at 11:52 PM Chanh Nguyen
> >> <chanh@amperemail.onmicrosoft.com> wrote:
> >>>
> >>> Hi Khem,
> >>>
> >>> This is only a temporary patch. It helps check CI build errors on the
> >>> MCTP repo. Please help run the CI build; if any error you can show here,
> >>> then Jeremy will update the mctp repo to fix errors.
> >>>
> >>> Please don't merge this patch. When the CI builds completely without any
> >>> errors, I will push a new patch with the latest version on the MCTP
> >>> repo.
> >>>
> >>> Thanks,
> >>>
> >>> Chanh
> >>>
> >>> On 24/10/2024 13:51, Chanh Nguyen wrote:
> >>>> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
> >>>> ---
> >>>>    meta-networking/recipes-support/mctp/mctp_2.0.bb | 4 ++--
> >>>>    1 file changed, 2 insertions(+), 2 deletions(-)
> >>>>
> >>>> diff --git a/meta-networking/recipes-support/mctp/mctp_2.0.bb b/
> >>>> meta-networking/recipes-support/mctp/mctp_2.0.bb
> >>>> index c6aa7c104..793afe755 100644
> >>>> --- a/meta-networking/recipes-support/mctp/mctp_2.0.bb
> >>>> +++ b/meta-networking/recipes-support/mctp/mctp_2.0.bb
> >>>> @@ -5,9 +5,9 @@ LICENSE = "GPL-2.0-only"
> >>>>
> >>>>    LIC_FILES_CHKSUM = "file://
> >>>> LICENSE;md5=4cc91856b08b094b4f406a29dc61db21"
> >>>>
> >>>> -SRCREV = "f110926b082731b25720b444378ad55d7a9d451d"
> >>>> +SRCREV = "089dc53fa7387cca517cd713061c323ca06fb6dd"
> >>>>
> >>>> -SRC_URI = "git://github.com/CodeConstruct/
> >>>> mctp;branch=main;protocol=https"
> >>>> +SRC_URI = "git://github.com/CodeConstruct/mctp;branch=dev/cross-
> >>>> fixes;protocol=https"
> >>>>
> >>>>    S = "${WORKDIR}/git"
> >>>>
> >>>
> >
>
Chanh Nguyen Oct. 25, 2024, 3:49 p.m. UTC | #9
On 24/10/2024 22:22, Khem Raj wrote:
> On Thu, Oct 24, 2024 at 7:57 AM Chanh Nguyen
> <chanh@amperemail.onmicrosoft.com> wrote:
>>
>>
>>
>> On 24/10/2024 21:46, Chanh Nguyen wrote:
>>>
>>>
>>> On 24/10/2024 19:18, Khem Raj wrote:
>>>> Please test it and wait it to merge before sending pull request here,
>>>> feature branches are temporary and usually not something we use in OE
>>>>
>>>
>>> Yes Khem, it is only temporary for CI build checking.
>>>
>>> Can you please help run CI build? If any other errors, we'll fix.
>>>
>>> Thanks,
>>> Chanh
>>>
>> I and Jeremy used the musl compiler (https://musl.cc/), and it compiled
>> the MCTP successfully. It seems the error just happens with your CI run,
>> and we haven't known to run the CI to check.
>>
> 
> As I mentioned before, the combination is clang19 + musl, musl.cc is
> gcc+musl only so
> you won't see clang specific issues with it.
> That's fine if you can say [RFT] in the subject line to convey the intention.
> 

Thank Khem for your instruction about subject patch!

Should I resend this patch with new subject ? It will be
[RFT][meta-networking][PATCH] mctp: Fix CI build error with musl+clang

>>>> On Wed, Oct 23, 2024 at 11:52 PM Chanh Nguyen
>>>> <chanh@amperemail.onmicrosoft.com> wrote:
>>>>>
>>>>> Hi Khem,
>>>>>
>>>>> This is only a temporary patch. It helps check CI build errors on the
>>>>> MCTP repo. Please help run the CI build; if any error you can show here,
>>>>> then Jeremy will update the mctp repo to fix errors.
>>>>>
>>>>> Please don't merge this patch. When the CI builds completely without any
>>>>> errors, I will push a new patch with the latest version on the MCTP
>>>>> repo.
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Chanh
>>>>>
>>>>> On 24/10/2024 13:51, Chanh Nguyen wrote:
>>>>>> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
>>>>>> ---
>>>>>>     meta-networking/recipes-support/mctp/mctp_2.0.bb | 4 ++--
>>>>>>     1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>>
>>>>>> diff --git a/meta-networking/recipes-support/mctp/mctp_2.0.bb b/
>>>>>> meta-networking/recipes-support/mctp/mctp_2.0.bb
>>>>>> index c6aa7c104..793afe755 100644
>>>>>> --- a/meta-networking/recipes-support/mctp/mctp_2.0.bb
>>>>>> +++ b/meta-networking/recipes-support/mctp/mctp_2.0.bb
>>>>>> @@ -5,9 +5,9 @@ LICENSE = "GPL-2.0-only"
>>>>>>
>>>>>>     LIC_FILES_CHKSUM = "file://
>>>>>> LICENSE;md5=4cc91856b08b094b4f406a29dc61db21"
>>>>>>
>>>>>> -SRCREV = "f110926b082731b25720b444378ad55d7a9d451d"
>>>>>> +SRCREV = "089dc53fa7387cca517cd713061c323ca06fb6dd"
>>>>>>
>>>>>> -SRC_URI = "git://github.com/CodeConstruct/
>>>>>> mctp;branch=main;protocol=https"
>>>>>> +SRC_URI = "git://github.com/CodeConstruct/mctp;branch=dev/cross-
>>>>>> fixes;protocol=https"
>>>>>>
>>>>>>     S = "${WORKDIR}/git"
>>>>>>
>>>>>
>>>
>>
Khem Raj Oct. 25, 2024, 3:59 p.m. UTC | #10
On Fri, Oct 25, 2024 at 8:49 AM Chanh Nguyen
<chanh@amperemail.onmicrosoft.com> wrote:
>
>
>
> On 24/10/2024 22:22, Khem Raj wrote:
> > On Thu, Oct 24, 2024 at 7:57 AM Chanh Nguyen
> > <chanh@amperemail.onmicrosoft.com> wrote:
> >>
> >>
> >>
> >> On 24/10/2024 21:46, Chanh Nguyen wrote:
> >>>
> >>>
> >>> On 24/10/2024 19:18, Khem Raj wrote:
> >>>> Please test it and wait it to merge before sending pull request here,
> >>>> feature branches are temporary and usually not something we use in OE
> >>>>
> >>>
> >>> Yes Khem, it is only temporary for CI build checking.
> >>>
> >>> Can you please help run CI build? If any other errors, we'll fix.
> >>>
> >>> Thanks,
> >>> Chanh
> >>>
> >> I and Jeremy used the musl compiler (https://musl.cc/), and it compiled
> >> the MCTP successfully. It seems the error just happens with your CI run,
> >> and we haven't known to run the CI to check.
> >>
> >
> > As I mentioned before, the combination is clang19 + musl, musl.cc is
> > gcc+musl only so
> > you won't see clang specific issues with it.
> > That's fine if you can say [RFT] in the subject line to convey the intention.
> >
>
> Thank Khem for your instruction about subject patch!
>
> Should I resend this patch with new subject ? It will be
> [RFT][meta-networking][PATCH] mctp: Fix CI build error with musl+clang

Not this time, since I have staged it for testing and it seems to work
for musl+clang case
AFAICT so please send the final patch with version bump to include the
fixes that
Jeremy is pushing into component repo

>
> >>>> On Wed, Oct 23, 2024 at 11:52 PM Chanh Nguyen
> >>>> <chanh@amperemail.onmicrosoft.com> wrote:
> >>>>>
> >>>>> Hi Khem,
> >>>>>
> >>>>> This is only a temporary patch. It helps check CI build errors on the
> >>>>> MCTP repo. Please help run the CI build; if any error you can show here,
> >>>>> then Jeremy will update the mctp repo to fix errors.
> >>>>>
> >>>>> Please don't merge this patch. When the CI builds completely without any
> >>>>> errors, I will push a new patch with the latest version on the MCTP
> >>>>> repo.
> >>>>>
> >>>>> Thanks,
> >>>>>
> >>>>> Chanh
> >>>>>
> >>>>> On 24/10/2024 13:51, Chanh Nguyen wrote:
> >>>>>> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
> >>>>>> ---
> >>>>>>     meta-networking/recipes-support/mctp/mctp_2.0.bb | 4 ++--
> >>>>>>     1 file changed, 2 insertions(+), 2 deletions(-)
> >>>>>>
> >>>>>> diff --git a/meta-networking/recipes-support/mctp/mctp_2.0.bb b/
> >>>>>> meta-networking/recipes-support/mctp/mctp_2.0.bb
> >>>>>> index c6aa7c104..793afe755 100644
> >>>>>> --- a/meta-networking/recipes-support/mctp/mctp_2.0.bb
> >>>>>> +++ b/meta-networking/recipes-support/mctp/mctp_2.0.bb
> >>>>>> @@ -5,9 +5,9 @@ LICENSE = "GPL-2.0-only"
> >>>>>>
> >>>>>>     LIC_FILES_CHKSUM = "file://
> >>>>>> LICENSE;md5=4cc91856b08b094b4f406a29dc61db21"
> >>>>>>
> >>>>>> -SRCREV = "f110926b082731b25720b444378ad55d7a9d451d"
> >>>>>> +SRCREV = "089dc53fa7387cca517cd713061c323ca06fb6dd"
> >>>>>>
> >>>>>> -SRC_URI = "git://github.com/CodeConstruct/
> >>>>>> mctp;branch=main;protocol=https"
> >>>>>> +SRC_URI = "git://github.com/CodeConstruct/mctp;branch=dev/cross-
> >>>>>> fixes;protocol=https"
> >>>>>>
> >>>>>>     S = "${WORKDIR}/git"
> >>>>>>
> >>>>>
> >>>
> >>
>
Chanh Nguyen Oct. 25, 2024, 4:18 p.m. UTC | #11
On 25/10/2024 22:59, Khem Raj wrote:
> On Fri, Oct 25, 2024 at 8:49 AM Chanh Nguyen
> <chanh@amperemail.onmicrosoft.com> wrote:
>>
>>
>>
>> On 24/10/2024 22:22, Khem Raj wrote:
>>> On Thu, Oct 24, 2024 at 7:57 AM Chanh Nguyen
>>> <chanh@amperemail.onmicrosoft.com> wrote:
>>>>
>>>>
>>>>
>>>> On 24/10/2024 21:46, Chanh Nguyen wrote:
>>>>>
>>>>>
>>>>> On 24/10/2024 19:18, Khem Raj wrote:
>>>>>> Please test it and wait it to merge before sending pull request here,
>>>>>> feature branches are temporary and usually not something we use in OE
>>>>>>
>>>>>
>>>>> Yes Khem, it is only temporary for CI build checking.
>>>>>
>>>>> Can you please help run CI build? If any other errors, we'll fix.
>>>>>
>>>>> Thanks,
>>>>> Chanh
>>>>>
>>>> I and Jeremy used the musl compiler (https://musl.cc/), and it compiled
>>>> the MCTP successfully. It seems the error just happens with your CI run,
>>>> and we haven't known to run the CI to check.
>>>>
>>>
>>> As I mentioned before, the combination is clang19 + musl, musl.cc is
>>> gcc+musl only so
>>> you won't see clang specific issues with it.
>>> That's fine if you can say [RFT] in the subject line to convey the intention.
>>>
>>
>> Thank Khem for your instruction about subject patch!
>>
>> Should I resend this patch with new subject ? It will be
>> [RFT][meta-networking][PATCH] mctp: Fix CI build error with musl+clang
> 
> Not this time, since I have staged it for testing and it seems to work
> for musl+clang case
> AFAICT so please send the final patch with version bump to include the
> fixes that
> Jeremy is pushing into component repo
> 

Thank Khem, If there is any other error CI build, please notice in 
there. I'll report to Jeremy.

If all looks good, I'll send the final patch in next Monday.

>>
>>>>>> On Wed, Oct 23, 2024 at 11:52 PM Chanh Nguyen
>>>>>> <chanh@amperemail.onmicrosoft.com> wrote:
>>>>>>>
>>>>>>> Hi Khem,
>>>>>>>
>>>>>>> This is only a temporary patch. It helps check CI build errors on the
>>>>>>> MCTP repo. Please help run the CI build; if any error you can show here,
>>>>>>> then Jeremy will update the mctp repo to fix errors.
>>>>>>>
>>>>>>> Please don't merge this patch. When the CI builds completely without any
>>>>>>> errors, I will push a new patch with the latest version on the MCTP
>>>>>>> repo.
>>>>>>>
>>>>>>> Thanks,
>>>>>>>
>>>>>>> Chanh
>>>>>>>
>>>>>>> On 24/10/2024 13:51, Chanh Nguyen wrote:
>>>>>>>> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
>>>>>>>> ---
>>>>>>>>      meta-networking/recipes-support/mctp/mctp_2.0.bb | 4 ++--
>>>>>>>>      1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>>>>
>>>>>>>> diff --git a/meta-networking/recipes-support/mctp/mctp_2.0.bb b/
>>>>>>>> meta-networking/recipes-support/mctp/mctp_2.0.bb
>>>>>>>> index c6aa7c104..793afe755 100644
>>>>>>>> --- a/meta-networking/recipes-support/mctp/mctp_2.0.bb
>>>>>>>> +++ b/meta-networking/recipes-support/mctp/mctp_2.0.bb
>>>>>>>> @@ -5,9 +5,9 @@ LICENSE = "GPL-2.0-only"
>>>>>>>>
>>>>>>>>      LIC_FILES_CHKSUM = "file://
>>>>>>>> LICENSE;md5=4cc91856b08b094b4f406a29dc61db21"
>>>>>>>>
>>>>>>>> -SRCREV = "f110926b082731b25720b444378ad55d7a9d451d"
>>>>>>>> +SRCREV = "089dc53fa7387cca517cd713061c323ca06fb6dd"
>>>>>>>>
>>>>>>>> -SRC_URI = "git://github.com/CodeConstruct/
>>>>>>>> mctp;branch=main;protocol=https"
>>>>>>>> +SRC_URI = "git://github.com/CodeConstruct/mctp;branch=dev/cross-
>>>>>>>> fixes;protocol=https"
>>>>>>>>
>>>>>>>>      S = "${WORKDIR}/git"
>>>>>>>>
>>>>>>>
>>>>>
>>>>
>>
diff mbox series

Patch

diff --git a/meta-networking/recipes-support/mctp/mctp_2.0.bb b/meta-networking/recipes-support/mctp/mctp_2.0.bb
index c6aa7c104..793afe755 100644
--- a/meta-networking/recipes-support/mctp/mctp_2.0.bb
+++ b/meta-networking/recipes-support/mctp/mctp_2.0.bb
@@ -5,9 +5,9 @@  LICENSE = "GPL-2.0-only"
 
 LIC_FILES_CHKSUM = "file://LICENSE;md5=4cc91856b08b094b4f406a29dc61db21"
 
-SRCREV = "f110926b082731b25720b444378ad55d7a9d451d"
+SRCREV = "089dc53fa7387cca517cd713061c323ca06fb6dd"
 
-SRC_URI = "git://github.com/CodeConstruct/mctp;branch=main;protocol=https"
+SRC_URI = "git://github.com/CodeConstruct/mctp;branch=dev/cross-fixes;protocol=https"
 
 S = "${WORKDIR}/git"