| Message ID | 20241025091614.2034294-1-fathi.boudra@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | libksba: add bison (yacc) dependency | expand |
Why is this not a build error? Alex On Fri, 25 Oct 2024 at 11:16, Fathi Boudra via lists.openembedded.org <fathi.boudra=linaro.org@lists.openembedded.org> wrote: > > Add build dependency to bison because yacc is required: > https://git.gnupg.org/cgi-bin/gitweb.cgi?p=libksba.git;a=blob;f=configure.ac;h=a2b213f245786d010e0fbf3e19291f0b1ab2373e;hb=3a4382259c3c6e7ef38cd33626fe2c1da282f816#l162 > > Fix ftbfs (triggered on scarthgap, but same apply to master): > | test -f asn1-parse.c || /bin/bash ../../libksba-1.6.6/build-aux/ylwrap ../../libksba-1.6.6/src/asn1-parse.y y.tab.c asn1-parse.c y.tab.h `echo asn1-parse.c | sed -e s/cc$/hh/ -e s/cpp$/hpp/ -e s/cxx$/hxx/ -e s/c++$/h++/ -e s/c$/h/` y.output asn1-parse.output -- yacc > | ../../libksba-1.6.6/build-aux/ylwrap: line 175: yacc: command not found > > Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org> > --- > meta/recipes-support/libksba/libksba_1.6.7.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-support/libksba/libksba_1.6.7.bb b/meta/recipes-support/libksba/libksba_1.6.7.bb > index b7a9fc4050..7d308c66fa 100644 > --- a/meta/recipes-support/libksba/libksba_1.6.7.bb > +++ b/meta/recipes-support/libksba/libksba_1.6.7.bb > @@ -14,7 +14,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=fd541d83f75d038c4e0617b672ed8bda \ > file://COPYING.LGPLv3;md5=e6a600fd5e1d9cbde2d983680233ad02 \ > " > > -DEPENDS = "libgpg-error" > +DEPENDS = "bison libgpg-error" > > BINCONFIG = "${bindir}/ksba-config" > > -- > 2.45.2 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#206344): https://lists.openembedded.org/g/openembedded-core/message/206344 > Mute This Topic: https://lists.openembedded.org/mt/109204960/1686489 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On Fri, 25 Oct 2024 at 11:20, Alexander Kanavin <alex.kanavin@gmail.com> wrote: > > Why is this not a build error? I haven't investigated yet why it isn't triggered on the YP autobuilder. It's triggered on my Scarthgap based build, and by looking at libksba configure, it needs yacc. Adding the build dependency locally fixed the build issue. We can see in do_configure log we run autoreconf and get: [...] checking for bison... no checking for byacc... no checking if bison is the parser generator... no [...] *** *** Note: The installed yacc version is not GNU Bison. You need *** to install Bison if you want to change any grammar (.y) file. *** [...] > Alex
Can you check this with plain poky master? It should build there even without this change. Alex On Fri 25. Oct 2024 at 11.36, Fathi Boudra <fathi.boudra@linaro.org> wrote: > On Fri, 25 Oct 2024 at 11:20, Alexander Kanavin <alex.kanavin@gmail.com> > wrote: > > > > Why is this not a build error? > > I haven't investigated yet why it isn't triggered on the YP autobuilder. > It's triggered on my Scarthgap based build, and by looking at libksba > configure, it needs yacc. > > Adding the build dependency locally fixed the build issue. > > We can see in do_configure log we run autoreconf and get: > > [...] > checking for bison... no > checking for byacc... no > checking if bison is the parser generator... no > [...] > *** > *** Note: The installed yacc version is not GNU Bison. You need > *** to install Bison if you want to change any grammar (.y) file. > *** > [...] > > > Alex >
Basically your build regenerates asn1-parse.c from asn1-parse.y, and it shouldn't. You should look into why that happens, using poky master as a reference. Alex On Fri, 25 Oct 2024 at 11:39, Alexander Kanavin via lists.openembedded.org <alex.kanavin=gmail.com@lists.openembedded.org> wrote: > > Can you check this with plain poky master? It should build there even without this change. > > Alex > > On Fri 25. Oct 2024 at 11.36, Fathi Boudra <fathi.boudra@linaro.org> wrote: >> >> On Fri, 25 Oct 2024 at 11:20, Alexander Kanavin <alex.kanavin@gmail.com> wrote: >> > >> > Why is this not a build error? >> >> I haven't investigated yet why it isn't triggered on the YP autobuilder. >> It's triggered on my Scarthgap based build, and by looking at libksba >> configure, it needs yacc. >> >> Adding the build dependency locally fixed the build issue. >> >> We can see in do_configure log we run autoreconf and get: >> >> [...] >> checking for bison... no >> checking for byacc... no >> checking if bison is the parser generator... no >> [...] >> *** >> *** Note: The installed yacc version is not GNU Bison. You need >> *** to install Bison if you want to change any grammar (.y) file. >> *** >> [...] >> >> > Alex > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#206347): https://lists.openembedded.org/g/openembedded-core/message/206347 > Mute This Topic: https://lists.openembedded.org/mt/109204960/1686489 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On Fri, Oct 25, 2024 at 2:16 AM Fathi Boudra via lists.openembedded.org <fathi.boudra=linaro.org@lists.openembedded.org> wrote: > > Add build dependency to bison because yacc is required: > https://git.gnupg.org/cgi-bin/gitweb.cgi?p=libksba.git;a=blob;f=configure.ac;h=a2b213f245786d010e0fbf3e19291f0b1ab2373e;hb=3a4382259c3c6e7ef38cd33626fe2c1da282f816#l162 > > Fix ftbfs (triggered on scarthgap, but same apply to master): > | test -f asn1-parse.c || /bin/bash ../../libksba-1.6.6/build-aux/ylwrap ../../libksba-1.6.6/src/asn1-parse.y y.tab.c asn1-parse.c y.tab.h `echo asn1-parse.c | sed -e s/cc$/hh/ -e s/cpp$/hpp/ -e s/cxx$/hxx/ -e s/c++$/h++/ -e s/c$/h/` y.output asn1-parse.output -- yacc > | ../../libksba-1.6.6/build-aux/ylwrap: line 175: yacc: command not found > > Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org> > --- > meta/recipes-support/libksba/libksba_1.6.7.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-support/libksba/libksba_1.6.7.bb b/meta/recipes-support/libksba/libksba_1.6.7.bb > index b7a9fc4050..7d308c66fa 100644 > --- a/meta/recipes-support/libksba/libksba_1.6.7.bb > +++ b/meta/recipes-support/libksba/libksba_1.6.7.bb > @@ -14,7 +14,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=fd541d83f75d038c4e0617b672ed8bda \ > file://COPYING.LGPLv3;md5=e6a600fd5e1d9cbde2d983680233ad02 \ > " > > -DEPENDS = "libgpg-error" > +DEPENDS = "bison libgpg-error" I think we need bison-native here. > > BINCONFIG = "${bindir}/ksba-config" > > -- > 2.45.2 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#206344): https://lists.openembedded.org/g/openembedded-core/message/206344 > Mute This Topic: https://lists.openembedded.org/mt/109204960/1997914 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
diff --git a/meta/recipes-support/libksba/libksba_1.6.7.bb b/meta/recipes-support/libksba/libksba_1.6.7.bb index b7a9fc4050..7d308c66fa 100644 --- a/meta/recipes-support/libksba/libksba_1.6.7.bb +++ b/meta/recipes-support/libksba/libksba_1.6.7.bb @@ -14,7 +14,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=fd541d83f75d038c4e0617b672ed8bda \ file://COPYING.LGPLv3;md5=e6a600fd5e1d9cbde2d983680233ad02 \ " -DEPENDS = "libgpg-error" +DEPENDS = "bison libgpg-error" BINCONFIG = "${bindir}/ksba-config"
Add build dependency to bison because yacc is required: https://git.gnupg.org/cgi-bin/gitweb.cgi?p=libksba.git;a=blob;f=configure.ac;h=a2b213f245786d010e0fbf3e19291f0b1ab2373e;hb=3a4382259c3c6e7ef38cd33626fe2c1da282f816#l162 Fix ftbfs (triggered on scarthgap, but same apply to master): | test -f asn1-parse.c || /bin/bash ../../libksba-1.6.6/build-aux/ylwrap ../../libksba-1.6.6/src/asn1-parse.y y.tab.c asn1-parse.c y.tab.h `echo asn1-parse.c | sed -e s/cc$/hh/ -e s/cpp$/hpp/ -e s/cxx$/hxx/ -e s/c++$/h++/ -e s/c$/h/` y.output asn1-parse.output -- yacc | ../../libksba-1.6.6/build-aux/ylwrap: line 175: yacc: command not found Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org> --- meta/recipes-support/libksba/libksba_1.6.7.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)