| Message ID | 20241021091535.117383-1-Pawan.Badganchi@kpit.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Steve Sakoman |
| Headers | show |
| Series | [kirkstone] run-ptest: removed 'sed -u' option | expand |
The commit header should say "e2fsprogs: do not use -u sed option in run-ptest". Also can you check run-ptest in other recipes if they have the same problem? On Mon, 21 Oct 2024 at 11:15, Pawan Badganchi via lists.openembedded.org <badganchipv=gmail.com@lists.openembedded.org> wrote: > > From: Aditya Tayade <Aditya.Tayade@kpit.com> > > In embedded box, sed might be provided another providers like Busybox, > hence use generic options whenever possible. > /bin/sed -> /etc/alternatives/sed > /etc/alternatives/sed -> /bin/busybox.nosuid > > Here used 'sed -u' option is not necessary, hence removed it. > > Fixes below error: > sed: invalid option -- 'u' > > Also added 'set -eux' option which halts execution of the script > on any failures. > > Signed-off-by: Aditya Tayade <Aditya.Tayade@kpit.com> > Signed-off-by: Pawan Badganchi <Pawan.Badganchi@kpit.com> > --- > meta/recipes-devtools/e2fsprogs/e2fsprogs/run-ptest | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs/run-ptest b/meta/recipes-devtools/e2fsprogs/e2fsprogs/run-ptest > index 279923db8e..1857a17189 100644 > --- a/meta/recipes-devtools/e2fsprogs/e2fsprogs/run-ptest > +++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs/run-ptest > @@ -1,7 +1,8 @@ > #!/bin/sh > > +set -eux > cd ./test > -SKIP_SLOW_TESTS=yes ./test_script | sed -u -e '/:[[:space:]]ok/s/^/PASS: /' -e '/:[[:space:]]failed/s/^/FAIL: /' -e '/:[[:space:]]skipped/s/^/SKIP: /' > +SKIP_SLOW_TESTS=yes ./test_script | sed -e '/:[[:space:]]ok/s/^/PASS: /' -e '/:[[:space:]]failed/s/^/FAIL: /' -e '/:[[:space:]]skipped/s/^/SKIP: /' > rm -rf /var/volatile/tmp/*e2fsprogs* > rm -f tmp-* > rm -f *.tmp > -- > 2.25.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#206101): https://lists.openembedded.org/g/openembedded-core/message/206101 > Mute This Topic: https://lists.openembedded.org/mt/109129050/1686489 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
Hi, Updated the patch and sent. Yes we will look at for other recipes as well. Thanks.
diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs/run-ptest b/meta/recipes-devtools/e2fsprogs/e2fsprogs/run-ptest index 279923db8e..1857a17189 100644 --- a/meta/recipes-devtools/e2fsprogs/e2fsprogs/run-ptest +++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs/run-ptest @@ -1,7 +1,8 @@ #!/bin/sh +set -eux cd ./test -SKIP_SLOW_TESTS=yes ./test_script | sed -u -e '/:[[:space:]]ok/s/^/PASS: /' -e '/:[[:space:]]failed/s/^/FAIL: /' -e '/:[[:space:]]skipped/s/^/SKIP: /' +SKIP_SLOW_TESTS=yes ./test_script | sed -e '/:[[:space:]]ok/s/^/PASS: /' -e '/:[[:space:]]failed/s/^/FAIL: /' -e '/:[[:space:]]skipped/s/^/SKIP: /' rm -rf /var/volatile/tmp/*e2fsprogs* rm -f tmp-* rm -f *.tmp