| Message ID | 20241017063626.2089926-1-chanh@os.amperecomputing.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [meta-networking,v2] mctp: upgrade 1.1 -> 2.0 | expand |
ok, now it fails for musl target see https://errors.yoctoproject.org/Errors/Details/809802/ maybe you need to include linux/socket.h to get AF_MCTP address family definition On Wed, Oct 16, 2024 at 11:36 PM Chanh Nguyen <chanh@os.amperecomputing.com> wrote: > > Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com> > --- > Change in v2: > - Fix CI failed [Chanh] > --- > .../recipes-support/mctp/{mctp_1.1.bb => mctp_2.0.bb} | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > rename meta-networking/recipes-support/mctp/{mctp_1.1.bb => mctp_2.0.bb} (93%) > > diff --git a/meta-networking/recipes-support/mctp/mctp_1.1.bb b/meta-networking/recipes-support/mctp/mctp_2.0.bb > similarity index 93% > rename from meta-networking/recipes-support/mctp/mctp_1.1.bb > rename to meta-networking/recipes-support/mctp/mctp_2.0.bb > index bf3961be4..62044e007 100644 > --- a/meta-networking/recipes-support/mctp/mctp_1.1.bb > +++ b/meta-networking/recipes-support/mctp/mctp_2.0.bb > @@ -5,7 +5,7 @@ LICENSE = "GPL-2.0-only" > > LIC_FILES_CHKSUM = "file://LICENSE;md5=4cc91856b08b094b4f406a29dc61db21" > > -SRCREV = "a591ad885aa28f113cb45870b2fd5bce48378d6f" > +SRCREV = "9986862f88fd6e6ca75e2a29236cf332d640e600" > > SRC_URI = "git://github.com/CodeConstruct/mctp;branch=main;protocol=https" > > @@ -13,6 +13,10 @@ S = "${WORKDIR}/git" > > inherit meson pkgconfig systemd > > +EXTRA_OEMESON = " \ > + -Dtests=false \ > +" > + > PACKAGECONFIG ??= " \ > ${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \ > " > -- > 2.43.0 >
Hi Khem Raj, Follow the error log, I tried to use the musl cross compiler (https://musl.cc/) to compiler https://github.com/CodeConstruct/mctp and report error to mctp maintainer. Jeremy fixed this error by commit https://github.com/CodeConstruct/mctp/commit/0629ec8976b1d56c17db51805f647bf35f4bfd3b Now I'll push the patch v3 with latest commit from mctp repo. Khem Raj, How can I run CI on meta-openembedded manually? I would like to verify errors from CI failed before push patch. That will help us work on the patch quickly. Thanks, Chanh On 18/10/2024 03:46, Khem Raj via lists.openembedded.org wrote: > ok, now it fails for musl target see > > https://errors.yoctoproject.org/Errors/Details/809802/ > > maybe you need to include linux/socket.h to get AF_MCTP address family > definition > > On Wed, Oct 16, 2024 at 11:36 PM Chanh Nguyen > <chanh@os.amperecomputing.com> wrote: >> >> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com> >> --- >> Change in v2: >> - Fix CI failed [Chanh] >> --- >> .../recipes-support/mctp/{mctp_1.1.bb => mctp_2.0.bb} | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> rename meta-networking/recipes-support/mctp/{mctp_1.1.bb => mctp_2.0.bb} (93%) >> >> diff --git a/meta-networking/recipes-support/mctp/mctp_1.1.bb b/meta-networking/recipes-support/mctp/mctp_2.0.bb >> similarity index 93% >> rename from meta-networking/recipes-support/mctp/mctp_1.1.bb >> rename to meta-networking/recipes-support/mctp/mctp_2.0.bb >> index bf3961be4..62044e007 100644 >> --- a/meta-networking/recipes-support/mctp/mctp_1.1.bb >> +++ b/meta-networking/recipes-support/mctp/mctp_2.0.bb >> @@ -5,7 +5,7 @@ LICENSE = "GPL-2.0-only" >> >> LIC_FILES_CHKSUM = "file://LICENSE;md5=4cc91856b08b094b4f406a29dc61db21" >> >> -SRCREV = "a591ad885aa28f113cb45870b2fd5bce48378d6f" >> +SRCREV = "9986862f88fd6e6ca75e2a29236cf332d640e600" >> >> SRC_URI = "git://github.com/CodeConstruct/mctp;branch=main;protocol=https" >> >> @@ -13,6 +13,10 @@ S = "${WORKDIR}/git" >> >> inherit meson pkgconfig systemd >> >> +EXTRA_OEMESON = " \ >> + -Dtests=false \ >> +" >> + >> PACKAGECONFIG ??= " \ >> ${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \ >> " >> -- >> 2.43.0 >> >> >> >> -=-=-=-=-=-=-=-=-=-=-=- >> Links: You receive all messages sent to this group. >> View/Reply Online (#112970): https://lists.openembedded.org/g/openembedded-devel/message/112970 >> Mute This Topic: https://lists.openembedded.org/mt/109059332/9027231 >> Group Owner: openembedded-devel+owner@lists.openembedded.org >> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [chanh@os.amperecomputing.com] >> -=-=-=-=-=-=-=-=-=-=-=- >>
On 10/18/24 12:18 AM, Chanh Nguyen wrote: > Hi Khem Raj, > > Follow the error log, I tried to use the musl cross compiler (https:// > musl.cc/) to compiler https://github.com/CodeConstruct/mctp and report > error to mctp maintainer. Jeremy fixed this error by commit https:// > github.com/CodeConstruct/mctp/ > commit/0629ec8976b1d56c17db51805f647bf35f4bfd3b > > Now I'll push the patch v3 with latest commit from mctp repo. Thanks for following up. > > Khem Raj, How can I run CI on meta-openembedded manually? I would like > to verify errors from CI failed before push patch. That will help us > work on the patch quickly. > We do not have CI infrastructure that is available for developers via github pull requests or some such, process is for maintainers to cherry-pick patches and prepare a staging branch ( master-next ) which is then used for CI, I use yoe distro https://github.com/YoeDistro/yoe-distro for CI'ing meta-openembedded ( using yoe/mut branch) by doing bunch of different build combinations, along with github actions https://github.com/YoeDistro/yoe-distro/blob/master/.github/workflows/ci.yaml bitbake -k world for qemuarm/qemuarm64/qemux86-64/qemuriscv32/qemuriscv64 machines with TCLIBC = musl and TCLIBC = glibc These combinations can explode, and I do not have enough build capacity to do more. There is also one build (qemux86-64) in yocto autobuilder which is run on subset of meta-openembedded layers. https://valkyrie.yoctoproject.org/#/builders/81 I think if you build for musl/glibc/qemux86-64 that would be a good start > Thanks, > Chanh > > > On 18/10/2024 03:46, Khem Raj via lists.openembedded.org wrote: >> ok, now it fails for musl target see >> >> https://errors.yoctoproject.org/Errors/Details/809802/ >> >> maybe you need to include linux/socket.h to get AF_MCTP address family >> definition >> >> On Wed, Oct 16, 2024 at 11:36 PM Chanh Nguyen >> <chanh@os.amperecomputing.com> wrote: >>> >>> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com> >>> --- >>> Change in v2: >>> - Fix CI failed [Chanh] >>> --- >>> .../recipes-support/mctp/{mctp_1.1.bb => mctp_2.0.bb} | 6 +++++- >>> 1 file changed, 5 insertions(+), 1 deletion(-) >>> rename meta-networking/recipes-support/mctp/{mctp_1.1.bb => >>> mctp_2.0.bb} (93%) >>> >>> diff --git a/meta-networking/recipes-support/mctp/mctp_1.1.bb b/meta- >>> networking/recipes-support/mctp/mctp_2.0.bb >>> similarity index 93% >>> rename from meta-networking/recipes-support/mctp/mctp_1.1.bb >>> rename to meta-networking/recipes-support/mctp/mctp_2.0.bb >>> index bf3961be4..62044e007 100644 >>> --- a/meta-networking/recipes-support/mctp/mctp_1.1.bb >>> +++ b/meta-networking/recipes-support/mctp/mctp_2.0.bb >>> @@ -5,7 +5,7 @@ LICENSE = "GPL-2.0-only" >>> >>> LIC_FILES_CHKSUM = "file:// >>> LICENSE;md5=4cc91856b08b094b4f406a29dc61db21" >>> >>> -SRCREV = "a591ad885aa28f113cb45870b2fd5bce48378d6f" >>> +SRCREV = "9986862f88fd6e6ca75e2a29236cf332d640e600" >>> >>> SRC_URI = "git://github.com/CodeConstruct/ >>> mctp;branch=main;protocol=https" >>> >>> @@ -13,6 +13,10 @@ S = "${WORKDIR}/git" >>> >>> inherit meson pkgconfig systemd >>> >>> +EXTRA_OEMESON = " \ >>> + -Dtests=false \ >>> +" >>> + >>> PACKAGECONFIG ??= " \ >>> ${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \ >>> " >>> -- >>> 2.43.0 >>> >>> >>> >>> -=-=-=-=-=-=-=-=-=-=-=- >>> Links: You receive all messages sent to this group. >>> View/Reply Online (#112970): https://lists.openembedded.org/g/ >>> openembedded-devel/message/112970 >>> Mute This Topic: https://lists.openembedded.org/mt/109059332/9027231 >>> Group Owner: openembedded-devel+owner@lists.openembedded.org >>> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/ >>> unsub [chanh@os.amperecomputing.com] >>> -=-=-=-=-=-=-=-=-=-=-=- >>> >
Chanh Can you send a patch on top of the latest master, I have applied the v2, so please send delta which fixed the musl build as a new patch. On Fri, Oct 18, 2024 at 12:19 AM Chanh Nguyen <chanh@amperemail.onmicrosoft.com> wrote: > > Hi Khem Raj, > > Follow the error log, I tried to use the musl cross compiler > (https://musl.cc/) to compiler https://github.com/CodeConstruct/mctp and > report error to mctp maintainer. Jeremy fixed this error by commit > https://github.com/CodeConstruct/mctp/commit/0629ec8976b1d56c17db51805f647bf35f4bfd3b > > > Now I'll push the patch v3 with latest commit from mctp repo. > > Khem Raj, How can I run CI on meta-openembedded manually? I would like > to verify errors from CI failed before push patch. That will help us > work on the patch quickly. > > Thanks, > Chanh > > > On 18/10/2024 03:46, Khem Raj via lists.openembedded.org wrote: > > ok, now it fails for musl target see > > > > https://errors.yoctoproject.org/Errors/Details/809802/ > > > > maybe you need to include linux/socket.h to get AF_MCTP address family > > definition > > > > On Wed, Oct 16, 2024 at 11:36 PM Chanh Nguyen > > <chanh@os.amperecomputing.com> wrote: > >> > >> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com> > >> --- > >> Change in v2: > >> - Fix CI failed [Chanh] > >> --- > >> .../recipes-support/mctp/{mctp_1.1.bb => mctp_2.0.bb} | 6 +++++- > >> 1 file changed, 5 insertions(+), 1 deletion(-) > >> rename meta-networking/recipes-support/mctp/{mctp_1.1.bb => mctp_2.0.bb} (93%) > >> > >> diff --git a/meta-networking/recipes-support/mctp/mctp_1.1.bb b/meta-networking/recipes-support/mctp/mctp_2.0.bb > >> similarity index 93% > >> rename from meta-networking/recipes-support/mctp/mctp_1.1.bb > >> rename to meta-networking/recipes-support/mctp/mctp_2.0.bb > >> index bf3961be4..62044e007 100644 > >> --- a/meta-networking/recipes-support/mctp/mctp_1.1.bb > >> +++ b/meta-networking/recipes-support/mctp/mctp_2.0.bb > >> @@ -5,7 +5,7 @@ LICENSE = "GPL-2.0-only" > >> > >> LIC_FILES_CHKSUM = "file://LICENSE;md5=4cc91856b08b094b4f406a29dc61db21" > >> > >> -SRCREV = "a591ad885aa28f113cb45870b2fd5bce48378d6f" > >> +SRCREV = "9986862f88fd6e6ca75e2a29236cf332d640e600" > >> > >> SRC_URI = "git://github.com/CodeConstruct/mctp;branch=main;protocol=https" > >> > >> @@ -13,6 +13,10 @@ S = "${WORKDIR}/git" > >> > >> inherit meson pkgconfig systemd > >> > >> +EXTRA_OEMESON = " \ > >> + -Dtests=false \ > >> +" > >> + > >> PACKAGECONFIG ??= " \ > >> ${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \ > >> " > >> -- > >> 2.43.0 > >> > >> > >> > >> -=-=-=-=-=-=-=-=-=-=-=- > >> Links: You receive all messages sent to this group. > >> View/Reply Online (#112970): https://lists.openembedded.org/g/openembedded-devel/message/112970 > >> Mute This Topic: https://lists.openembedded.org/mt/109059332/9027231 > >> Group Owner: openembedded-devel+owner@lists.openembedded.org > >> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [chanh@os.amperecomputing.com] > >> -=-=-=-=-=-=-=-=-=-=-=- > >> >
On 21/10/2024 09:29, Khem Raj via lists.openembedded.org wrote: > Chanh > > Can you send a patch on top of the latest master, I have applied the > v2, so please send delta which fixed the musl build as a new patch. > Hi Khem Raj, I saw my patch was merged to the master branch of meta-openembedded https://github.com/openembedded/meta-openembedded/commit/b51e4288b93a97467b1d7dd77b4fab537bc311e3 I haven't understood your comment. What should I do now? Thanks, Chanh > On Fri, Oct 18, 2024 at 12:19 AM Chanh Nguyen > <chanh@amperemail.onmicrosoft.com> wrote: >> >> Hi Khem Raj, >> >> Follow the error log, I tried to use the musl cross compiler >> (https://musl.cc/) to compiler https://github.com/CodeConstruct/mctp and >> report error to mctp maintainer. Jeremy fixed this error by commit >> https://github.com/CodeConstruct/mctp/commit/0629ec8976b1d56c17db51805f647bf35f4bfd3b >> >> >> Now I'll push the patch v3 with latest commit from mctp repo. >> >> Khem Raj, How can I run CI on meta-openembedded manually? I would like >> to verify errors from CI failed before push patch. That will help us >> work on the patch quickly. >> >> Thanks, >> Chanh >> >> >> On 18/10/2024 03:46, Khem Raj via lists.openembedded.org wrote: >>> ok, now it fails for musl target see >>> >>> https://errors.yoctoproject.org/Errors/Details/809802/ >>> >>> maybe you need to include linux/socket.h to get AF_MCTP address family >>> definition >>> >>> On Wed, Oct 16, 2024 at 11:36 PM Chanh Nguyen >>> <chanh@os.amperecomputing.com> wrote: >>>> >>>> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com> >>>> --- >>>> Change in v2: >>>> - Fix CI failed [Chanh] >>>> --- >>>> .../recipes-support/mctp/{mctp_1.1.bb => mctp_2.0.bb} | 6 +++++- >>>> 1 file changed, 5 insertions(+), 1 deletion(-) >>>> rename meta-networking/recipes-support/mctp/{mctp_1.1.bb => mctp_2.0.bb} (93%) >>>> >>>> diff --git a/meta-networking/recipes-support/mctp/mctp_1.1.bb b/meta-networking/recipes-support/mctp/mctp_2.0.bb >>>> similarity index 93% >>>> rename from meta-networking/recipes-support/mctp/mctp_1.1.bb >>>> rename to meta-networking/recipes-support/mctp/mctp_2.0.bb >>>> index bf3961be4..62044e007 100644 >>>> --- a/meta-networking/recipes-support/mctp/mctp_1.1.bb >>>> +++ b/meta-networking/recipes-support/mctp/mctp_2.0.bb >>>> @@ -5,7 +5,7 @@ LICENSE = "GPL-2.0-only" >>>> >>>> LIC_FILES_CHKSUM = "file://LICENSE;md5=4cc91856b08b094b4f406a29dc61db21" >>>> >>>> -SRCREV = "a591ad885aa28f113cb45870b2fd5bce48378d6f" >>>> +SRCREV = "9986862f88fd6e6ca75e2a29236cf332d640e600" >>>> >>>> SRC_URI = "git://github.com/CodeConstruct/mctp;branch=main;protocol=https" >>>> >>>> @@ -13,6 +13,10 @@ S = "${WORKDIR}/git" >>>> >>>> inherit meson pkgconfig systemd >>>> >>>> +EXTRA_OEMESON = " \ >>>> + -Dtests=false \ >>>> +" >>>> + >>>> PACKAGECONFIG ??= " \ >>>> ${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \ >>>> " >>>> -- >>>> 2.43.0 >>>> >>>> >>>> >>>> >>>> >> >> >> >> -=-=-=-=-=-=-=-=-=-=-=- >> Links: You receive all messages sent to this group. >> View/Reply Online (#113070): https://lists.openembedded.org/g/openembedded-devel/message/113070 >> Mute This Topic: https://lists.openembedded.org/mt/109059332/9027231 >> Group Owner: openembedded-devel+owner@lists.openembedded.org >> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [chanh@os.amperecomputing.com] >> -=-=-=-=-=-=-=-=-=-=-=- >>
On Sun, Oct 20, 2024 at 8:02 PM Chanh Nguyen <chanh@amperemail.onmicrosoft.com> wrote: > > > > On 21/10/2024 09:29, Khem Raj via lists.openembedded.org wrote: > > Chanh > > > > Can you send a patch on top of the latest master, I have applied the > > v2, so please send delta which fixed the musl build as a new patch. > > > > Hi Khem Raj, > > I saw my patch was merged to the master branch of meta-openembedded > https://github.com/openembedded/meta-openembedded/commit/b51e4288b93a97467b1d7dd77b4fab537bc311e3 > > > I haven't understood your comment. What should I do now? > We still need to get the fix for musl build. So instead of doing the musl fix included in original patch do it as a new patch on top of what got merged. > Thanks, > Chanh > > > On Fri, Oct 18, 2024 at 12:19 AM Chanh Nguyen > > <chanh@amperemail.onmicrosoft.com> wrote: > >> > >> Hi Khem Raj, > >> > >> Follow the error log, I tried to use the musl cross compiler > >> (https://musl.cc/) to compiler https://github.com/CodeConstruct/mctp and > >> report error to mctp maintainer. Jeremy fixed this error by commit > >> https://github.com/CodeConstruct/mctp/commit/0629ec8976b1d56c17db51805f647bf35f4bfd3b > >> > >> > >> Now I'll push the patch v3 with latest commit from mctp repo. > >> > >> Khem Raj, How can I run CI on meta-openembedded manually? I would like > >> to verify errors from CI failed before push patch. That will help us > >> work on the patch quickly. > >> > >> Thanks, > >> Chanh > >> > >> > >> On 18/10/2024 03:46, Khem Raj via lists.openembedded.org wrote: > >>> ok, now it fails for musl target see > >>> > >>> https://errors.yoctoproject.org/Errors/Details/809802/ > >>> > >>> maybe you need to include linux/socket.h to get AF_MCTP address family > >>> definition > >>> > >>> On Wed, Oct 16, 2024 at 11:36 PM Chanh Nguyen > >>> <chanh@os.amperecomputing.com> wrote: > >>>> > >>>> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com> > >>>> --- > >>>> Change in v2: > >>>> - Fix CI failed [Chanh] > >>>> --- > >>>> .../recipes-support/mctp/{mctp_1.1.bb => mctp_2.0.bb} | 6 +++++- > >>>> 1 file changed, 5 insertions(+), 1 deletion(-) > >>>> rename meta-networking/recipes-support/mctp/{mctp_1.1.bb => mctp_2.0.bb} (93%) > >>>> > >>>> diff --git a/meta-networking/recipes-support/mctp/mctp_1.1.bb b/meta-networking/recipes-support/mctp/mctp_2.0.bb > >>>> similarity index 93% > >>>> rename from meta-networking/recipes-support/mctp/mctp_1.1.bb > >>>> rename to meta-networking/recipes-support/mctp/mctp_2.0.bb > >>>> index bf3961be4..62044e007 100644 > >>>> --- a/meta-networking/recipes-support/mctp/mctp_1.1.bb > >>>> +++ b/meta-networking/recipes-support/mctp/mctp_2.0.bb > >>>> @@ -5,7 +5,7 @@ LICENSE = "GPL-2.0-only" > >>>> > >>>> LIC_FILES_CHKSUM = "file://LICENSE;md5=4cc91856b08b094b4f406a29dc61db21" > >>>> > >>>> -SRCREV = "a591ad885aa28f113cb45870b2fd5bce48378d6f" > >>>> +SRCREV = "9986862f88fd6e6ca75e2a29236cf332d640e600" > >>>> > >>>> SRC_URI = "git://github.com/CodeConstruct/mctp;branch=main;protocol=https" > >>>> > >>>> @@ -13,6 +13,10 @@ S = "${WORKDIR}/git" > >>>> > >>>> inherit meson pkgconfig systemd > >>>> > >>>> +EXTRA_OEMESON = " \ > >>>> + -Dtests=false \ > >>>> +" > >>>> + > >>>> PACKAGECONFIG ??= " \ > >>>> ${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \ > >>>> " > >>>> -- > >>>> 2.43.0 > >>>> > >>>> > >>>> > >>>> > >>>> > >> > >> > >> > >> -=-=-=-=-=-=-=-=-=-=-=- > >> Links: You receive all messages sent to this group. > >> View/Reply Online (#113070): https://lists.openembedded.org/g/openembedded-devel/message/113070 > >> Mute This Topic: https://lists.openembedded.org/mt/109059332/9027231 > >> Group Owner: openembedded-devel+owner@lists.openembedded.org > >> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [chanh@os.amperecomputing.com] > >> -=-=-=-=-=-=-=-=-=-=-=- > >> >
On 21/10/2024 10:17, Khem Raj wrote: > On Sun, Oct 20, 2024 at 8:02 PM Chanh Nguyen > <chanh@amperemail.onmicrosoft.com> wrote: >> >> >> >> On 21/10/2024 09:29, Khem Raj via lists.openembedded.org wrote: >>> Chanh >>> >>> Can you send a patch on top of the latest master, I have applied the >>> v2, so please send delta which fixed the musl build as a new patch. >>> >> >> Hi Khem Raj, >> >> I saw my patch was merged to the master branch of meta-openembedded >> https://github.com/openembedded/meta-openembedded/commit/b51e4288b93a97467b1d7dd77b4fab537bc311e3 >> >> >> I haven't understood your comment. What should I do now? >> > > We still need to get the fix for musl build. So instead of doing the > musl fix included in original patch > do it as a new patch on top of what got merged. You mean we need a patch for the musl compiler? I tried to build mctp repo by musl compiler and got error as https://errors.yoctoproject.org/Errors/Details/809802/ log mentioned. It showed the mctp-ops.c code missed linux/socket.h. So, Jeremy added this header to the mctp-ops.c. You can see more at https://github.com/CodeConstruct/mctp/commit/0629ec8976b1d56c17db51805f647bf35f4bfd3b I don't know how to fix the musl compiler to pass this error without fixing in mctp repo. Thanks, Chanh > >> Thanks, >> Chanh >> >>> On Fri, Oct 18, 2024 at 12:19 AM Chanh Nguyen >>> <chanh@amperemail.onmicrosoft.com> wrote: >>>> >>>> Hi Khem Raj, >>>> >>>> Follow the error log, I tried to use the musl cross compiler >>>> (https://musl.cc/) to compiler https://github.com/CodeConstruct/mctp and >>>> report error to mctp maintainer. Jeremy fixed this error by commit >>>> https://github.com/CodeConstruct/mctp/commit/0629ec8976b1d56c17db51805f647bf35f4bfd3b >>>> >>>> >>>> Now I'll push the patch v3 with latest commit from mctp repo. >>>> >>>> Khem Raj, How can I run CI on meta-openembedded manually? I would like >>>> to verify errors from CI failed before push patch. That will help us >>>> work on the patch quickly. >>>> >>>> Thanks, >>>> Chanh >>>> >>>> >>>> On 18/10/2024 03:46, Khem Raj via lists.openembedded.org wrote: >>>>> ok, now it fails for musl target see >>>>> >>>>> https://errors.yoctoproject.org/Errors/Details/809802/ >>>>> >>>>> maybe you need to include linux/socket.h to get AF_MCTP address family >>>>> definition >>>>> >>>>> On Wed, Oct 16, 2024 at 11:36 PM Chanh Nguyen >>>>> <chanh@os.amperecomputing.com> wrote: >>>>>> >>>>>> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com> >>>>>> --- >>>>>> Change in v2: >>>>>> - Fix CI failed [Chanh] >>>>>> --- >>>>>> .../recipes-support/mctp/{mctp_1.1.bb => mctp_2.0.bb} | 6 +++++- >>>>>> 1 file changed, 5 insertions(+), 1 deletion(-) >>>>>> rename meta-networking/recipes-support/mctp/{mctp_1.1.bb => mctp_2.0.bb} (93%) >>>>>> >>>>>> diff --git a/meta-networking/recipes-support/mctp/mctp_1.1.bb b/meta-networking/recipes-support/mctp/mctp_2.0.bb >>>>>> similarity index 93% >>>>>> rename from meta-networking/recipes-support/mctp/mctp_1.1.bb >>>>>> rename to meta-networking/recipes-support/mctp/mctp_2.0.bb >>>>>> index bf3961be4..62044e007 100644 >>>>>> --- a/meta-networking/recipes-support/mctp/mctp_1.1.bb >>>>>> +++ b/meta-networking/recipes-support/mctp/mctp_2.0.bb >>>>>> @@ -5,7 +5,7 @@ LICENSE = "GPL-2.0-only" >>>>>> >>>>>> LIC_FILES_CHKSUM = "file://LICENSE;md5=4cc91856b08b094b4f406a29dc61db21" >>>>>> >>>>>> -SRCREV = "a591ad885aa28f113cb45870b2fd5bce48378d6f" >>>>>> +SRCREV = "9986862f88fd6e6ca75e2a29236cf332d640e600" >>>>>> >>>>>> SRC_URI = "git://github.com/CodeConstruct/mctp;branch=main;protocol=https" >>>>>> >>>>>> @@ -13,6 +13,10 @@ S = "${WORKDIR}/git" >>>>>> >>>>>> inherit meson pkgconfig systemd >>>>>> >>>>>> +EXTRA_OEMESON = " \ >>>>>> + -Dtests=false \ >>>>>> +" >>>>>> + >>>>>> PACKAGECONFIG ??= " \ >>>>>> ${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \ >>>>>> " >>>>>> -- >>>>>> 2.43.0 >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>> >>>> >>>> >>>> -=-=-=-=-=-=-=-=-=-=-=- >>>> Links: You receive all messages sent to this group. >>>> View/Reply Online (#113070): https://lists.openembedded.org/g/openembedded-devel/message/113070 >>>> Mute This Topic: https://lists.openembedded.org/mt/109059332/9027231 >>>> Group Owner: openembedded-devel+owner@lists.openembedded.org >>>> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [chanh@os.amperecomputing.com] >>>> -=-=-=-=-=-=-=-=-=-=-=- >>>> >>
On 21/10/2024 09:29, Khem Raj via lists.openembedded.org wrote: > Chanh > > Can you send a patch on top of the latest master, I have applied the > v2, so please send delta which fixed the musl build as a new patch. > I saw my patch v3 was merged to the master branch of meta-openembedded https://github.com/openembedded/meta-openembedded/commit/b51e4288b93a97467b1d7dd77b4fab537bc311e3 . This is correct revision, no any wrong here. > On Fri, Oct 18, 2024 at 12:19 AM Chanh Nguyen > <chanh@amperemail.onmicrosoft.com> wrote: >> >> Hi Khem Raj, >> >> Follow the error log, I tried to use the musl cross compiler >> (https://musl.cc/) to compiler https://github.com/CodeConstruct/mctp and >> report error to mctp maintainer. Jeremy fixed this error by commit >> https://github.com/CodeConstruct/mctp/commit/0629ec8976b1d56c17db51805f647bf35f4bfd3b >> >> >> Now I'll push the patch v3 with latest commit from mctp repo. >> >> Khem Raj, How can I run CI on meta-openembedded manually? I would like >> to verify errors from CI failed before push patch. That will help us >> work on the patch quickly. >> >> Thanks, >> Chanh >> >> >> On 18/10/2024 03:46, Khem Raj via lists.openembedded.org wrote: >>> ok, now it fails for musl target see >>> >>> https://errors.yoctoproject.org/Errors/Details/809802/ >>> >>> maybe you need to include linux/socket.h to get AF_MCTP address family >>> definition >>> >>> On Wed, Oct 16, 2024 at 11:36 PM Chanh Nguyen >>> <chanh@os.amperecomputing.com> wrote: >>>> >>>> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com> >>>> --- >>>> Change in v2: >>>> - Fix CI failed [Chanh] >>>> --- >>>> .../recipes-support/mctp/{mctp_1.1.bb => mctp_2.0.bb} | 6 +++++- >>>> 1 file changed, 5 insertions(+), 1 deletion(-) >>>> rename meta-networking/recipes-support/mctp/{mctp_1.1.bb => mctp_2.0.bb} (93%) >>>> >>>> diff --git a/meta-networking/recipes-support/mctp/mctp_1.1.bb b/meta-networking/recipes-support/mctp/mctp_2.0.bb >>>> similarity index 93% >>>> rename from meta-networking/recipes-support/mctp/mctp_1.1.bb >>>> rename to meta-networking/recipes-support/mctp/mctp_2.0.bb >>>> index bf3961be4..62044e007 100644 >>>> --- a/meta-networking/recipes-support/mctp/mctp_1.1.bb >>>> +++ b/meta-networking/recipes-support/mctp/mctp_2.0.bb >>>> @@ -5,7 +5,7 @@ LICENSE = "GPL-2.0-only" >>>> >>>> LIC_FILES_CHKSUM = "file://LICENSE;md5=4cc91856b08b094b4f406a29dc61db21" >>>> >>>> -SRCREV = "a591ad885aa28f113cb45870b2fd5bce48378d6f" >>>> +SRCREV = "9986862f88fd6e6ca75e2a29236cf332d640e600" >>>> >>>> SRC_URI = "git://github.com/CodeConstruct/mctp;branch=main;protocol=https" >>>> >>>> @@ -13,6 +13,10 @@ S = "${WORKDIR}/git" >>>> >>>> inherit meson pkgconfig systemd >>>> >>>> +EXTRA_OEMESON = " \ >>>> + -Dtests=false \ >>>> +" >>>> + >>>> PACKAGECONFIG ??= " \ >>>> ${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \ >>>> " >>>> -- >>>> 2.43.0 >>>> >>>> >>>> >>>> >>>> >> >> >> >> -=-=-=-=-=-=-=-=-=-=-=- >> Links: You receive all messages sent to this group. >> View/Reply Online (#113070): https://lists.openembedded.org/g/openembedded-devel/message/113070 >> Mute This Topic: https://lists.openembedded.org/mt/109059332/9027231 >> Group Owner: openembedded-devel+owner@lists.openembedded.org >> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [chanh@os.amperecomputing.com] >> -=-=-=-=-=-=-=-=-=-=-=- >>
Hi Chanh, > I don't know how to fix the musl compiler to pass this error without > fixing in mctp repo. Just rebase your change on top of the current oe tree. Khem has integrated v2 of yours, so you will need to send a delta from v2, which updates to the new mctp upstream,for the musl fix. Cheers, Jeremy
Hi Chanh, > I saw my patch v3 was merged to the master branch of meta-openembedded > https://github.com/openembedded/meta-openembedded/commit/b51e4288b93a97467b1d7dd77b4fab537bc311e3 Ah, neat. Khem had just mentioned that he had merged v2, not v3. So, all looks good here? unless there are other build failures? Cheers, Jeremy
On 23/10/2024 16:38, Jeremy Kerr wrote: > Hi Chanh, >> I saw my patch v3 was merged to the master branch of meta-openembedded >> https://github.com/openembedded/meta-openembedded/commit/b51e4288b93a97467b1d7dd77b4fab537bc311e3 > > Ah, neat. Khem had just mentioned that he had merged v2, not v3. > > So, all looks good here? unless there are other build failures? Yes, Khem had merged v3 (https://patchwork.yoctoproject.org/project/oe/patch/20241018092326.2152223-1-chanh@os.amperecomputing.com/). This patch is good for me. So, I think we don't need to do anything more. > > Cheers, > > > Jeremy
On Wed, Oct 23, 2024 at 2:44 AM Chanh Nguyen <chanh@amperemail.onmicrosoft.com> wrote: > > > > On 23/10/2024 16:38, Jeremy Kerr wrote: > > Hi Chanh, > >> I saw my patch v3 was merged to the master branch of meta-openembedded > >> https://github.com/openembedded/meta-openembedded/commit/b51e4288b93a97467b1d7dd77b4fab537bc311e3 > > > > Ah, neat. Khem had just mentioned that he had merged v2, not v3. > > > > So, all looks good here? unless there are other build failures? > > Yes, Khem had merged v3 > (https://patchwork.yoctoproject.org/project/oe/patch/20241018092326.2152223-1-chanh@os.amperecomputing.com/). > This patch is good for me. > > So, I think we don't need to do anything more. yes, I realized that the build was using an older version of patch since some of my CI builds run over 18 hrs, I lost track of patch versions. seems good for now. > > > > > Cheers, > > > > > > Jeremy >
Hi Jeremy, There is a new build failure seen with musl+clang https://gist.github.com/kraj/cf85e1d301b557c791ecb410f58298ec On Wed, Oct 23, 2024 at 6:41 AM Khem Raj <raj.khem@gmail.com> wrote: > > On Wed, Oct 23, 2024 at 2:44 AM Chanh Nguyen > <chanh@amperemail.onmicrosoft.com> wrote: > > > > > > > > On 23/10/2024 16:38, Jeremy Kerr wrote: > > > Hi Chanh, > > >> I saw my patch v3 was merged to the master branch of meta-openembedded > > >> https://github.com/openembedded/meta-openembedded/commit/b51e4288b93a97467b1d7dd77b4fab537bc311e3 > > > > > > Ah, neat. Khem had just mentioned that he had merged v2, not v3. > > > > > > So, all looks good here? unless there are other build failures? > > > > Yes, Khem had merged v3 > > (https://patchwork.yoctoproject.org/project/oe/patch/20241018092326.2152223-1-chanh@os.amperecomputing.com/). > > This patch is good for me. > > > > So, I think we don't need to do anything more. > > yes, I realized that the build was using an older version of patch > since some of my CI builds run over 18 hrs, > I lost track of patch versions. seems good for now. > > > > > > > > > Cheers, > > > > > > > > > Jeremy > >
Hi Khem, > There is a new build failure seen with musl+clang > > https://gist.github.com/kraj/cf85e1d301b557c791ecb410f58298ec Ah neat, thanks. I've added a couple of fixes, but currently untested for the musl build: https://github.com/CodeConstruct/mctp/compare/main...dev/cross-fixes Chanh / Khem: if these look okay, I can merge to main. Cheers, Jeremy
On 24/10/2024 10:29, Jeremy Kerr wrote: > Hi Khem, >> There is a new build failure seen with musl+clang >> >> https://gist.github.com/kraj/cf85e1d301b557c791ecb410f58298ec > > Ah neat, thanks. I've added a couple of fixes, but currently untested > for the musl build: > > https://github.com/CodeConstruct/mctp/compare/main...dev/cross-fixes > > Chanh / Khem: if these look okay, I can merge to main. > Thank Jeremy, I think I'll create a patch that includes your fixing from https://github.com/CodeConstruct/mctp/compare/main...dev/cross-fixes . I'm going to push this patch to meta-openembedded and Khem will help run the CI build to check error. Cheers, Chanh > Cheers, > > > Jeremy >
On Wed, Oct 23, 2024 at 8:29 PM Jeremy Kerr <jk@codeconstruct.com.au> wrote: > > Hi Khem, > > There is a new build failure seen with musl+clang > > > > https://gist.github.com/kraj/cf85e1d301b557c791ecb410f58298ec > > Ah neat, thanks. I've added a couple of fixes, but currently untested > for the musl build: > > https://github.com/CodeConstruct/mctp/compare/main...dev/cross-fixes > > Chanh / Khem: if these look okay, I can merge to main. > these changes look good to me > Cheers, > > > Jeremy >
diff --git a/meta-networking/recipes-support/mctp/mctp_1.1.bb b/meta-networking/recipes-support/mctp/mctp_2.0.bb similarity index 93% rename from meta-networking/recipes-support/mctp/mctp_1.1.bb rename to meta-networking/recipes-support/mctp/mctp_2.0.bb index bf3961be4..62044e007 100644 --- a/meta-networking/recipes-support/mctp/mctp_1.1.bb +++ b/meta-networking/recipes-support/mctp/mctp_2.0.bb @@ -5,7 +5,7 @@ LICENSE = "GPL-2.0-only" LIC_FILES_CHKSUM = "file://LICENSE;md5=4cc91856b08b094b4f406a29dc61db21" -SRCREV = "a591ad885aa28f113cb45870b2fd5bce48378d6f" +SRCREV = "9986862f88fd6e6ca75e2a29236cf332d640e600" SRC_URI = "git://github.com/CodeConstruct/mctp;branch=main;protocol=https" @@ -13,6 +13,10 @@ S = "${WORKDIR}/git" inherit meson pkgconfig systemd +EXTRA_OEMESON = " \ + -Dtests=false \ +" + PACKAGECONFIG ??= " \ ${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \ "
Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com> --- Change in v2: - Fix CI failed [Chanh] --- .../recipes-support/mctp/{mctp_1.1.bb => mctp_2.0.bb} | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) rename meta-networking/recipes-support/mctp/{mctp_1.1.bb => mctp_2.0.bb} (93%)