Message ID | 20241016122555.21496-1-workjagadeesh@gmail.com |
---|---|
State | New |
Headers | show |
Series | tune-cortexa32: set tune feature as armv8a | expand |
On Wed, Oct 16, 2024 at 5:26 AM Jagadeesh Krishnanjanappa via lists.openembedded.org <workjagadeesh=gmail.com@lists.openembedded.org> wrote: > > Cortexa32 is a 32-bit armv8a architecture processor, so set the tune feature > as armv8a instead of aarch64 which is 64-bit armv8a architecture. > That's right. its aarch32 only arch. This change is fine to apply. > It solves the following build error while compiling libgcc-initial > and libssp-nonshared. > -- snip -- > aarch64-poky-linux-musl-gcc: error: unrecognized command-line option '-mfpu=neon' > aarch64-poky-linux-musl-gcc: error: unrecognized command-line option '-mfloat-abi=hard' > -- snip -- > > Signed-off-by: Jagadeesh Krishnanjanappa <workjagadeesh@gmail.com> > --- > meta/conf/machine/include/arm/armv8a/tune-cortexa32.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/conf/machine/include/arm/armv8a/tune-cortexa32.inc b/meta/conf/machine/include/arm/armv8a/tune-cortexa32.inc > index 25bdf12b18..0eb938a240 100644 > --- a/meta/conf/machine/include/arm/armv8a/tune-cortexa32.inc > +++ b/meta/conf/machine/include/arm/armv8a/tune-cortexa32.inc > @@ -10,7 +10,7 @@ AVAILTUNES += "cortexa32 cortexa32-crypto" > ARMPKGARCH:tune-cortexa32 = "cortexa32" > ARMPKGARCH:tune-cortexa32-crypto = "cortexa32" > # We do not want -march since -mcpu is added above to cover for it > -TUNE_FEATURES:tune-cortexa32 = "aarch64 cortexa32 crc callconvention-hard neon" > +TUNE_FEATURES:tune-cortexa32 = "armv8a cortexa32 crc callconvention-hard neon" > TUNE_FEATURES:tune-cortexa32-crypto = "${TUNE_FEATURES:tune-cortexa32} crypto" > PACKAGE_EXTRA_ARCHS:tune-cortexa32 = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc} cortexa32 cortexa32hf-neon" > PACKAGE_EXTRA_ARCHS:tune-cortexa32-crypto = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa32 cortexa32hf-neon cortexa32hf-neon-crypto" > -- > 2.17.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#205965): https://lists.openembedded.org/g/openembedded-core/message/205965 > Mute This Topic: https://lists.openembedded.org/mt/109042469/1997914 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
Hi Khem, Jagadeesh, On 10/17/24 3:36 AM, Khem Raj via lists.openembedded.org wrote: > On Wed, Oct 16, 2024 at 5:26 AM Jagadeesh Krishnanjanappa via > lists.openembedded.org > <workjagadeesh=gmail.com@lists.openembedded.org> wrote: >> >> Cortexa32 is a 32-bit armv8a architecture processor, so set the tune feature >> as armv8a instead of aarch64 which is 64-bit armv8a architecture. >> > > That's right. its aarch32 only arch. This change is fine to apply. > Do we not have an issue with TUNE_FEATURES:tune-cortexa32 = "aarch64 cortexa32 crc callconvention-hard neon" in meta/conf/machine/include/arm/armv8a/tune-cortexa32.inc as well too then? Cheers, Quentin
On Thu, 17 Oct 2024 at 10:18, Quentin Schulz via lists.openembedded.org <quentin.schulz=cherry.de@lists.openembedded.org> wrote: > >> Cortexa32 is a 32-bit armv8a architecture processor, so set the tune feature > >> as armv8a instead of aarch64 which is 64-bit armv8a architecture. > >> > > > > That's right. its aarch32 only arch. This change is fine to apply. > > > > Do we not have an issue with > TUNE_FEATURES:tune-cortexa32 = "aarch64 cortexa32 crc > callconvention-hard neon" > > in meta/conf/machine/include/arm/armv8a/tune-cortexa32.inc as well too then? The patch is addressing that, no? Is there a different file or a different issue? Alex
Hi Alex, On 10/17/24 10:34 AM, Alexander Kanavin wrote: > On Thu, 17 Oct 2024 at 10:18, Quentin Schulz via > lists.openembedded.org > <quentin.schulz=cherry.de@lists.openembedded.org> wrote: >>>> Cortexa32 is a 32-bit armv8a architecture processor, so set the tune feature >>>> as armv8a instead of aarch64 which is 64-bit armv8a architecture. >>>> >>> >>> That's right. its aarch32 only arch. This change is fine to apply. >>> >> >> Do we not have an issue with >> TUNE_FEATURES:tune-cortexa32 = "aarch64 cortexa32 crc >> callconvention-hard neon" >> >> in meta/conf/machine/include/arm/armv8a/tune-cortexa32.inc as well too then? > > The patch is addressing that, no? Is there a different file or a > different issue? > Definitely a different issue... with my reading abilities :) Sorry for the noise. Quentin
diff --git a/meta/conf/machine/include/arm/armv8a/tune-cortexa32.inc b/meta/conf/machine/include/arm/armv8a/tune-cortexa32.inc index 25bdf12b18..0eb938a240 100644 --- a/meta/conf/machine/include/arm/armv8a/tune-cortexa32.inc +++ b/meta/conf/machine/include/arm/armv8a/tune-cortexa32.inc @@ -10,7 +10,7 @@ AVAILTUNES += "cortexa32 cortexa32-crypto" ARMPKGARCH:tune-cortexa32 = "cortexa32" ARMPKGARCH:tune-cortexa32-crypto = "cortexa32" # We do not want -march since -mcpu is added above to cover for it -TUNE_FEATURES:tune-cortexa32 = "aarch64 cortexa32 crc callconvention-hard neon" +TUNE_FEATURES:tune-cortexa32 = "armv8a cortexa32 crc callconvention-hard neon" TUNE_FEATURES:tune-cortexa32-crypto = "${TUNE_FEATURES:tune-cortexa32} crypto" PACKAGE_EXTRA_ARCHS:tune-cortexa32 = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc} cortexa32 cortexa32hf-neon" PACKAGE_EXTRA_ARCHS:tune-cortexa32-crypto = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa32 cortexa32hf-neon cortexa32hf-neon-crypto"
Cortexa32 is a 32-bit armv8a architecture processor, so set the tune feature as armv8a instead of aarch64 which is 64-bit armv8a architecture. It solves the following build error while compiling libgcc-initial and libssp-nonshared. -- snip -- aarch64-poky-linux-musl-gcc: error: unrecognized command-line option '-mfpu=neon' aarch64-poky-linux-musl-gcc: error: unrecognized command-line option '-mfloat-abi=hard' -- snip -- Signed-off-by: Jagadeesh Krishnanjanappa <workjagadeesh@gmail.com> --- meta/conf/machine/include/arm/armv8a/tune-cortexa32.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)