Message ID | 20241015-deprecated-kmeta-audit-v1-1-4a38514da362@bootlin.com |
---|---|
State | New |
Headers | show |
Series | kernel-yocto: remove deprecated variable KMETA_AUDIT | expand |
On Tue, Oct 15, 2024 at 6:07 AM Antonin Godard <antonin.godard@bootlin.com> wrote: > > This variable has been introduced by commit > 1d4c120edeb6e45665eafd6962a10ebb89d758eb ("kernel-yocto: allow branch > auditing to be suspended") but its usage removed by commit > 0f698dfd1c8bbc0d53ae7977e26685a7a3df52a3 ("kernel-yocto: streamline > patch, configuration and audit phases"). > > I haven't found any reference to this variable elsewhere... so remove it > entirely. I'm actually working on some code that will once again use that variable. Paul Barker submitted some changes that allow in-tree defconfigs to be applied alongside of the fragments that the project hosts. I'm enabling auditing of those fragments as part of that integration, That audit can be a bit noisy, so I'm using that flag to allow it to be disabled for some fragments. Bruce > > Signed-off-by: Antonin Godard <antonin.godard@bootlin.com> > --- > meta/classes-recipe/kernel-yocto.bbclass | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/meta/classes-recipe/kernel-yocto.bbclass b/meta/classes-recipe/kernel-yocto.bbclass > index 6d5c3b6327b61b9bb6678dae2dbf059dbde178f6..bf22f332b955d08e45ad73facde5a82e4b53eef2 100644 > --- a/meta/classes-recipe/kernel-yocto.bbclass > +++ b/meta/classes-recipe/kernel-yocto.bbclass > @@ -23,7 +23,6 @@ SRCREV_FORMAT ?= "meta_machine" > # 2: report options that are not hardware related, but set by a BSP > KCONF_AUDIT_LEVEL ?= "1" > KCONF_BSP_AUDIT_LEVEL ?= "0" > -KMETA_AUDIT ?= "yes" > KMETA_AUDIT_WERROR ?= "" > > # returns local (absolute) path names for all valid patches in the > > --- > base-commit: c83a535d1b32f7fd292cd9caea1ec962bc3c735b > change-id: 20241015-deprecated-kmeta-audit-1ae2e9d46e22 > > Best regards, > -- > Antonin Godard <antonin.godard@bootlin.com> >
Hi Bruce, On 15/10/2024 08:21:13+0000, Bruce Ashfield wrote: > On Tue, Oct 15, 2024 at 6:07 AM Antonin Godard > <antonin.godard@bootlin.com> wrote: > > > > This variable has been introduced by commit > > 1d4c120edeb6e45665eafd6962a10ebb89d758eb ("kernel-yocto: allow branch > > auditing to be suspended") but its usage removed by commit > > 0f698dfd1c8bbc0d53ae7977e26685a7a3df52a3 ("kernel-yocto: streamline > > patch, configuration and audit phases"). > > > > I haven't found any reference to this variable elsewhere... so remove it > > entirely. > > I'm actually working on some code that will once again use that > variable. > > Paul Barker submitted some changes that allow in-tree defconfigs > to be applied alongside of the fragments that the project hosts. I'm > enabling auditing of those fragments as part of that integration, > > That audit can be a bit noisy, so I'm using that flag to allow it to > be disabled for some fragments. > > Bruce Ok sounds good. I'm actually working on documenting some of the variables in kernel-yocto.bbclass, which is why I noticed this. By the way, it feels like the description of KCONF_AUDIT_LEVEL is a bit off compared to what's done in the code. Comment: # LEVELS: # 0: no reporting # 1: report options that are specified, but not in the final config # 2: report options that are not hardware related, but set by a BSP KCONF_AUDIT_LEVEL ?= "1" KCONF_BSP_AUDIT_LEVEL ?= "0" Code: if [ ${KCONF_AUDIT_LEVEL} -gt 1 ]; then bbfatal_log "`cat ${meta_dir}/cfg/merge_config_build.log`" else bbfatal_log "Details can be found at: ${S}/${meta_dir}/cfg/merge_config_build.log" fi I don't see the link between level 2 and the code here. Cheers, Antonin -- Antonin Godard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
diff --git a/meta/classes-recipe/kernel-yocto.bbclass b/meta/classes-recipe/kernel-yocto.bbclass index 6d5c3b6327b61b9bb6678dae2dbf059dbde178f6..bf22f332b955d08e45ad73facde5a82e4b53eef2 100644 --- a/meta/classes-recipe/kernel-yocto.bbclass +++ b/meta/classes-recipe/kernel-yocto.bbclass @@ -23,7 +23,6 @@ SRCREV_FORMAT ?= "meta_machine" # 2: report options that are not hardware related, but set by a BSP KCONF_AUDIT_LEVEL ?= "1" KCONF_BSP_AUDIT_LEVEL ?= "0" -KMETA_AUDIT ?= "yes" KMETA_AUDIT_WERROR ?= "" # returns local (absolute) path names for all valid patches in the
This variable has been introduced by commit 1d4c120edeb6e45665eafd6962a10ebb89d758eb ("kernel-yocto: allow branch auditing to be suspended") but its usage removed by commit 0f698dfd1c8bbc0d53ae7977e26685a7a3df52a3 ("kernel-yocto: streamline patch, configuration and audit phases"). I haven't found any reference to this variable elsewhere... so remove it entirely. Signed-off-by: Antonin Godard <antonin.godard@bootlin.com> --- meta/classes-recipe/kernel-yocto.bbclass | 1 - 1 file changed, 1 deletion(-) --- base-commit: c83a535d1b32f7fd292cd9caea1ec962bc3c735b change-id: 20241015-deprecated-kmeta-audit-1ae2e9d46e22 Best regards,